From: Jarkko Sakkinen <jarkko@kernel.org>
To: linux-integrity@vger.kernel.org
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
William Roberts <bill.c.roberts@gmail.com>,
Stefan Berger <stefanb@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Mimi Zohar <zohar@linux.ibm.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Jerry Snitselaar <jsnitsel@redhat.com>
Subject: [PATCH v5 0/8] Extend struct tpm_buf to support sized buffers (TPM2B)
Date: Wed, 22 Nov 2023 00:31:12 +0200 [thread overview]
Message-ID: <20231121223130.30824-1-jarkko@kernel.org> (raw)
This patch set extends struct tpm_buf to support TPM2 sized buffers, and
adds reader functions for parsing more complex response data. It is
implemented to support smooth landing of [2]. Sealing of the TPM2 trusted
keys is updated to utilize the new functionality, and thus provides a
legit test case for it.
TPM2 sized buffer, i.e. the buffers in TPM2 format, are defined in the
section 10.4 of the TPM2 Structures [1] specification.
Here's the smoke test that I've run for TPM2:
/usr/lib/kselftests/run_kselftest.sh
tpm2_createprimary --hierarchy o -G rsa2048 -c key.ctxt
tpm2_evictcontrol -c key.ctxt 0x81000001
keyctl add trusted kmk "new 32 keyhandle=0x81000001" @u
keyctl add encrypted 1000100010001000 "new ecryptfs trusted:kmk 64" @u
[1] https://trustedcomputinggroup.org/resource/tpm-library-specification/
[2] https://lore.kernel.org/linux-integrity/20230403214003.32093-1-James.Bottomley@HansenPartnership.com/
v5:
- Fixed glitch in tpm_buf_read() reported by James Bottomley to the v4.
Was forgotten from v4.
- Remove a spurious memset() call introduced in v4.
- Allow command buffer tag to be initially set to zero (caused spurious
warnings).
v4:
- Cleaned up the bit too spread code changes based on the v3 review.
- For testing instructions see the previous cover letter, and use
linux-v6.6.y branch:
https://lore.kernel.org/linux-integrity/20231024011531.442587-1-jarkko@kernel.org/
v3:
- Resend with rebase to the latest upstream.
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: William Roberts <bill.c.roberts@gmail.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Mimi Zohar <zohar@linux.ibm.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Jerry Snitselaar <jsnitsel@redhat.com>
James Bottomley (1):
tpm: Move buffer handling from static inlines to real functions
Jarkko Sakkinen (7):
tpm: Remove unused tpm_buf_tag()
tpm: Remove tpm_send()
tpm: Update &tpm_buf documentation
tpm: Store the length of the tpm_buf data separately.
tpm: TPM2B formatted buffers
tpm: Add tpm_buf_read_{u8,u16,u32}
KEYS: trusted: tpm2: Use struct tpm_buf for sized buffers
drivers/char/tpm/Makefile | 1 +
drivers/char/tpm/tpm-buf.c | 222 ++++++++++++++++++++++
drivers/char/tpm/tpm-interface.c | 26 +--
include/keys/trusted_tpm.h | 2 -
include/linux/tpm.h | 112 +++--------
security/keys/trusted-keys/trusted_tpm1.c | 23 ++-
security/keys/trusted-keys/trusted_tpm2.c | 54 +++---
7 files changed, 295 insertions(+), 145 deletions(-)
create mode 100644 drivers/char/tpm/tpm-buf.c
--
2.42.1
next reply other threads:[~2023-11-21 22:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 22:31 Jarkko Sakkinen [this message]
2023-11-21 22:31 ` [PATCH v5 1/8] tpm: Remove unused tpm_buf_tag() Jarkko Sakkinen
2023-11-21 22:31 ` [PATCH v5 2/8] tpm: Remove tpm_send() Jarkko Sakkinen
2023-11-21 22:31 ` [PATCH v5 3/8] tpm: Move buffer handling from static inlines to real functions Jarkko Sakkinen
2023-11-21 22:31 ` [PATCH v5 4/8] tpm: Update &tpm_buf documentation Jarkko Sakkinen
2023-11-21 22:31 ` [PATCH v5 5/8] tpm: Store the length of the tpm_buf data separately Jarkko Sakkinen
2023-11-21 22:31 ` [PATCH v5 6/8] tpm: TPM2B formatted buffers Jarkko Sakkinen
2023-11-21 22:31 ` [PATCH v5 7/8] tpm: Add tpm_buf_read_{u8,u16,u32} Jarkko Sakkinen
2023-11-21 22:31 ` [PATCH v5 8/8] KEYS: trusted: tpm2: Use struct tpm_buf for sized buffers Jarkko Sakkinen
2023-11-28 3:48 ` Serge E. Hallyn
2023-11-28 12:24 ` James Bottomley
2023-11-28 14:34 ` Serge E. Hallyn
2023-11-28 14:37 ` James Bottomley
2023-12-04 4:03 ` Jarkko Sakkinen
2023-11-28 14:42 ` [PATCH v5 0/8] Extend struct tpm_buf to support sized buffers (TPM2B) Serge E. Hallyn
2023-12-04 4:06 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2023-11-21 22:29 Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121223130.30824-1-jarkko@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bill.c.roberts@gmail.com \
--cc=dhowells@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.