All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Akash Kumar <quic_akakum@quicinc.com>
Cc: "Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"Jing Leng" <jleng@ambarella.com>,
	"Felipe Balbi" <balbi@kernel.org>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Pratham Pratap " <quic_ppratap@quicinc.com>,
	"Jack Pham" <quic_jackp@quicinc.com>,
	"Wesley Cheng" <quic_wcheng@quicinc.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: uvc: Add framebased frame format support
Date: Tue, 21 Nov 2023 14:58:55 +0100	[thread overview]
Message-ID: <2023112123-setting-waking-7896@gregkh> (raw)
In-Reply-To: <20231114112516.2723-1-quic_akakum@quicinc.com>

On Tue, Nov 14, 2023 at 04:55:16PM +0530, Akash Kumar wrote:
> Add support for framebased frame format which can be used to support
> multiple formats like H264 or H265 other than mjpeg and YUV frames.
> 
> Framebased format is set to H264 by default, which can be updated to
> other formats by updating the GUID through guid configfs attribute.
> 
> Also,add UVC 1.5 extension to support H264 format and different camera
> controls, adding support for Exposure, Zoom, Pan, tilt.

When you say "also" or list different things that are done in a single
change, that's a huge hint to divide this up into smaller patches and
make it a patch series.

Please do that here.

thanks,

greg k-h

  reply	other threads:[~2023-11-21 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 11:25 [PATCH] usb: gadget: uvc: Add framebased frame format support Akash Kumar
2023-11-21 13:58 ` Greg Kroah-Hartman [this message]
2023-11-21 14:58   ` Dan Scally

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023112123-setting-waking-7896@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=jleng@ambarella.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_akakum@quicinc.com \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.