All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: [viro-vfs:work.rename 10/10] htmldocs: Documentation/filesystems/directory-locking.rst:33: WARNING: Enumerated list ends without a blank line; unexpected unindent.
Date: Wed, 22 Nov 2023 01:33:01 +0800	[thread overview]
Message-ID: <202311220106.QLlI24Qn-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.rename
head:   450e4154067593d27f3bf7e4a19206e00e40b5e6
commit: 450e4154067593d27f3bf7e4a19206e00e40b5e6 [10/10] rename(): avoid a deadlock in the case of parents having no common ancestor
reproduce: (https://download.01.org/0day-ci/archive/20231122/202311220106.QLlI24Qn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311220106.QLlI24Qn-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> Documentation/filesystems/directory-locking.rst:33: WARNING: Enumerated list ends without a blank line; unexpected unindent.
>> Documentation/filesystems/directory-locking.rst:46: WARNING: Unexpected indentation.
>> Documentation/filesystems/directory-locking.rst:47: WARNING: Block quote ends without a blank line; unexpected unindent.
>> Documentation/filesystems/directory-locking.rst:61: WARNING: Definition list ends without a blank line; unexpected unindent.

vim +33 Documentation/filesystems/directory-locking.rst

    27	
    28	4) link creation.  Locking rules:
    29		* lock the parent
    30		* check that the source is not a directory
    31		* lock the source
    32		* call the method.
  > 33	All locks are exclusive.
    34	
    35	5) rename() that is _not_ cross-directory.  Locking rules:
    36		* lock the parent
    37		* find the source and target.
    38		* decide which of the source and target need to be locked.
    39	The source needs to be locked if it's a non-directory, target - if it's
    40	a non-directory or about to be removed.  Take the locks that need to be
    41	taken, in inode pointer order if need to take both (that can happen only
    42	when both source and target are non-directories - the source because
    43	it wouldn't need to be locked otherwise and the target because mixing
    44	directory and non-directory is allowed only with RENAME_EXCHANGE, and
    45	that won't be removing the target).
  > 46		* call the method.
  > 47	All locks are exclusive.
    48	
    49	6) cross-directory rename.  The trickiest in the whole bunch.  Locking
    50	rules:
    51		* lock the filesystem
    52		* if the parents don't have a common ancestor, fail the operation.
    53		* lock the parents in "ancestors first" order. If neither is an
    54	ancestor of the other, lock the parent of source first.
    55		* find the source and target.
    56		* verify that the source is not a descendent of the target and
    57	target is not a descendent of source; fail the operation otherwise.
    58		* lock the subdirectories involved (source before target).
    59		* lock the non-directories involved, in inode pointer order.
    60		* call the method.
  > 61	All ->i_rwsem are taken exclusive.
    62	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-11-21 17:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311220106.QLlI24Qn-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.