From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Tomasz Figa <tfiga@chromium.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Alan Stern <stern@rowland.harvard.edu>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sean Paul <seanpaul@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v3 2/3] media: uvcvideo: Do not halt the device after disconnect
Date: Wed, 22 Nov 2023 17:01:32 +0900 [thread overview]
Message-ID: <20231122080132.GA1526356@google.com> (raw)
In-Reply-To: <20231122074742.GB1465745@google.com>
On (23/11/22 16:47), Sergey Senozhatsky wrote:
> Can the following happen?
Consider the following case (when CPU1 experienced a delay, a preemption
or anything):
> CPU0 CPU1
> uvc_disconnect()
> uvc_video_stop_streaming()
> usb_set_intfdata()
> uvc_unregister_video()
>
> if (!smp_load(&dev->disconnected))
>
> smp_store_release(&dev->disconnected, true);
>
> kref_put(&dev->ref, uvc_delete);
> uvc_video_halt()
That uvc_video_halt() cannot be legal, right?
next prev parent reply other threads:[~2023-11-22 8:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 19:53 [PATCH v3 0/3] uvcvideo: Attempt N to land UVC race conditions fixes Ricardo Ribalda
2023-11-21 19:53 ` [PATCH v3 1/3] media: uvcvideo: Always use uvc_status_stop() Ricardo Ribalda
2023-11-22 7:21 ` Sergey Senozhatsky
2023-11-22 7:35 ` Ricardo Ribalda
2023-11-22 9:53 ` Ricardo Ribalda
2023-11-22 9:58 ` Sakari Ailus
2023-11-22 10:33 ` Ricardo Ribalda
2023-11-21 19:53 ` [PATCH v3 2/3] media: uvcvideo: Do not halt the device after disconnect Ricardo Ribalda
2023-11-22 7:47 ` Sergey Senozhatsky
2023-11-22 8:01 ` Sergey Senozhatsky [this message]
2023-11-22 9:55 ` Ricardo Ribalda
2023-11-22 10:25 ` Sakari Ailus
2023-11-22 10:32 ` Ricardo Ribalda
2023-11-22 11:03 ` Sakari Ailus
2023-11-22 11:35 ` Ricardo Ribalda
2023-11-21 19:53 ` [PATCH v3 3/3] media: uvcvideo: Lock video streams and queues while unregistering Ricardo Ribalda
2023-11-22 8:22 ` Sergey Senozhatsky
2023-11-22 10:21 ` Sakari Ailus
2023-11-22 13:14 ` Laurent Pinchart
2023-11-22 13:59 ` Ricardo Ribalda
2023-11-22 14:04 ` Laurent Pinchart
2023-11-22 14:23 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122080132.GA1526356@google.com \
--to=senozhatsky@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=seanpaul@chromium.org \
--cc=stern@rowland.harvard.edu \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.