From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5612C2574C for ; Wed, 22 Nov 2023 11:50:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Oe7OloYo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8798CC433C7; Wed, 22 Nov 2023 11:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700653802; bh=w3kG8h1VvYc97hgX3wwWf94uIjyQmpKJij2r7xobzXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oe7OloYoY6sfPuiQkjbrcOgApJs1ZDbJur8aDY1z/AW72mN5HB6EsdzkmOIfFv7zQ SuzmSVjhkU6bz58zDeWPVIgBzQsCAusaFrxB14pdzy+hMzenMr6Vewc7hxhn4lJVvE kgI32ynUoz3AEObKOCmkdkspDROCpXEdfan1f2+rhQNvFUFz1tyGZ2bq/k2bZd1fAo OONhbWz2z7E7+wvNMv1lVWUTvPFJITmcEZGVgu2LFcVqkp0NqjMIo9ruYmBJYBEDlL eVSevIxSzaWn0EAOJ2GtvCsFNDZEiMfr3/3gEA9DjH3KInqi4FwiA6tHfTke3YA+1v GzGDBTn8jBUEQ== Date: Wed, 22 Nov 2023 11:49:58 +0000 From: Lee Jones To: Naresh Solanki Cc: Pavel Machek , Patrick Rudolph , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [RESEND PATCH v3] leds: max5970: Add support for max5970 Message-ID: <20231122114958.GJ173820@google.com> References: <20230914114521.1491390-1-naresh.solanki@9elements.com> <20230920130528.GG13143@google.com> <20230921103156.GB3449785@google.com> <20231117121531.GC137434@google.com> <20231121153302.GD173820@google.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Please read this: https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying On Tue, 21 Nov 2023, Naresh Solanki wrote: > Hi Lee, > > Thank you for your insights. I appreciate your guidance on the matter. > Yes will rewrite the change as below: > > regmap = dev_get_regmap(pdev->dev.parent, NULL); > if (!regmap) > return -ENODEV; > > I believe this modification aligns with your suggestion. Please let me > know if this meets the requirements or if you have any further > suggestions or adjustments Please submit the next revision. > On Tue, 21 Nov 2023 at 21:03, Lee Jones wrote: > > > > On Mon, 20 Nov 2023, Naresh Solanki wrote: > > > > > Hi > > > > > > On Fri, 17 Nov 2023 at 17:45, Lee Jones wrote: > > > > > > > > On Thu, 09 Nov 2023, Naresh Solanki wrote: > > > > > > > > > Hey Lee, > > > > > > > > > > Is there anything specific you'd suggest changing in the current > > > > > patchset, or are we good to proceed? > > > > > > > > What do you mean by proceed? > > > > > > > > You are good to make changes and submit a subsequent version. > > > > > > > > Not entirely sure what you're asking. > > > > > > As a follow up on previous discussion regarding use of DEFER on probe > > > if regmap isn't initialized, the implementation was based on other similar > > > drivers & hence it was retained although its not needed due to dependencies. > > > > > > I'm not entirely sure to keep the regmap check or make another > > > patch revision with regmap check removed ? > > > > You tell me. > > > > You should understand the device you're attempting to support along with > > the code you're authoring and its subsequent implications. If you don't > > know what a section of code does or whether/why it's required, why did > > you write it? > > > > -- > > Lee Jones [李琼斯] -- Lee Jones [李琼斯]