From: Simon Horman <horms@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: bjorn@mork.no, andrew@lunn.ch, netdev@vger.kernel.org
Subject: Re: [RFCv2] usbnet: assign unique random MAC
Date: Wed, 22 Nov 2023 17:57:50 +0000 [thread overview]
Message-ID: <20231122175750.GA6731@kernel.org> (raw)
In-Reply-To: <20231120114438.12790-1-oneukum@suse.com>
On Mon, Nov 20, 2023 at 12:44:27PM +0100, Oliver Neukum wrote:
> The old method had the bug of issuing the same
> random MAC over and over even to every device.
> This bug is as old as the driver.
>
> This new method generates each device whose minidriver
> does not provide its own MAC its own unique random
> MAC.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
Thanks Oliver,
I agree with the approach taken here - using a random address as a fallback
if the driver (hw) doesn't provide one. The patch looks clean to me.
And, form my reading, addresses feedback provided on earlier versions.
Reviewed-by: Simon Horman <horms@kernel.org>
When you repost as a non RFC please consider if this is a fix,
in which case it should have an appropriate Fixes tag. Or
as an enhancement (I lean towards this), in which case it should
be targeted at net-next.
The target tree should be included in the Subject, e.g.
Subject: [PATCH net-next] usbnet: assign unique random MAC
Link: https://docs.kernel.org/process/maintainer-netdev.html
Also, please expand the CC list as per the output of:
get_maintainer.pl <this.patch>
...
prev parent reply other threads:[~2023-11-22 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 11:44 [RFCv2] usbnet: assign unique random MAC Oliver Neukum
2023-11-22 17:57 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122175750.GA6731@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.