From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D9FD224DA; Thu, 23 Nov 2023 10:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h1Zdc31y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20063C433C7; Thu, 23 Nov 2023 10:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700734539; bh=gL4xFcxmYSSh7kOgDS87FN5NgH0x5Jtwcq7nF4+rREM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h1Zdc31yNztmTAbJjB1MoYlplWFujXy+xSZ4Fau875psGogC/LQdTAJx0lMBirJXd LX8IF4gocWJwnQJDcfOC4Txuyzk5v3KvC7u/AhnXJLG0ic59OFEJCxLpmpHTWAx+DB NHYfsu1ohIg/HsoRrpPMuaW0SsUaX6mBit2Ko7ozGvmZ/jwqv/FH2FJ4zhCiH7L5Ku RF7t+3pdP8exkNe2GPWkbFxmf2TpdpCh0XhkidqUqYCqr+RCzk9QceY4eCW+5KuPA7 EQgVztpU/Fpe+oHlumhI5R0/HHLBzwLd9ltRQc9+E5LajGwDG+qqrde+gj6x9pt7jY acBV9lv+RN+ug== Date: Thu, 23 Nov 2023 10:15:34 +0000 From: Simon Horman To: Rob Herring Cc: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Appana Durga Kedareswara rao , Naga Sureshkumar Relli , Michal Simek , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] net: can: Use device_get_match_data() Message-ID: <20231123101534.GC46439@kernel.org> References: <20231122180140.1432025-1-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122180140.1432025-1-robh@kernel.org> On Wed, Nov 22, 2023 at 11:01:39AM -0700, Rob Herring wrote: > Use preferred device_get_match_data() instead of of_match_device() to > get the driver match data. With this, adjust the includes to explicitly > include the correct headers. > > Error checking for matching and match data was not necessary as matching > is always successful if we're already in probe and the match tables always > have data pointers. > > Signed-off-by: Rob Herring > --- > v2: > - Drop calling "platform_get_device_id(pdev)->driver_data" in c_can > and flexcan as device_get_match_data() already did that. The logic > was also wrong and would have resulted in returning -ENODEV. > - Drop initializing devtype in xilinx_can Thanks for the updates. Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 368FFC61D85 for ; Thu, 23 Nov 2023 10:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ct2TzNhgRM05S9t7l1v/JRiTT99LyRkYR2NS/7Cp4Gg=; b=Xlvb4Qmw8MUgCe xoi7LqqPPvovfBEBbEyQsK+yaLdJOGAQSROvdvNkO1aZGsRG0lwq4UhsU9feHFR37WRoDQuh06TYS fvtT2Bq1O8V/0BvXT2G5ejDNwKQuKuZlZb3xk3hLBLeUvK/P57BFqlJyz6a5e2l1JUxnaoTxdChSb 39ZAsVQ+f4ctHHd0NDEpbfXitFCIWEusUweFsB15ICRIj0OdWpzZR7IV7zR/m+xw2r8xenFQiUlpU v/g8hMR+9aJ81RJlVSJpWle8n0uXikIWyxWVyrCV+htUeKcY3UloJrF5zHvIzup3AfUYzyvOLj/4z X/ksY0CFTAGswQujTztg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r66kJ-004MGc-2l; Thu, 23 Nov 2023 10:15:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r66kH-004MGF-0I for linux-arm-kernel@lists.infradead.org; Thu, 23 Nov 2023 10:15:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 27F1561B0D; Thu, 23 Nov 2023 10:15:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20063C433C7; Thu, 23 Nov 2023 10:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700734539; bh=gL4xFcxmYSSh7kOgDS87FN5NgH0x5Jtwcq7nF4+rREM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h1Zdc31yNztmTAbJjB1MoYlplWFujXy+xSZ4Fau875psGogC/LQdTAJx0lMBirJXd LX8IF4gocWJwnQJDcfOC4Txuyzk5v3KvC7u/AhnXJLG0ic59OFEJCxLpmpHTWAx+DB NHYfsu1ohIg/HsoRrpPMuaW0SsUaX6mBit2Ko7ozGvmZ/jwqv/FH2FJ4zhCiH7L5Ku RF7t+3pdP8exkNe2GPWkbFxmf2TpdpCh0XhkidqUqYCqr+RCzk9QceY4eCW+5KuPA7 EQgVztpU/Fpe+oHlumhI5R0/HHLBzwLd9ltRQc9+E5LajGwDG+qqrde+gj6x9pt7jY acBV9lv+RN+ug== Date: Thu, 23 Nov 2023 10:15:34 +0000 From: Simon Horman To: Rob Herring Cc: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Appana Durga Kedareswara rao , Naga Sureshkumar Relli , Michal Simek , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] net: can: Use device_get_match_data() Message-ID: <20231123101534.GC46439@kernel.org> References: <20231122180140.1432025-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231122180140.1432025-1-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_021541_173469_89BB0C49 X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 22, 2023 at 11:01:39AM -0700, Rob Herring wrote: > Use preferred device_get_match_data() instead of of_match_device() to > get the driver match data. With this, adjust the includes to explicitly > include the correct headers. > > Error checking for matching and match data was not necessary as matching > is always successful if we're already in probe and the match tables always > have data pointers. > > Signed-off-by: Rob Herring > --- > v2: > - Drop calling "platform_get_device_id(pdev)->driver_data" in c_can > and flexcan as device_get_match_data() already did that. The logic > was also wrong and would have resulted in returning -ENODEV. > - Drop initializing devtype in xilinx_can Thanks for the updates. Reviewed-by: Simon Horman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel