From: Lee Jones <lee@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Expand led_colors[] array
Date: Thu, 23 Nov 2023 10:56:20 +0000 [thread overview]
Message-ID: <20231123105620.GG1184245@google.com> (raw)
In-Reply-To: <20231030054757.3476-1-jszhang@kernel.org>
On Mon, 30 Oct 2023, Jisheng Zhang wrote:
> commit 472d7b9e8141 ("dt-bindings: leds: Expand LED_COLOR_ID
> definitions") expands LED_COLOR_ID definitions for dt-binding. However,
> it doesn't expand the led_colors[] array in leds core, so if any of
> the newly expaned LED_COLOR_ID definitions is used, the sysfs will
> emit null in the led's name color part. Let's expand the led_colors[]
> array too.
>
> Before the commit:
> /sys/class/leds # ls
> (null):indicator-0
>
> After the commit:
> /sys/class/leds # ls
> orange:indicator-0
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> drivers/leds/led-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
This already exists as:
a067943129b4e leds: core: Add more colors from DT bindings to led_colors
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-11-23 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 5:47 [PATCH] leds: Expand led_colors[] array Jisheng Zhang
2023-11-23 10:56 ` Lee Jones [this message]
2023-11-27 15:59 ` Jisheng Zhang
2023-11-30 11:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123105620.GG1184245@google.com \
--to=lee@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.