From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Byron Gallagher <trippgallagher98@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/socat: fix static openssl compatibility
Date: Thu, 23 Nov 2023 11:15:28 +0100 [thread overview]
Message-ID: <20231123111528.3f88828e@windsurf> (raw)
In-Reply-To: <20231121174722.4164-1-trippgallagher98@gmail.com>
Hello Byron,
On Tue, 21 Nov 2023 12:47:22 -0500
Byron Gallagher <trippgallagher98@gmail.com> wrote:
> +diff --git a/configure.ac b/configure.ac
> +index 9d60473..ae0e6bd 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -580,12 +580,12 @@ if test -n "$WITH_OPENSSL" -a "$sc_cv_have_openssl_ssl_h" = 'yes'; then
> + if test -n "$OPENSSL_BASE"; then
> + L="$OPENSSL_BASE/lib"; LIBS="$LIBS -L$L -lssl -lcrypto"
> + else
> +- LIBS="$LIBS -lssl -lcrypto"
> ++ LIBS="$LIBS -lssl -lcrypto -lz"
The downside of this is that socat is then directly linked to libz even
when it's not needed (dynamic linking situation).
The correct/ideal way of handling this is to use pkg-config, as it
properly says whether we need -lssl -lcrypto (dynamic linking case) or
-lssl -lcrypto -lz (static linking case), without hardcoding this in
socat itself.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-23 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 17:47 [Buildroot] [PATCH] package/socat: fix static openssl compatibility Byron Gallagher
2023-11-21 18:09 ` Baruch Siach via buildroot
2023-11-21 18:25 ` Byron Gallagher
2023-11-26 15:41 ` Yann E. MORIN
2023-11-23 10:15 ` Thomas Petazzoni via buildroot [this message]
2023-11-23 17:55 ` Byron Gallagher
2023-11-24 8:53 ` Thomas Petazzoni via buildroot
2023-11-30 20:18 ` Byron Gallagher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123111528.3f88828e@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=trippgallagher98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.