From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21BDA2FC42; Thu, 23 Nov 2023 14:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VfSdJkXJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21DD5C433C8; Thu, 23 Nov 2023 14:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700749488; bh=qOdkWYm5UvV/HgiRSNx6MF2oGmugCohlm/2HC3o1mdI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VfSdJkXJvS+mtHT+AedviFCC5Fwt7buyviGMcgvclSiCLKck5taZwx6DN7+Vr8MhP bYybYMtsQZTERqVPVgMzznDeOf1dNbqGyLHKosiiJddBeeR+pcMCKhChs5saZodgtZ qyuOks1rpFxXU6apAiooZehcQudKVAwdNiPDZaWfLE22Q80auZXKk+Z5MWpQeEeLVd SVLaM9SA30kKgY3eDmsV2p9GzukXkgY/P/tyu7qwoaae1qytqDsCUX57l6Dwo3pBXd 87u7lO+IrutWC/ytZT/CL1hhgVXrrI+WvBUmrLKbuvHvqeL5lShciRRRquuZ8UrG+D SyqprgaqzmibQ== Date: Thu, 23 Nov 2023 14:24:41 +0000 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, Krzysztof Kozlowski , Alim Akhtar , linux-samsung-soc@vger.kernel.org, Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Tony Lindgren , linux-omap@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 00/18] mfd: Convert to platform remove callback returning void Message-ID: <20231123142441.GA1354538@google.com> References: <20231106171708.3892347-1-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231106171708.3892347-1-u.kleine-koenig@pengutronix.de> On Mon, 06 Nov 2023, Uwe Kleine-König wrote: > Hello, > > this series converts all platform drivers below drivers/mfd to use > .remove_new(). Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver > core doesn't (and cannot) cope for errors during remove. The only effect > of a non-zero return value in .remove() is that the driver core emits a > warning. The device is removed anyhow and an early return from .remove() > usually yields resource leaks and/or use-after-free bugs. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > > All drivers converted here already returned zero unconditionally in > .remove(), so they are converted here trivially. > > Best regards > Uwe > > Uwe Kleine-König (18): > mfd: ab8500-sysctrl: Convert to platform remove callback returning > void > mfd: cros_ec_dev: Convert to platform remove callback returning void > mfd: exynos-lpass: Convert to platform remove callback returning void > mfd: fsl-imx25-tsadc: Convert to platform remove callback returning > void > mfd: hi655x-pmic: Convert to platform remove callback returning void > mfd: intel-lpss-acpi: Convert to platform remove callback returning > void > mfd: kempld-core: Convert to platform remove callback returning void > mfd: mcp-sa11x0: Convert to platform remove callback returning void > mfd: mxs-lradc: Convert to platform remove callback returning void > mfd: omap-usb-host: Convert to platform remove callback returning void > mfd: omap-usb-tll: Convert to platform remove callback returning void > mfd: pcf50633-adc: Convert to platform remove callback returning void > mfd: qcom-pm8xxx: Convert to platform remove callback returning void > mfd: sm501: Convert to platform remove callback returning void > mfd: stm32-timers: Convert to platform remove callback returning void > mfd: ti_am335x_tscadc: Convert to platform remove callback returning > void > mfd: tps65911-comparator: Convert to platform remove callback > returning void > mfd: twl4030-audio: Convert to platform remove callback returning void Looks like you missed the mailing list on a bunch of these. I'm going to remove this set for now. Could you please resubmit it and Cc: LKML? > drivers/mfd/ab8500-sysctrl.c | 6 ++---- > drivers/mfd/cros_ec_dev.c | 5 ++--- > drivers/mfd/exynos-lpass.c | 6 ++---- > drivers/mfd/fsl-imx25-tsadc.c | 6 ++---- > drivers/mfd/hi655x-pmic.c | 5 ++--- > drivers/mfd/intel-lpss-acpi.c | 6 ++---- > drivers/mfd/kempld-core.c | 6 ++---- > drivers/mfd/mcp-sa11x0.c | 6 ++---- > drivers/mfd/mxs-lradc.c | 6 ++---- > drivers/mfd/omap-usb-host.c | 5 ++--- > drivers/mfd/omap-usb-tll.c | 5 ++--- > drivers/mfd/pcf50633-adc.c | 6 ++---- > drivers/mfd/qcom-pm8xxx.c | 6 ++---- > drivers/mfd/sm501.c | 6 ++---- > drivers/mfd/stm32-timers.c | 6 ++---- > drivers/mfd/ti_am335x_tscadc.c | 6 ++---- > drivers/mfd/tps65911-comparator.c | 6 ++---- > drivers/mfd/twl4030-audio.c | 6 ++---- > 18 files changed, 36 insertions(+), 68 deletions(-) > > base-commit: 3ff7a5781ceee3befb9224d29cef6e6a4766c5fe > -- > 2.42.0 > -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB2A4C61DF7 for ; Thu, 23 Nov 2023 14:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I9H8O0FevYSdiCHV/hHKpm4NHKafctnPZbJ2GpliUaA=; b=FolsMIpPnzHOCG f2y4LQTSjgnN/ozlWrSyK9c98gh44pYpgK6K8A44/qTwXicgoTPRxuHKNdm6+FWqDu2b3B3OTSy25 hzNGEvUQZncfdhcTPB9akTiXLrWgUaQY2/kGxzEg3AGN3EnhTzzHTE9uolRymrU8lJf7EgbZLdDSi 1Fdabj7LSo2gPdBuycY2yEbdhwWruZJVoCsS89xHjUbRpL54Z+a1V5gKt0BB6MxH8G0fR6o3wZnzY hCeKzKYurSJI1vStaIMzNn2MpbgxDlhXUcyxv27WwIAUUMGZlb7N4t3RKNGICv5b+StxoUkky3ANp 1w7jbrY5BrBePEHIIm/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6AdR-0050TA-2g; Thu, 23 Nov 2023 14:24:53 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6AdO-0050S0-2s for linux-arm-kernel@lists.infradead.org; Thu, 23 Nov 2023 14:24:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 4DEC7B82D01; Thu, 23 Nov 2023 14:24:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21DD5C433C8; Thu, 23 Nov 2023 14:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700749488; bh=qOdkWYm5UvV/HgiRSNx6MF2oGmugCohlm/2HC3o1mdI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VfSdJkXJvS+mtHT+AedviFCC5Fwt7buyviGMcgvclSiCLKck5taZwx6DN7+Vr8MhP bYybYMtsQZTERqVPVgMzznDeOf1dNbqGyLHKosiiJddBeeR+pcMCKhChs5saZodgtZ qyuOks1rpFxXU6apAiooZehcQudKVAwdNiPDZaWfLE22Q80auZXKk+Z5MWpQeEeLVd SVLaM9SA30kKgY3eDmsV2p9GzukXkgY/P/tyu7qwoaae1qytqDsCUX57l6Dwo3pBXd 87u7lO+IrutWC/ytZT/CL1hhgVXrrI+WvBUmrLKbuvHvqeL5lShciRRRquuZ8UrG+D SyqprgaqzmibQ== Date: Thu, 23 Nov 2023 14:24:41 +0000 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, Krzysztof Kozlowski , Alim Akhtar , linux-samsung-soc@vger.kernel.org, Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Tony Lindgren , linux-omap@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 00/18] mfd: Convert to platform remove callback returning void Message-ID: <20231123142441.GA1354538@google.com> References: <20231106171708.3892347-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231106171708.3892347-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_062451_223626_1367B946 X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwNiBOb3YgMjAyMywgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cgo+IEhlbGxvLAo+ IAo+IHRoaXMgc2VyaWVzIGNvbnZlcnRzIGFsbCBwbGF0Zm9ybSBkcml2ZXJzIGJlbG93IGRyaXZl cnMvbWZkIHRvIHVzZQo+IC5yZW1vdmVfbmV3KCkuIENvbXBhcmVkIHRvIHRoZSB0cmFkaXRpb25h bCAucmVtb3ZlKCkgY2FsbGJhY2sKPiAucmVtb3ZlX25ldygpIHJldHVybnMgbm8gdmFsdWUuIFRo aXMgaXMgYSBnb29kIHRoaW5nIGJlY2F1c2UgdGhlIGRyaXZlcgo+IGNvcmUgZG9lc24ndCAoYW5k IGNhbm5vdCkgY29wZSBmb3IgZXJyb3JzIGR1cmluZyByZW1vdmUuIFRoZSBvbmx5IGVmZmVjdAo+ IG9mIGEgbm9uLXplcm8gcmV0dXJuIHZhbHVlIGluIC5yZW1vdmUoKSBpcyB0aGF0IHRoZSBkcml2 ZXIgY29yZSBlbWl0cyBhCj4gd2FybmluZy4gVGhlIGRldmljZSBpcyByZW1vdmVkIGFueWhvdyBh bmQgYW4gZWFybHkgcmV0dXJuIGZyb20gLnJlbW92ZSgpCj4gdXN1YWxseSB5aWVsZHMgcmVzb3Vy Y2UgbGVha3MgYW5kL29yIHVzZS1hZnRlci1mcmVlIGJ1Z3MuCj4gCj4gU2VlIGNvbW1pdCA1YzVh NzY4MGU2N2IgKCJwbGF0Zm9ybTogUHJvdmlkZSBhIHJlbW92ZSBjYWxsYmFjayB0aGF0Cj4gcmV0 dXJucyBubyB2YWx1ZSIpIGZvciBhbiBleHRlbmRlZCBleHBsYW5hdGlvbiBhbmQgdGhlIGV2ZW50 dWFsIGdvYWwuCj4gCj4gQWxsIGRyaXZlcnMgY29udmVydGVkIGhlcmUgYWxyZWFkeSByZXR1cm5l ZCB6ZXJvIHVuY29uZGl0aW9uYWxseSBpbgo+IC5yZW1vdmUoKSwgc28gdGhleSBhcmUgY29udmVy dGVkIGhlcmUgdHJpdmlhbGx5Lgo+IAo+IEJlc3QgcmVnYXJkcwo+IFV3ZQo+IAo+IFV3ZSBLbGVp bmUtS8O2bmlnICgxOCk6Cj4gICBtZmQ6IGFiODUwMC1zeXNjdHJsOiBDb252ZXJ0IHRvIHBsYXRm b3JtIHJlbW92ZSBjYWxsYmFjayByZXR1cm5pbmcKPiAgICAgdm9pZAo+ICAgbWZkOiBjcm9zX2Vj X2RldjogQ29udmVydCB0byBwbGF0Zm9ybSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuaW5nIHZvaWQK PiAgIG1mZDogZXh5bm9zLWxwYXNzOiBDb252ZXJ0IHRvIHBsYXRmb3JtIHJlbW92ZSBjYWxsYmFj ayByZXR1cm5pbmcgdm9pZAo+ICAgbWZkOiBmc2wtaW14MjUtdHNhZGM6IENvbnZlcnQgdG8gcGxh dGZvcm0gcmVtb3ZlIGNhbGxiYWNrIHJldHVybmluZwo+ICAgICB2b2lkCj4gICBtZmQ6IGhpNjU1 eC1wbWljOiBDb252ZXJ0IHRvIHBsYXRmb3JtIHJlbW92ZSBjYWxsYmFjayByZXR1cm5pbmcgdm9p ZAo+ICAgbWZkOiBpbnRlbC1scHNzLWFjcGk6IENvbnZlcnQgdG8gcGxhdGZvcm0gcmVtb3ZlIGNh bGxiYWNrIHJldHVybmluZwo+ICAgICB2b2lkCj4gICBtZmQ6IGtlbXBsZC1jb3JlOiBDb252ZXJ0 IHRvIHBsYXRmb3JtIHJlbW92ZSBjYWxsYmFjayByZXR1cm5pbmcgdm9pZAo+ICAgbWZkOiBtY3At c2ExMXgwOiBDb252ZXJ0IHRvIHBsYXRmb3JtIHJlbW92ZSBjYWxsYmFjayByZXR1cm5pbmcgdm9p ZAo+ICAgbWZkOiBteHMtbHJhZGM6IENvbnZlcnQgdG8gcGxhdGZvcm0gcmVtb3ZlIGNhbGxiYWNr IHJldHVybmluZyB2b2lkCj4gICBtZmQ6IG9tYXAtdXNiLWhvc3Q6IENvbnZlcnQgdG8gcGxhdGZv cm0gcmVtb3ZlIGNhbGxiYWNrIHJldHVybmluZyB2b2lkCj4gICBtZmQ6IG9tYXAtdXNiLXRsbDog Q29udmVydCB0byBwbGF0Zm9ybSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuaW5nIHZvaWQKPiAgIG1m ZDogcGNmNTA2MzMtYWRjOiBDb252ZXJ0IHRvIHBsYXRmb3JtIHJlbW92ZSBjYWxsYmFjayByZXR1 cm5pbmcgdm9pZAo+ICAgbWZkOiBxY29tLXBtOHh4eDogQ29udmVydCB0byBwbGF0Zm9ybSByZW1v dmUgY2FsbGJhY2sgcmV0dXJuaW5nIHZvaWQKPiAgIG1mZDogc201MDE6IENvbnZlcnQgdG8gcGxh dGZvcm0gcmVtb3ZlIGNhbGxiYWNrIHJldHVybmluZyB2b2lkCj4gICBtZmQ6IHN0bTMyLXRpbWVy czogQ29udmVydCB0byBwbGF0Zm9ybSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuaW5nIHZvaWQKPiAg IG1mZDogdGlfYW0zMzV4X3RzY2FkYzogQ29udmVydCB0byBwbGF0Zm9ybSByZW1vdmUgY2FsbGJh Y2sgcmV0dXJuaW5nCj4gICAgIHZvaWQKPiAgIG1mZDogdHBzNjU5MTEtY29tcGFyYXRvcjogQ29u dmVydCB0byBwbGF0Zm9ybSByZW1vdmUgY2FsbGJhY2sKPiAgICAgcmV0dXJuaW5nIHZvaWQKPiAg IG1mZDogdHdsNDAzMC1hdWRpbzogQ29udmVydCB0byBwbGF0Zm9ybSByZW1vdmUgY2FsbGJhY2sg cmV0dXJuaW5nIHZvaWQKCkxvb2tzIGxpa2UgeW91IG1pc3NlZCB0aGUgbWFpbGluZyBsaXN0IG9u IGEgYnVuY2ggb2YgdGhlc2UuCgpJJ20gZ29pbmcgdG8gcmVtb3ZlIHRoaXMgc2V0IGZvciBub3cu CgpDb3VsZCB5b3UgcGxlYXNlIHJlc3VibWl0IGl0IGFuZCBDYzogTEtNTD8KCj4gIGRyaXZlcnMv bWZkL2FiODUwMC1zeXNjdHJsLmMgICAgICB8IDYgKystLS0tCj4gIGRyaXZlcnMvbWZkL2Nyb3Nf ZWNfZGV2LmMgICAgICAgICB8IDUgKystLS0KPiAgZHJpdmVycy9tZmQvZXh5bm9zLWxwYXNzLmMg ICAgICAgIHwgNiArKy0tLS0KPiAgZHJpdmVycy9tZmQvZnNsLWlteDI1LXRzYWRjLmMgICAgIHwg NiArKy0tLS0KPiAgZHJpdmVycy9tZmQvaGk2NTV4LXBtaWMuYyAgICAgICAgIHwgNSArKy0tLQo+ ICBkcml2ZXJzL21mZC9pbnRlbC1scHNzLWFjcGkuYyAgICAgfCA2ICsrLS0tLQo+ICBkcml2ZXJz L21mZC9rZW1wbGQtY29yZS5jICAgICAgICAgfCA2ICsrLS0tLQo+ICBkcml2ZXJzL21mZC9tY3At c2ExMXgwLmMgICAgICAgICAgfCA2ICsrLS0tLQo+ICBkcml2ZXJzL21mZC9teHMtbHJhZGMuYyAg ICAgICAgICAgfCA2ICsrLS0tLQo+ICBkcml2ZXJzL21mZC9vbWFwLXVzYi1ob3N0LmMgICAgICAg fCA1ICsrLS0tCj4gIGRyaXZlcnMvbWZkL29tYXAtdXNiLXRsbC5jICAgICAgICB8IDUgKystLS0K PiAgZHJpdmVycy9tZmQvcGNmNTA2MzMtYWRjLmMgICAgICAgIHwgNiArKy0tLS0KPiAgZHJpdmVy cy9tZmQvcWNvbS1wbTh4eHguYyAgICAgICAgIHwgNiArKy0tLS0KPiAgZHJpdmVycy9tZmQvc201 MDEuYyAgICAgICAgICAgICAgIHwgNiArKy0tLS0KPiAgZHJpdmVycy9tZmQvc3RtMzItdGltZXJz LmMgICAgICAgIHwgNiArKy0tLS0KPiAgZHJpdmVycy9tZmQvdGlfYW0zMzV4X3RzY2FkYy5jICAg IHwgNiArKy0tLS0KPiAgZHJpdmVycy9tZmQvdHBzNjU5MTEtY29tcGFyYXRvci5jIHwgNiArKy0t LS0KPiAgZHJpdmVycy9tZmQvdHdsNDAzMC1hdWRpby5jICAgICAgIHwgNiArKy0tLS0KPiAgMTgg ZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgNjggZGVsZXRpb25zKC0pCj4gCj4gYmFz ZS1jb21taXQ6IDNmZjdhNTc4MWNlZWUzYmVmYjkyMjRkMjljZWY2ZTZhNDc2NmM1ZmUKPiAtLSAK PiAyLjQyLjAKPiAKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK