From: Simon Horman <horms@kernel.org>
To: Suraj Jaiswal <quic_jsuraj@quicinc.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Prasad Sodagudi <psodagud@quicinc.com>,
Andrew Halaney <ahalaney@redhat.com>,
kernel@quicinc.com
Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Add driver support for DWMAC5 fault IRQ Support
Date: Thu, 23 Nov 2023 14:34:28 +0000 [thread overview]
Message-ID: <20231123143428.GH6339@kernel.org> (raw)
In-Reply-To: <62eaaace3713751cb1ecac3163e857737107ca0e.1700737841.git.quic_jsuraj@quicinc.com>
On Thu, Nov 23, 2023 at 05:08:15PM +0530, Suraj Jaiswal wrote:
> Add IRQ support to listen HW fault like ECC,DPP,FSM
> fault and print the fault information in the kernel
> log.
>
> Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com>
...
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 1ffde555da47..bae1704d5f4b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -690,9 +690,25 @@ devm_stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
> #endif /* CONFIG_OF */
> EXPORT_SYMBOL_GPL(devm_stmmac_probe_config_dt);
>
> +int stmmac_get_fault_intr_config(struct platform_device *pdev, struct stmmac_resources *res)
Hi Suraj,
stmmac_get_fault_intr_config() appears to only be used in this function.
If so it should be static.
Also, please consider limiting Networking code to 80 columns wide.
static int stmmac_get_fault_intr_config(struct platform_device *pdev,
struct stmmac_resources *res)
...
--
pw-bot: changes-requested
next prev parent reply other threads:[~2023-11-23 14:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 11:38 [PATCH net-next v3 0/3] Ethernet DWMAC5 fault IRQ support Suraj Jaiswal
2023-11-23 11:53 ` Suraj Jaiswal
2023-11-23 11:38 ` [PATCH net-next v3 1/3] dt-bindings: net: qcom,ethqos: add binding doc for fault IRQ for sa8775p Suraj Jaiswal
2023-11-23 11:53 ` Suraj Jaiswal
2023-11-23 11:44 ` Konrad Dybcio
2023-11-23 12:04 ` Suraj Jaiswal
2023-11-23 12:36 ` Rob Herring
2023-11-24 8:18 ` Krzysztof Kozlowski
2023-11-24 11:39 ` Suraj Jaiswal
2023-11-23 11:38 ` [PATCH net-next v3 2/3] arm64: dts: qcom: sa8775p: enable Fault IRQ Suraj Jaiswal
2023-11-23 11:53 ` Suraj Jaiswal
2023-11-24 8:19 ` Krzysztof Kozlowski
2023-11-24 8:20 ` Krzysztof Kozlowski
2023-11-24 15:23 ` kernel test robot
2023-11-23 11:38 ` [PATCH net-next v3 3/3] net: stmmac: Add driver support for DWMAC5 fault IRQ Support Suraj Jaiswal
2023-11-23 11:53 ` Suraj Jaiswal
2023-11-23 11:55 ` Konrad Dybcio
2023-11-23 14:34 ` Simon Horman [this message]
2023-11-23 20:02 ` Andrew Lunn
2023-11-24 13:19 ` kernel test robot
2023-11-24 14:39 ` kernel test robot
2023-11-27 20:08 ` Andrew Halaney
2023-11-23 11:57 ` [PATCH net-next v3 0/3] Ethernet DWMAC5 fault IRQ support Konrad Dybcio
2023-11-23 11:57 ` Konrad Dybcio
2023-11-23 19:54 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123143428.GH6339@kernel.org \
--to=horms@kernel.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=psodagud@quicinc.com \
--cc=quic_jsuraj@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.