From: Bjorn Helgaas <helgaas@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Will Deacon" <will@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh@kernel.org>,
kernel@pengutronix.de, linux-pci@vger.kernel.org, lkp@intel.com
Subject: Re: [PATCH] PCI: host-generic: Convert to platform remove callback returning void
Date: Thu, 23 Nov 2023 21:25:35 -0600 [thread overview]
Message-ID: <20231124032535.GA351419@bhelgaas> (raw)
In-Reply-To: <20231123171236.tksz4lhpj5jbwfxm@pengutronix.de>
[+to lkp]
On Thu, Nov 23, 2023 at 06:12:36PM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 20, 2023 at 03:56:18PM -0600, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> > On Fri, 20 Oct 2023 11:21:07 +0200, Uwe Kleine-König wrote:
> > > The .remove() callback for a platform driver returns an int which makes
> > > many driver authors wrongly assume it's possible to do error handling by
> > > returning an error code. However the value returned is (mostly) ignored
> > > and this typically results in resource leaks. To improve here there is a
> > > quest to make the remove callback return void. In the first step of this
> > > quest all drivers are converted to .remove_new() which already returns
> > > void.
> > >
> > > [...]
> >
> > Applied to "enumeration" for v6.8, thanks!
> >
> > [1/1] PCI: host-generic: Convert to platform remove callback returning void
> > commit: d9dcdb4531fe39ce48919ef8c2c9369ee49f3ad2
>
> Thanks! This branch isn't included in next. Is this on purpose?
To reduce the workload of the folks maintaining "next", I wait for the
0-day bot to build test a branch before merging it into the PCI "next"
branch.
That usually takes a couple days after I push a branch to the
kernel.org repo. I have these branches that are currently waiting to
be put into next:
ecam pushed 11/20 bot response 11/22
resource pushed 11/20 no bot response yet
enumeration pushed 11/20 no bot response yet
p2pdma pushed 11/20 no bot response yet
switchtec pushed 11/22 no bot response yet
Not sure if the 0-day bot is slower than usual right now, but I cc'd
the LKP folks in case something is wrong.
Bjorn
next prev parent reply other threads:[~2023-11-24 3:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 9:21 [PATCH] PCI: host-generic: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-23 17:29 ` Will Deacon
2023-11-20 21:22 ` Uwe Kleine-König
2023-11-20 21:30 ` Bjorn Helgaas
2023-11-20 21:46 ` Uwe Kleine-König
2023-11-20 21:56 ` Bjorn Helgaas
2023-11-23 17:12 ` Uwe Kleine-König
2023-11-24 3:25 ` Bjorn Helgaas [this message]
2023-11-24 4:16 ` Philip Li
2023-11-24 7:07 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124032535.GA351419@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.