From: Petr Vorel <pvorel@suse.cz>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>
Subject: Re: [PATCH 1/2] kbuild: builddeb: Remove unused $dirs
Date: Fri, 24 Nov 2023 17:28:58 +0100 [thread overview]
Message-ID: <20231124162858.GA177418@pevik> (raw)
In-Reply-To: <CAK7LNARo3FKQM1esdzk60TRPn1joVZ2SRVCcuUJ+r9DEPzLtfw@mail.gmail.com>
Hi Masahiro,
> On Tue, Nov 21, 2023 at 10:37 PM Petr Vorel <pvorel@suse.cz> wrote:
> > Hi,
> > I could have added some description, e.g. "shell variable $dirs is not used any
> > more since 1fc9095846cc, therefore remove it".
> > Please let me know if I should resent it as v2.
> > Kind regards,
> > Petr
> > > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package")
> > > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> I filled the commit log and fixed the commit subject
> "kbuild: builddeb:" to "kbuild: buildtar:".
Thanks for fixing this!
Kind regards,
Petr
> Author: Petr Vorel <pvorel@suse.cz>
> Date: Tue Nov 21 12:58:54 2023 +0100
> kbuild: buildtar: Remove unused $dirs
> The shell variable $dirs is not used any more since 1fc9095846cc
> ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package"),
> therefore remove it".
> Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in
> scripts/Makefile.package")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> Thanks.
> > > ---
> > > scripts/package/buildtar | 2 --
> > > 1 file changed, 2 deletions(-)
> > > diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> > > index 65b4ea502962..8ac075dd0e9c 100755
> > > --- a/scripts/package/buildtar
> > > +++ b/scripts/package/buildtar
> > > @@ -23,7 +23,6 @@ tmpdir=$1
> > > rm -rf -- "${tmpdir}"
> > > mkdir -p -- "${tmpdir}/boot"
> > > -dirs=boot
> > > @@ -42,7 +41,6 @@ fi
> > > if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then
> > > make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
> > > - dirs="$dirs lib"
> > > fi
prev parent reply other threads:[~2023-11-24 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 11:58 [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
2023-11-21 11:58 ` [PATCH 2/2] kbuild: buildtar: always make modules_install Petr Vorel
2023-11-24 13:54 ` Masahiro Yamada
2023-11-21 13:37 ` [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
2023-11-24 9:33 ` Masahiro Yamada
2023-11-24 16:28 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124162858.GA177418@pevik \
--to=pvorel@suse.cz \
--cc=josh@joshtriplett.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.