Re: [RFC PATCH 2/3] drivers: fpga: Add user-key encrypted FPGA Image loading support

[kernel test robot <lkp@intel.com>]

Hi Nava,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.7-rc2 next-20231124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nava-kishore-Manne/drivers-fpga-Add-user-key-encrypted-FPGA-Image-loading-support/20231122-151844
base:   linus/master
patch link:    https://lore.kernel.org/r/20231122054404.3764288-3-nava.kishore.manne%40amd.com
patch subject: [RFC PATCH 2/3] drivers: fpga: Add user-key encrypted FPGA Image loading support
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231124/202311241635.UbGsWTG6-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231124/202311241635.UbGsWTG6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311241635.UbGsWTG6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/fpga/fpga-mgr.c:588: warning: Function parameter or member 'fw' not described in 'fpga_mgr_get_aes_key'


vim +588 drivers/fpga/fpga-mgr.c

   570	
   571	/**
   572	 * fpga_mgr_get_aes_key - request aes key form the firmware class
   573	 * @mgr:        fpga manager
   574	 * @info:       fpga image specific information
   575	 * @image_name: name of image file on the aes key firmware search path
   576	 *
   577	 *
   578	 * Request an aes key image using the firmware class, then Step the low level
   579	 * fpga manager through the device-specific steps. Update the state before each
   580	 * step to provide info on what step failed if there is a failure.
   581	 *
   582	 * Return: 0 on success, negative error code otherwise.
   583	 */
   584	static int fpga_mgr_get_aes_key(struct fpga_manager *mgr,
   585					struct fpga_image_info *info,
   586					const char *image_name,
   587					const struct firmware *fw)
 > 588	{
   589		struct device *dev = &mgr->dev;
   590		int ret;
   591	
   592		dev_info(dev, "Get Aes-key: %s to %s\n", image_name, mgr->name);
   593	
   594		mgr->state = FPGA_MGR_STATE_FIRMWARE_REQ;
   595	
   596		ret = request_firmware(&fw, image_name, dev);
   597		if (ret) {
   598			mgr->state = FPGA_MGR_STATE_FIRMWARE_REQ_ERR;
   599			dev_err(dev, "Error requesting firmware %s\n", image_name);
   600			return ret;
   601		}
   602	
   603		ret = fpga_mgr_parse_aes_key(mgr, info, fw->data, fw->size);
   604	
   605		return ret;
   606	}
   607	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki