From: Simon Horman <horms@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next 6/8] tcp: Move TCP-AO bits from cookie_v[46]_check() to tcp_ao_syncookie().
Date: Fri, 24 Nov 2023 21:46:01 +0000 [thread overview]
Message-ID: <20231124214601.GD50352@kernel.org> (raw)
In-Reply-To: <20231123012521.62841-7-kuniyu@amazon.com>
On Wed, Nov 22, 2023 at 05:25:19PM -0800, Kuniyuki Iwashima wrote:
> We initialise treq->af_specific in cookie_tcp_reqsk_alloc() so that
> we can look up a key later in tcp_create_openreq_child().
>
> Initially, that change was added for MD5 by commit ba5a4fdd63ae ("tcp:
> make sure treq->af_specific is initialized"), but it has not been used
> since commit d0f2b7a9ca0a ("tcp: Disable header prediction for MD5
> flow.").
>
> Now, treq->af_specific is used only by TCP-AO, so, we can move that
> initialisation into tcp_ao_syncookie().
>
> In addition to that, l3index in cookie_v[46]_check() is only used for
> tcp_ao_syncookie(), so let's move it as well.
>
> While at it, we move down tcp_ao_syncookie() in cookie_v4_check() so
> that it will be called after security_inet_conn_request() to make
> functions order consistent with cookie_v6_check().
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-11-24 21:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 1:25 [PATCH v1 net-next 0/8] tcp: Clean up and refactor cookie_v[46]_check() Kuniyuki Iwashima
2023-11-23 1:25 ` [PATCH v1 net-next 1/8] tcp: Clean up reverse xmas tree in cookie_v[46]_check() Kuniyuki Iwashima
2023-11-24 21:44 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 2/8] tcp: Cache sock_net(sk) " Kuniyuki Iwashima
2023-11-24 21:44 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 3/8] tcp: Clean up goto labels " Kuniyuki Iwashima
2023-11-24 21:45 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 4/8] tcp: Don't pass cookie to __cookie_v[46]_check() Kuniyuki Iwashima
2023-11-24 21:45 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 5/8] tcp: Don't initialise tp->tsoffset in tcp_get_cookie_sock() Kuniyuki Iwashima
2023-11-24 21:45 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 6/8] tcp: Move TCP-AO bits from cookie_v[46]_check() to tcp_ao_syncookie() Kuniyuki Iwashima
2023-11-24 21:46 ` Simon Horman [this message]
2023-11-23 1:25 ` [PATCH v1 net-next 7/8] tcp: Factorise cookie-independent fields initialisation in cookie_v[46]_check() Kuniyuki Iwashima
2023-11-24 21:44 ` Simon Horman
2023-11-25 1:04 ` Kuniyuki Iwashima
2023-11-23 1:25 ` [PATCH v1 net-next 8/8] tcp: Factorise cookie-dependent " Kuniyuki Iwashima
2023-11-24 21:46 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124214601.GD50352@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.