From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>,
James Autry <jautry@tekvox.com>, Jim Reinhart <jimr@tekvox.com>,
Matthew Maron <matthewm@tekvox.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/swupdate: workaround runtime update failure
Date: Fri, 24 Nov 2023 22:59:23 +0100 [thread overview]
Message-ID: <20231124225923.59d08949@windsurf> (raw)
In-Reply-To: <20231123173957.2385041-1-giulio.benetti@benettiengineering.com>
On Thu, 23 Nov 2023 18:39:57 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> +SWUPDATE_CFLAGS = $(TARGET_CFLAGS)
> +
> +# Workaround update failure showing up with -Os
> +# Reported here:
> +# https://groups.google.com/g/swupdate/c/oHMihNw8ZHA
> +ifeq ($(BR2_OPTIMIZE_S),y)
> +SWUPDATE_CFLAGS += -O3
> +endif
This looks really horrible to me. Is there a compiler bug? Or a bug in
the swupdate code base, such as some undefined behavior that causes an
incorrect behavior when built -Os, but not -O3 ?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-24 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 17:39 [Buildroot] [PATCH] package/swupdate: workaround runtime update failure Giulio Benetti
2023-11-24 21:59 ` Thomas Petazzoni via buildroot [this message]
2023-11-25 0:24 ` Giulio Benetti
2023-11-29 21:38 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124225923.59d08949@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti+tekvox@benettiengineering.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=jautry@tekvox.com \
--cc=jimr@tekvox.com \
--cc=matthewm@tekvox.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.