From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECB57C4167B for ; Sat, 25 Nov 2023 20:51:35 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8071B83A; Sat, 25 Nov 2023 21:51:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8071B83A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1700945493; bh=MP615DG3faCXFei6ez6/qbJ2Qn+AxlK3zXjwrEKNgcs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=JyXcaWg8DmW0/edR5I+V5bIVl8B4rOHVjcyNa++9qeCi+r/3HR66oq0r1DaVTYndR cUm2Yo5kTDKmtLSI3Ehms3pipnChgV/IHC8FSynYtTNWdzGIjp2WWCKnUO78SPjUEg aJ2KjXqKX6X+4RaWZ0ttWrbDBh5Cszgc6TuxjD4c= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 96BB2F8055C; Sat, 25 Nov 2023 21:51:01 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3A035F80549; Sat, 25 Nov 2023 21:51:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29BE1F802E8; Sat, 25 Nov 2023 21:48:50 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A51EBF80249 for ; Sat, 25 Nov 2023 21:48:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A51EBF80249 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=V3H6UDq7 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 87E12B83459; Sat, 25 Nov 2023 20:48:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 487CBC433C8; Sat, 25 Nov 2023 20:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700945313; bh=MP615DG3faCXFei6ez6/qbJ2Qn+AxlK3zXjwrEKNgcs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V3H6UDq7A3kCMLfHpZpSX7FXfzHuWMOtsplTH0sNtXsZgArz+P0U4eBCtxi3NSFFd /Qh78hVGqFA0WqXtaEMTLiv8fodY0nCNwQemnzy2nkPIc8A948DHrbP8ShAHXs9JEh DZSd65o2b/ffSmFfCaSmhQJlMgtpbBWoxv52RCHkCAWexYJeYwHrGLN9suMTTHOnuk DdSGqivh1nxdaSurglxzzB29rEdm+mzoC6D5xHsCr4gfSyRMDlvOZaKdKmw5u63wzf fjwHu1uh7qGvuEyyEExZqT+BueoGfafWluF3pHxDvInU7XHZpnYl45oF6XMQNbYQcP bHLD2kxsjKD7g== Date: Sat, 25 Nov 2023 20:48:14 +0000 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC Message-ID: <20231125204814.10fe16fa@jic23-huawei> In-Reply-To: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: T2CN3JROQYHXRWPS2ULGKARV2QGRCVPK X-Message-ID-Hash: T2CN3JROQYHXRWPS2ULGKARV2QGRCVPK X-MailFrom: jic23@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 8 Nov 2023 11:43:36 +0100 Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Jonathan Cameron > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 582d0a03b814..4e40f6bed5db 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -11,18 +11,23 @@ maintainers: > > properties: > compatible: > - enum: > - - samsung,exynos-adc-v1 # Exynos5250 > - - samsung,exynos-adc-v2 > - - samsung,exynos3250-adc > - - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > - - samsung,exynos7-adc > - - samsung,s3c2410-adc > - - samsung,s3c2416-adc > - - samsung,s3c2440-adc > - - samsung,s3c2443-adc > - - samsung,s3c6410-adc > - - samsung,s5pv210-adc > + oneOf: > + - enum: > + - samsung,exynos-adc-v1 # Exynos5250 > + - samsung,exynos-adc-v2 > + - samsung,exynos3250-adc > + - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > + - samsung,exynos7-adc > + - samsung,s3c2410-adc > + - samsung,s3c2416-adc > + - samsung,s3c2440-adc > + - samsung,s3c2443-adc > + - samsung,s3c6410-adc > + - samsung,s5pv210-adc > + - items: > + - enum: > + - samsung,exynos5433-adc > + - const: samsung,exynos7-adc > > reg: > maxItems: 1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C8ACC4167B for ; Sat, 25 Nov 2023 20:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R2T7sFfr4P8t2jEqfl1qarOrEq0kgqdiNBKfcYoIOHk=; b=LCcAeBVx1j7XvW gixLsnQWDUUw60MoEECYInIKlQqOLsJ0Z4BVx7dczw5jXHcMI05YdU3wdlPFfHSZ/33mbmAHf2fHp cpJK/mUAwJLwTRkTyNafkFSEbF/0vga9smzGSgYghydAGx2sHiIVagjPFhiZvtgap7bG2XVBW1tVY QyN65RhMbxfRhA+Ee/2m7GafLJHuWrDaC3peyt0Ax+/po+PI52xA8ift86WnR/6NhCXSYPk2O6+ui Z9MnDXAH/gtT1I997wH4juX9l30e2nAsN32ogtybyTGhSvVlUyXDwICOVNlPryhWRwQIchCy3UAHM hw7hMARtsDqwKf7+AbLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6zZz-009nhB-06; Sat, 25 Nov 2023 20:48:43 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6zZv-009nfu-0C for linux-arm-kernel@lists.infradead.org; Sat, 25 Nov 2023 20:48:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 87E12B83459; Sat, 25 Nov 2023 20:48:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 487CBC433C8; Sat, 25 Nov 2023 20:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700945313; bh=MP615DG3faCXFei6ez6/qbJ2Qn+AxlK3zXjwrEKNgcs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V3H6UDq7A3kCMLfHpZpSX7FXfzHuWMOtsplTH0sNtXsZgArz+P0U4eBCtxi3NSFFd /Qh78hVGqFA0WqXtaEMTLiv8fodY0nCNwQemnzy2nkPIc8A948DHrbP8ShAHXs9JEh DZSd65o2b/ffSmFfCaSmhQJlMgtpbBWoxv52RCHkCAWexYJeYwHrGLN9suMTTHOnuk DdSGqivh1nxdaSurglxzzB29rEdm+mzoC6D5xHsCr4gfSyRMDlvOZaKdKmw5u63wzf fjwHu1uh7qGvuEyyEExZqT+BueoGfafWluF3pHxDvInU7XHZpnYl45oF6XMQNbYQcP bHLD2kxsjKD7g== Date: Sat, 25 Nov 2023 20:48:14 +0000 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC Message-ID: <20231125204814.10fe16fa@jic23-huawei> In-Reply-To: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231125_124839_398689_0C1ED9A4 X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 8 Nov 2023 11:43:36 +0100 Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Jonathan Cameron > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 582d0a03b814..4e40f6bed5db 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -11,18 +11,23 @@ maintainers: > > properties: > compatible: > - enum: > - - samsung,exynos-adc-v1 # Exynos5250 > - - samsung,exynos-adc-v2 > - - samsung,exynos3250-adc > - - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > - - samsung,exynos7-adc > - - samsung,s3c2410-adc > - - samsung,s3c2416-adc > - - samsung,s3c2440-adc > - - samsung,s3c2443-adc > - - samsung,s3c6410-adc > - - samsung,s5pv210-adc > + oneOf: > + - enum: > + - samsung,exynos-adc-v1 # Exynos5250 > + - samsung,exynos-adc-v2 > + - samsung,exynos3250-adc > + - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > + - samsung,exynos7-adc > + - samsung,s3c2410-adc > + - samsung,s3c2416-adc > + - samsung,s3c2440-adc > + - samsung,s3c2443-adc > + - samsung,s3c6410-adc > + - samsung,s5pv210-adc > + - items: > + - enum: > + - samsung,exynos5433-adc > + - const: samsung,exynos7-adc > > reg: > maxItems: 1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8FF1C4167B for ; Sat, 25 Nov 2023 20:48:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21EE910E042; Sat, 25 Nov 2023 20:48:40 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4AEAC10E042 for ; Sat, 25 Nov 2023 20:48:37 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 87E12B83459; Sat, 25 Nov 2023 20:48:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 487CBC433C8; Sat, 25 Nov 2023 20:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700945313; bh=MP615DG3faCXFei6ez6/qbJ2Qn+AxlK3zXjwrEKNgcs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V3H6UDq7A3kCMLfHpZpSX7FXfzHuWMOtsplTH0sNtXsZgArz+P0U4eBCtxi3NSFFd /Qh78hVGqFA0WqXtaEMTLiv8fodY0nCNwQemnzy2nkPIc8A948DHrbP8ShAHXs9JEh DZSd65o2b/ffSmFfCaSmhQJlMgtpbBWoxv52RCHkCAWexYJeYwHrGLN9suMTTHOnuk DdSGqivh1nxdaSurglxzzB29rEdm+mzoC6D5xHsCr4gfSyRMDlvOZaKdKmw5u63wzf fjwHu1uh7qGvuEyyEExZqT+BueoGfafWluF3pHxDvInU7XHZpnYl45oF6XMQNbYQcP bHLD2kxsjKD7g== Date: Sat, 25 Nov 2023 20:48:14 +0000 From: Jonathan Cameron To: Krzysztof Kozlowski Subject: Re: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC Message-ID: <20231125204814.10fe16fa@jic23-huawei> In-Reply-To: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Alim Akhtar , Alexandre Belloni , linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, Tomasz Figa , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-i2c@vger.kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Jiri Slaby , Andi Shyti , linux-rtc@vger.kernel.org, Lee Jones , Jaehoon Chung , linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , devicetree@vger.kernel.org, Conor Dooley , alsa-devel@alsa-project.org, Maxime Ripard , linux-gpio@vger.kernel.org, Rob Herring , linux-sound@vger.kernel.org, Sam Protsenko , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Liam Girdwood , Mark Brown , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 8 Nov 2023 11:43:36 +0100 Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Jonathan Cameron > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 582d0a03b814..4e40f6bed5db 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -11,18 +11,23 @@ maintainers: > > properties: > compatible: > - enum: > - - samsung,exynos-adc-v1 # Exynos5250 > - - samsung,exynos-adc-v2 > - - samsung,exynos3250-adc > - - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > - - samsung,exynos7-adc > - - samsung,s3c2410-adc > - - samsung,s3c2416-adc > - - samsung,s3c2440-adc > - - samsung,s3c2443-adc > - - samsung,s3c6410-adc > - - samsung,s5pv210-adc > + oneOf: > + - enum: > + - samsung,exynos-adc-v1 # Exynos5250 > + - samsung,exynos-adc-v2 > + - samsung,exynos3250-adc > + - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > + - samsung,exynos7-adc > + - samsung,s3c2410-adc > + - samsung,s3c2416-adc > + - samsung,s3c2440-adc > + - samsung,s3c2443-adc > + - samsung,s3c6410-adc > + - samsung,s5pv210-adc > + - items: > + - enum: > + - samsung,exynos5433-adc > + - const: samsung,exynos7-adc > > reg: > maxItems: 1