Re: [RFC][PATCH] simpler way to get benefits of "vfs: shave work on failed file open"

[kernel test robot <lkp@intel.com>]

Hi Al,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v6.7-rc2 next-20231124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Al-Viro/simpler-way-to-get-benefits-of-vfs-shave-work-on-failed-file-open/20231126-101216
base:   linux/master
patch link:    https://lore.kernel.org/r/20231126020834.GC38156%40ZenIV
patch subject: [RFC][PATCH] simpler way to get benefits of "vfs: shave work on failed file open"
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20231126/202311261322.8ip3vqTD-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231126/202311261322.8ip3vqTD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311261322.8ip3vqTD-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/array_size.h:5,
                    from include/linux/string.h:5,
                    from fs/file_table.c:9:
   fs/file_table.c: In function 'fput':
>> fs/file_table.c:436:32: error: 'f' undeclared (first use in this function); did you mean 'fd'?
     436 |                 if (unlikely(!(f->f_mode & (FMODE_BACKING | FMODE_OPENED)))) {
         |                                ^
   include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   fs/file_table.c:436:32: note: each undeclared identifier is reported only once for each function it appears in
     436 |                 if (unlikely(!(f->f_mode & (FMODE_BACKING | FMODE_OPENED)))) {
         |                                ^
   include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^


vim +436 fs/file_table.c

   430	
   431	void fput(struct file *file)
   432	{
   433		if (atomic_long_dec_and_test(&file->f_count)) {
   434			struct task_struct *task = current;
   435	
 > 436			if (unlikely(!(f->f_mode & (FMODE_BACKING | FMODE_OPENED)))) {
   437				file_free(f);
   438				return;
   439			}
   440			if (likely(!in_interrupt() && !(task->flags & PF_KTHREAD))) {
   441				init_task_work(&file->f_rcuhead, ____fput);
   442				if (!task_work_add(task, &file->f_rcuhead, TWA_RESUME))
   443					return;
   444				/*
   445				 * After this task has run exit_task_work(),
   446				 * task_work_add() will fail.  Fall through to delayed
   447				 * fput to avoid leaking *file.
   448				 */
   449			}
   450	
   451			if (llist_add(&file->f_llist, &delayed_fput_list))
   452				schedule_delayed_work(&delayed_fput_work, 1);
   453		}
   454	}
   455	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki