All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: [ti:ti-linux-6.1.y-wip 13/22] drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y
Date: Sun, 26 Nov 2023 21:22:19 +0800	[thread overview]
Message-ID: <202311262053.57NKWxyU-lkp@intel.com> (raw)

:::::: 
:::::: Manual check reason: "low confidence static check warning: drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: vigneshr@ti.com
CC: nm@ti.com
CC: Praneeth Bajjuri <praneeth@ti.com>

tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-6.1.y-wip
head:   07cbd0efc06ffff69b2b0c3d7d607b35829340c3
commit: a82817238831b72570a3135027ba3bc52becabb7 [13/22] can: m_can: Map WoL to device_set_wakeup_enable
:::::: branch date: 2 days ago
:::::: commit date: 10 days ago
config: mips-randconfig-r121-20231126 (https://download.01.org/0day-ci/archive/20231126/202311262053.57NKWxyU-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231126/202311262053.57NKWxyU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202311262053.57NKWxyU-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y
   drivers/net/can/m_can/m_can.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
   include/linux/page-flags.h:248:46: sparse: sparse: self-comparison always evaluates to false

vim +1890 drivers/net/can/m_can/m_can.c

a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1882  
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1883  static int m_can_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1884  {
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1885  	struct m_can_classdev *cdev = netdev_priv(dev);
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1886  
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1887  	if ((wol->wolopts & WAKE_PHY) != wol->wolopts)
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1888  		return -EINVAL;
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1889  
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 @1890  	device_set_wakeup_enable(cdev->dev, !!wol->wolopts & WAKE_PHY);
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1891  
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1892  	return 0;
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1893  }
a82817238831b7 Markus Schneider-Pargmann 2023-11-16  1894  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2023-11-26 13:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-26 13:22 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-12-14 17:46 [ti:ti-linux-6.1.y-wip 13/22] drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311262053.57NKWxyU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.