Re: [PATCH 0/2] watchdog/hpwdt: Cleanup Claiming NMI

[Jerry Hoemann <jerry.hoemann@hpe.com>]

On Wed, Nov 08, 2023 at 07:44:05PM -0700, Jerry Hoemann wrote:
> In addition to being a watchdog, hpwdt participates in error
> containmnet on ProLiant systems.
> 
> On legacy platforms (Gen 8/Gen 9 and earlier) Fatal IO errors would be
> signaled as an IO CHECK NMI with expectation that hpwdt would be present
> to receive the NMI and crash the systems thus containing the error.
> 
> A problem was that hwpdt did not discriminate enough in accepting NMIs.
> This could lead to problems if an NMI generated for another subsystems
> was not claimed by that subsystem and became UNKNOWN and was claimed
> by hpwdt.  Application profiling was such an example.  While, profiling
> issue was fixed, hpwdt should avoid claiming NMI not intended for it.
> 
> In iLO 5 time frame, checks were added to make hpwdt more selective
> in claiming NMI.  This patchset cleans up the checks and enables it
> for future versions of iLO.
> 

Hi Guenter,

Was there a problem with this patch set?

Thanks

Jerry


> 
> Jerry Hoemann (2):
>   watchdog/hpwdt: Only claim UNKNOWN NMI if from iLO
>   watchdog/hpwdt: Remove checks on ilo5
> 
>  drivers/watchdog/hpwdt.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> -- 
> 2.41.0

-- 

-----------------------------------------------------------------------------
Jerry Hoemann                  Software Engineer   Hewlett Packard Enterprise
-----------------------------------------------------------------------------