Re: [virtio-comment] Re: [PATCH v6 2/5] virtio-net: Add flow filter capabilities read commands

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Nov 27, 2023 at 10:19:45AM +0000, Parav Pandit wrote:
> > 
> > > The bright line in based on this usage: bootstap or not.
> > > If its runtime, sure have it over CVQ.
> > > Following the nice tenet of B.2 of the spec snippet: "Device configuration
> > space should only be used for initialization-time parameters"
> > > That’s it.
> > > And everyone is already aligned to it.
> > 
> > Absolutely. Specifically, when do you expect driver to probe these caps? As
> > you yourself explained, it has to do it before ethtool calls - that clearly means it
> > will do it in probe.
> > To me this simply screams "initialization time".
> > 
> It can be done in driver probe routine after DRIVER_OK, this is fine.

No - it is preferable to do it before DRIVER_OK because
VQs are probed and initialized before DRIVER_OK.
For example, it is reasonable to decide to only enable MQ
if specific flow control can later be enabled.

-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/