From: Jakub Kicinski <kuba@kernel.org>
To: Li RongQing <lirongqing@baidu.com>
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
wintera@linux.ibm.com, dust.li@linux.alibaba.com
Subject: Re: [PATCH net-next v4] net/smc: remove unneeded atomic operations in smc_tx_sndbuf_nonempty
Date: Mon, 27 Nov 2023 17:57:00 -0800 [thread overview]
Message-ID: <20231127175700.06a2234d@kernel.org> (raw)
In-Reply-To: <20231123014537.9786-1-lirongqing@baidu.com>
On Thu, 23 Nov 2023 09:45:37 +0800 Li RongQing wrote:
> The commit dcd2cf5f2fc0 ("net/smc: add autocorking support") adds an
> atomic variable tx_pushing in smc_connection to make sure only one can
> send to let it cork more and save CDC slot. since smc_tx_pending can be
> called in the soft IRQ without checking sock_owned_by_user() at that
> time, which would cause a race condition because bh_lock_sock() did
> not honor sock_lock()
Looks like this was applied by DaveM - commit e7bed88e0530 ("net/smc:
remove unneeded atomic operations in smc_tx_sndbuf_nonempty") in net-next.
Thank you!
--
pw-bot: accept
prev parent reply other threads:[~2023-11-28 1:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 1:45 [PATCH net-next v4] net/smc: remove unneeded atomic operations in smc_tx_sndbuf_nonempty Li RongQing
2023-11-24 12:16 ` Alexandra Winter
2023-11-24 12:55 ` Wenjia Zhang
2023-11-28 1:57 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127175700.06a2234d@kernel.org \
--to=kuba@kernel.org \
--cc=dust.li@linux.alibaba.com \
--cc=linux-s390@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.