All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [jgunthorpe:iommu_fwspec 39/42] drivers/iommu/arm/arm-smmu/arm-smmu.c:1314:9: error: expected ';' after expression
Date: Mon, 27 Nov 2023 23:21:09 +0800	[thread overview]
Message-ID: <202311272010.Z2CAtEHL-lkp@intel.com> (raw)

tree:   https://github.com/jgunthorpe/linux iommu_fwspec
head:   9624604aaaa41adf3cb018da14da2744b69a5eee
commit: 6b52c2ea5f140f23a5fa75f1fe32b595d170c27f [39/42] iommu/arm-smmu: Move to iommu_of_xlate()
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231127/202311272010.Z2CAtEHL-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231127/202311272010.Z2CAtEHL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311272010.Z2CAtEHL-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/iommu/arm/arm-smmu/arm-smmu.c:1314:9: error: expected ';' after expression
           smmu = iommu_iort_get_single_iommu(pinf, &arm_smmu_ops, &flags,
                  ^
   include/linux/iommu-driver.h:242:2: note: expanded from macro 'iommu_iort_get_single_iommu'
           })
           ^
   1 error generated.


vim +1314 drivers/iommu/arm/arm-smmu/arm-smmu.c

  1306	
  1307	static struct arm_smmu_master_cfg *
  1308	arm_smmu_probe_new_master(struct iommu_probe_info *pinf)
  1309	{
  1310		struct arm_smmu_master_cfg *cfg;
  1311		struct arm_smmu_device *smmu;
  1312		unsigned int flags;
  1313	
> 1314		smmu = iommu_iort_get_single_iommu(pinf, &arm_smmu_ops, &flags,
  1315						   struct arm_smmu_device, iommu);
  1316		if (IS_ERR(smmu))
  1317			return ERR_CAST(smmu);
  1318	
  1319		if (!pinf->of_master_np) {
  1320			/* In ACPI mode the smmu uses the usual u32 format */
  1321			cfg = iommu_fw_alloc_per_device_ids(pinf, cfg);
  1322			if (IS_ERR(cfg))
  1323				return cfg;
  1324			cfg->acpi_fwnode = iommu_fw_acpi_fwnode(pinf);
  1325		} else {
  1326			unsigned int num_ids;
  1327			int ret;
  1328	
  1329			/*
  1330			 * In OF mode it supports several different formats for the arg,
  1331			 * pass through arm_smmu_of_xlate to extract it.
  1332			 */
  1333			num_ids = iommu_of_num_ids(pinf);
  1334			cfg = kzalloc(struct_size(cfg, ids, num_ids), GFP_KERNEL);
  1335			if (!cfg)
  1336				return ERR_PTR(-ENOMEM);
  1337	
  1338			ret = iommu_of_xlate(pinf, &arm_smmu_ops, -1,
  1339					     &arm_smmu_of_xlate, cfg);
  1340			if (ret) {
  1341				kfree(cfg);
  1342				return ERR_PTR(ret);
  1343			}
  1344		}
  1345	
  1346		cfg->smmu = smmu;
  1347		return cfg;
  1348	}
  1349	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-11-27 15:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311272010.Z2CAtEHL-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jgg@nvidia.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.