From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B470BC4167B for ; Mon, 27 Nov 2023 21:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zlWw8QK7Z5HcY1p8j6gEzJDR5J/Bemp7EhD5maxhYuM=; b=HYyql/ed8SMpuY 0f0cZr7TG0OgLjDTfTtNqEL1bwhH+Z1bQIX8YVzjFtYWmDezX9k7O0Nk7yIlsA11oVf3++ZjphZib BawImQn5ZpD4dehDLxiTvh02NsAGajG0+5ijaO9dEL4BGBEnopOx0H7NCSpNziZkF5m1Pq7ydw3n6 htgH8XwLPNH/XqZBYYqNDJwZRjRj09sWVwmpLSp76+hAS4004jyOVN3Rv3olUisH4emKxSE5zPkb1 DhyC0r+BovGcn4z5uKLchmC1R5lkIStDF6LF/ObCkjHBwad0mUQaSk6jxx0M3BRwSljuflV6z28Ru Z81cx0HhCYy8hE7OIPTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7jaF-003Xl1-37; Mon, 27 Nov 2023 21:56:04 +0000 Received: from mail-oa1-f43.google.com ([209.85.160.43]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7jZn-003Xgu-1s; Mon, 27 Nov 2023 21:55:37 +0000 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1fa26074783so1456131fac.1; Mon, 27 Nov 2023 13:55:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701122134; x=1701726934; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q+Cbf4Z4xMq9dOhY2lkOSlIg0Yv9C+GaGVRwFcKdaa4=; b=AvwE9QUrDyICmOD1GgDVU/lJDWUkgyGTjec/qmjPpSBPQlaOVq4sLOyHXyFW3CmHv8 aiVywIuzuLaLVH9iTXL2mg8knEqBvhSqIJQ1yc/A8uSrOxWEiw33X4U8k45RSKnUQAS4 JJq9ZMPXx7p8FfEOQGxyN2/u2kYV58nvhs+3OxH5d1+dn4CCPxmY7XPE0NrUdsz7BodS Rrz9HbS19Vpa6pTUb02HZaCilVAVyD/Bdp48ZoX1X89LNs07pJ5bqWbBozoXWOh0WrVQ PUleNXdcNoIo4aOsjzlEy/SOR9ju7ljG2h2kCw7w9FutGt9NanLROdcVfsRA8cdMMJoj V3kQ== X-Gm-Message-State: AOJu0Yx7wEK8KuhNxc6Sitf567qFszFeHBimZ1Z5wmJn/eWTLQH/giwK pIq+v1JMChdCP3u2E1mAfw== X-Google-Smtp-Source: AGHT+IHE/25NEUwlRx2TOFVPP+SptbOdKM4BzwgEQJDXuam12+MKf64pu6FFsol8jZ2RdnKGcptx6g== X-Received: by 2002:a05:6870:5d93:b0:1f0:656b:5b99 with SMTP id fu19-20020a0568705d9300b001f0656b5b99mr19942781oab.11.1701122134393; Mon, 27 Nov 2023 13:55:34 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id lu4-20020a056871314400b001fa54ae35e0sm681401oac.12.2023.11.27.13.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 13:55:33 -0800 (PST) Received: (nullmailer pid 3942464 invoked by uid 1000); Mon, 27 Nov 2023 21:55:32 -0000 Date: Mon, 27 Nov 2023 15:55:32 -0600 From: Rob Herring To: Laurent Pinchart Cc: Krzysztof Kozlowski , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Davis , Andrew Lunn , Arnd Bergmann , Bjorn Andersson , Chen-Yu Tsai , Dmitry Baryshkov , Geert Uytterhoeven , Heiko Stuebner , Jonathan Corbet , Konrad Dybcio , Michal Simek , Neil Armstrong , Nishanth Menon , Olof Johansson , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, workflows@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document Message-ID: <20231127215532.GA3822595-robh@kernel.org> References: <20231125184422.12315-1-krzysztof.kozlowski@linaro.org> <20231125193737.GD7486@pendragon.ideasonboard.com> <26f095ab-c47d-4bcb-9830-4493b1c0cc75@linaro.org> <20231126145340.GA19999@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231126145340.GA19999@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_135535_888904_3C0989C4 X-CRM114-Status: GOOD ( 27.74 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sun, Nov 26, 2023 at 04:53:40PM +0200, Laurent Pinchart wrote: > Hi Krzysztof, > > On Sun, Nov 26, 2023 at 11:32:17AM +0100, Krzysztof Kozlowski wrote: > > On 25/11/2023 20:37, Laurent Pinchart wrote: > > > On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote: > > >> Document preferred coding style for Devicetree sources (DTS and DTSI), > > >> to bring consistency among all (sub)architectures and ease in reviews. > > >> + > > >> +Naming and Valid Characters > > >> +--------------------------- > > >> + > > >> +Devicetree specification allows broader range of characters in node and > > > > > > s/Devicetree specification/The Devicetree specification/ > > > s/broader range/a broad range/ > > > > Ack, but I really expect people finish with grammar and style fixes at > > v3. Please point the language things now or just let it go. > > v3 is the first version that ended up in my inbox. I haven't noticed any > other spelling or grammar error in this patch, but I can't guarantee I > won't see any in new text that gets introduced in a future version :-) > > > >> +property names, but for code readability the choice shall be narrowed. > > >> + > > >> +1. Node and property names are allowed to use only: > > >> + > > >> + * lowercase characters: [a-z] > > >> + * digits: [0-9] > > >> + * dash: - > > >> + > > >> +2. Labels are allowed to use only: > > >> + > > >> + * lowercase characters: [a-z] > > >> + * digits: [0-9] > > >> + * underscore: _ > > >> + > > >> +3. Unit addresses shall use lowercase hex, without leading zeros (padding). Unless a bus defines differently, unit addresses shall ... > > > > > > I'm curious, what's the reason for this ? I think it makes the sources > > > less readable. If the rule is "just" because that's how DT sources are > > > written today and it would be too complicated to change that, that's > > > fine with me. > > > > Warning (unit_address_format): /cpus/cpu@0100: unit name should not have > > leading 0s > > > > And we fixed all or most of DTS some time ago. > > It's the current practice in DT sources and I understand it won't get > changed, but I was more curious about the rationale behind that. I put the dtc check in, but the rational predates me. The OF PCI bus supplement from the 1990s defines that. My only rationale to check it was to be consistent. We don't check "the unit-address is lowercase hex" because technically the bus defines the format. Leading 0s was as much as I could get David G to agree to check without regard to bus type. Rob _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25C4CC1; Mon, 27 Nov 2023 13:55:35 -0800 (PST) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1fa1bcf1d01so1662305fac.0; Mon, 27 Nov 2023 13:55:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701122134; x=1701726934; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q+Cbf4Z4xMq9dOhY2lkOSlIg0Yv9C+GaGVRwFcKdaa4=; b=mrXfHhXWE/HlW2oFiNizk/4cY7MlU1odoM361EH5rtfmSMORp9a7f5V4lxp8RhJKOG RtiNb4XcSSukoq7dWX47nS31m3RPr/AOlH/cLj1xYR3xvLsiC8hZlcPkr66cchGj8a1P G9YBcRlvEWNcvVTVkzK37yyjIbOkS9RkAGy7nOMY5JdE0fAN+x1y1fXwzoUFgNShccKr vAzgQAdN9Pen4VpF7x8keE/HTjvUSftSllOlBfqEidZynaEDnllI9SeEVVuVUk6pBOj1 nHIVZA6CJWX2zS/lpo5elch+xJsO65OpC3RN+AAxZugOK09QyAt7dgIDRWaSpdk3WOmN 6CKw== X-Gm-Message-State: AOJu0YxdpstD7o/e9IpkjZVtXCniis3oekydzZjW6JjpIdFjUF6EsK3i Vseh7+bJV2+xp2XRvIsEnatSwb+Fpg== X-Google-Smtp-Source: AGHT+IHE/25NEUwlRx2TOFVPP+SptbOdKM4BzwgEQJDXuam12+MKf64pu6FFsol8jZ2RdnKGcptx6g== X-Received: by 2002:a05:6870:5d93:b0:1f0:656b:5b99 with SMTP id fu19-20020a0568705d9300b001f0656b5b99mr19942781oab.11.1701122134393; Mon, 27 Nov 2023 13:55:34 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id lu4-20020a056871314400b001fa54ae35e0sm681401oac.12.2023.11.27.13.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 13:55:33 -0800 (PST) Received: (nullmailer pid 3942464 invoked by uid 1000); Mon, 27 Nov 2023 21:55:32 -0000 Date: Mon, 27 Nov 2023 15:55:32 -0600 From: Rob Herring To: Laurent Pinchart Cc: Krzysztof Kozlowski , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Davis , Andrew Lunn , Arnd Bergmann , Bjorn Andersson , Chen-Yu Tsai , Dmitry Baryshkov , Geert Uytterhoeven , Heiko Stuebner , Jonathan Corbet , Konrad Dybcio , Michal Simek , Neil Armstrong , Nishanth Menon , Olof Johansson , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, workflows@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document Message-ID: <20231127215532.GA3822595-robh@kernel.org> References: <20231125184422.12315-1-krzysztof.kozlowski@linaro.org> <20231125193737.GD7486@pendragon.ideasonboard.com> <26f095ab-c47d-4bcb-9830-4493b1c0cc75@linaro.org> <20231126145340.GA19999@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231126145340.GA19999@pendragon.ideasonboard.com> On Sun, Nov 26, 2023 at 04:53:40PM +0200, Laurent Pinchart wrote: > Hi Krzysztof, > > On Sun, Nov 26, 2023 at 11:32:17AM +0100, Krzysztof Kozlowski wrote: > > On 25/11/2023 20:37, Laurent Pinchart wrote: > > > On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote: > > >> Document preferred coding style for Devicetree sources (DTS and DTSI), > > >> to bring consistency among all (sub)architectures and ease in reviews. > > >> + > > >> +Naming and Valid Characters > > >> +--------------------------- > > >> + > > >> +Devicetree specification allows broader range of characters in node and > > > > > > s/Devicetree specification/The Devicetree specification/ > > > s/broader range/a broad range/ > > > > Ack, but I really expect people finish with grammar and style fixes at > > v3. Please point the language things now or just let it go. > > v3 is the first version that ended up in my inbox. I haven't noticed any > other spelling or grammar error in this patch, but I can't guarantee I > won't see any in new text that gets introduced in a future version :-) > > > >> +property names, but for code readability the choice shall be narrowed. > > >> + > > >> +1. Node and property names are allowed to use only: > > >> + > > >> + * lowercase characters: [a-z] > > >> + * digits: [0-9] > > >> + * dash: - > > >> + > > >> +2. Labels are allowed to use only: > > >> + > > >> + * lowercase characters: [a-z] > > >> + * digits: [0-9] > > >> + * underscore: _ > > >> + > > >> +3. Unit addresses shall use lowercase hex, without leading zeros (padding). Unless a bus defines differently, unit addresses shall ... > > > > > > I'm curious, what's the reason for this ? I think it makes the sources > > > less readable. If the rule is "just" because that's how DT sources are > > > written today and it would be too complicated to change that, that's > > > fine with me. > > > > Warning (unit_address_format): /cpus/cpu@0100: unit name should not have > > leading 0s > > > > And we fixed all or most of DTS some time ago. > > It's the current practice in DT sources and I understand it won't get > changed, but I was more curious about the rationale behind that. I put the dtc check in, but the rational predates me. The OF PCI bus supplement from the 1990s defines that. My only rationale to check it was to be consistent. We don't check "the unit-address is lowercase hex" because technically the bus defines the format. Leading 0s was as much as I could get David G to agree to check without regard to bus type. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5A47C4167B for ; Mon, 27 Nov 2023 21:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O08K7NOfM9pW7lWkHySyC+I/qFjXoAlGt0p06cWd1DA=; b=GZxfKC3/ueggGw rLfmNKThZ4mwXIwx6jibc9hVcTMomvTILc1BfxrAZ6S1xfPltK1ooXpSorC8htfyP399SrMfRD+B0 eCOqwEBVaB8N1e8Brp9GMXizkXTH4qBGRtZ/LnAakXq3lypwNija72bZlnOufME3eUxbWxUNkQviz Lu9Em1oKaftp6iN4785NuOOhrBtAFVhvNcPjKVIyIiXkNFBqJ/5XdE0lKg7HDPphYOntf+2yp47i6 n/MwFYwPGaJxnbgv1XJEkbVberoqU0nsY0c9tCThh+gPLYgMYkxiMEwAafmS+85KrTAAa9KsnVAlf Ru4lLaUwGIP2ShbmpTKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7jZw-003XkR-2I; Mon, 27 Nov 2023 21:55:46 +0000 Received: from mail-oa1-f43.google.com ([209.85.160.43]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7jZn-003Xgu-1s; Mon, 27 Nov 2023 21:55:37 +0000 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1fa26074783so1456131fac.1; Mon, 27 Nov 2023 13:55:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701122134; x=1701726934; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q+Cbf4Z4xMq9dOhY2lkOSlIg0Yv9C+GaGVRwFcKdaa4=; b=AvwE9QUrDyICmOD1GgDVU/lJDWUkgyGTjec/qmjPpSBPQlaOVq4sLOyHXyFW3CmHv8 aiVywIuzuLaLVH9iTXL2mg8knEqBvhSqIJQ1yc/A8uSrOxWEiw33X4U8k45RSKnUQAS4 JJq9ZMPXx7p8FfEOQGxyN2/u2kYV58nvhs+3OxH5d1+dn4CCPxmY7XPE0NrUdsz7BodS Rrz9HbS19Vpa6pTUb02HZaCilVAVyD/Bdp48ZoX1X89LNs07pJ5bqWbBozoXWOh0WrVQ PUleNXdcNoIo4aOsjzlEy/SOR9ju7ljG2h2kCw7w9FutGt9NanLROdcVfsRA8cdMMJoj V3kQ== X-Gm-Message-State: AOJu0Yx7wEK8KuhNxc6Sitf567qFszFeHBimZ1Z5wmJn/eWTLQH/giwK pIq+v1JMChdCP3u2E1mAfw== X-Google-Smtp-Source: AGHT+IHE/25NEUwlRx2TOFVPP+SptbOdKM4BzwgEQJDXuam12+MKf64pu6FFsol8jZ2RdnKGcptx6g== X-Received: by 2002:a05:6870:5d93:b0:1f0:656b:5b99 with SMTP id fu19-20020a0568705d9300b001f0656b5b99mr19942781oab.11.1701122134393; Mon, 27 Nov 2023 13:55:34 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id lu4-20020a056871314400b001fa54ae35e0sm681401oac.12.2023.11.27.13.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 13:55:33 -0800 (PST) Received: (nullmailer pid 3942464 invoked by uid 1000); Mon, 27 Nov 2023 21:55:32 -0000 Date: Mon, 27 Nov 2023 15:55:32 -0600 From: Rob Herring To: Laurent Pinchart Cc: Krzysztof Kozlowski , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Davis , Andrew Lunn , Arnd Bergmann , Bjorn Andersson , Chen-Yu Tsai , Dmitry Baryshkov , Geert Uytterhoeven , Heiko Stuebner , Jonathan Corbet , Konrad Dybcio , Michal Simek , Neil Armstrong , Nishanth Menon , Olof Johansson , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, workflows@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document Message-ID: <20231127215532.GA3822595-robh@kernel.org> References: <20231125184422.12315-1-krzysztof.kozlowski@linaro.org> <20231125193737.GD7486@pendragon.ideasonboard.com> <26f095ab-c47d-4bcb-9830-4493b1c0cc75@linaro.org> <20231126145340.GA19999@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231126145340.GA19999@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_135535_888904_3C0989C4 X-CRM114-Status: GOOD ( 27.74 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Sun, Nov 26, 2023 at 04:53:40PM +0200, Laurent Pinchart wrote: > Hi Krzysztof, > > On Sun, Nov 26, 2023 at 11:32:17AM +0100, Krzysztof Kozlowski wrote: > > On 25/11/2023 20:37, Laurent Pinchart wrote: > > > On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote: > > >> Document preferred coding style for Devicetree sources (DTS and DTSI), > > >> to bring consistency among all (sub)architectures and ease in reviews. > > >> + > > >> +Naming and Valid Characters > > >> +--------------------------- > > >> + > > >> +Devicetree specification allows broader range of characters in node and > > > > > > s/Devicetree specification/The Devicetree specification/ > > > s/broader range/a broad range/ > > > > Ack, but I really expect people finish with grammar and style fixes at > > v3. Please point the language things now or just let it go. > > v3 is the first version that ended up in my inbox. I haven't noticed any > other spelling or grammar error in this patch, but I can't guarantee I > won't see any in new text that gets introduced in a future version :-) > > > >> +property names, but for code readability the choice shall be narrowed. > > >> + > > >> +1. Node and property names are allowed to use only: > > >> + > > >> + * lowercase characters: [a-z] > > >> + * digits: [0-9] > > >> + * dash: - > > >> + > > >> +2. Labels are allowed to use only: > > >> + > > >> + * lowercase characters: [a-z] > > >> + * digits: [0-9] > > >> + * underscore: _ > > >> + > > >> +3. Unit addresses shall use lowercase hex, without leading zeros (padding). Unless a bus defines differently, unit addresses shall ... > > > > > > I'm curious, what's the reason for this ? I think it makes the sources > > > less readable. If the rule is "just" because that's how DT sources are > > > written today and it would be too complicated to change that, that's > > > fine with me. > > > > Warning (unit_address_format): /cpus/cpu@0100: unit name should not have > > leading 0s > > > > And we fixed all or most of DTS some time ago. > > It's the current practice in DT sources and I understand it won't get > changed, but I was more curious about the rationale behind that. I put the dtc check in, but the rational predates me. The OF PCI bus supplement from the 1990s defines that. My only rationale to check it was to be consistent. We don't check "the unit-address is lowercase hex" because technically the bus defines the format. Leading 0s was as much as I could get David G to agree to check without regard to bus type. Rob _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A071CC4167B for ; Mon, 27 Nov 2023 21:56:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=btOaWuD+pIuq3+f2MNrE14A8hi51sqgqVBhNNeYTAlA=; b=D+ZNiOIAHLuuYW VpQm8KLQQqnEjjUUuyRt4ZpvbDnMP2da4K+6+E0aze9ChuZekzfqagKiBZPtHpf/iX9RXs20hciZf K8gumVzKYDkfE4HPPnrhCh6wniQ4BGSJRbTZ7f4Bz22Iy8stGTXlIZ6sL/kFbx/U0lZa38s1u79Ap h+0bICSdlzVbCjwwk6DuUggqCnxbn96qeT5KKrSUorwLPMuxgIWBTdiwB4l12JAGESv8K1BOzleYx OeR1EQcXrZ/p29Z5EyMZLOgbFtujjuZ8szj9Mq+oPqVdgmCXN4OMyNQjGYfJ5jTK6Jl3c0yQHa9uK +hYHzl/yPCCEHYSGTnhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7jZq-003XiF-2r; Mon, 27 Nov 2023 21:55:40 +0000 Received: from mail-oa1-f43.google.com ([209.85.160.43]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7jZn-003Xgu-1s; Mon, 27 Nov 2023 21:55:37 +0000 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1fa26074783so1456131fac.1; Mon, 27 Nov 2023 13:55:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701122134; x=1701726934; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q+Cbf4Z4xMq9dOhY2lkOSlIg0Yv9C+GaGVRwFcKdaa4=; b=AvwE9QUrDyICmOD1GgDVU/lJDWUkgyGTjec/qmjPpSBPQlaOVq4sLOyHXyFW3CmHv8 aiVywIuzuLaLVH9iTXL2mg8knEqBvhSqIJQ1yc/A8uSrOxWEiw33X4U8k45RSKnUQAS4 JJq9ZMPXx7p8FfEOQGxyN2/u2kYV58nvhs+3OxH5d1+dn4CCPxmY7XPE0NrUdsz7BodS Rrz9HbS19Vpa6pTUb02HZaCilVAVyD/Bdp48ZoX1X89LNs07pJ5bqWbBozoXWOh0WrVQ PUleNXdcNoIo4aOsjzlEy/SOR9ju7ljG2h2kCw7w9FutGt9NanLROdcVfsRA8cdMMJoj V3kQ== X-Gm-Message-State: AOJu0Yx7wEK8KuhNxc6Sitf567qFszFeHBimZ1Z5wmJn/eWTLQH/giwK pIq+v1JMChdCP3u2E1mAfw== X-Google-Smtp-Source: AGHT+IHE/25NEUwlRx2TOFVPP+SptbOdKM4BzwgEQJDXuam12+MKf64pu6FFsol8jZ2RdnKGcptx6g== X-Received: by 2002:a05:6870:5d93:b0:1f0:656b:5b99 with SMTP id fu19-20020a0568705d9300b001f0656b5b99mr19942781oab.11.1701122134393; Mon, 27 Nov 2023 13:55:34 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id lu4-20020a056871314400b001fa54ae35e0sm681401oac.12.2023.11.27.13.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 13:55:33 -0800 (PST) Received: (nullmailer pid 3942464 invoked by uid 1000); Mon, 27 Nov 2023 21:55:32 -0000 Date: Mon, 27 Nov 2023 15:55:32 -0600 From: Rob Herring To: Laurent Pinchart Cc: Krzysztof Kozlowski , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Davis , Andrew Lunn , Arnd Bergmann , Bjorn Andersson , Chen-Yu Tsai , Dmitry Baryshkov , Geert Uytterhoeven , Heiko Stuebner , Jonathan Corbet , Konrad Dybcio , Michal Simek , Neil Armstrong , Nishanth Menon , Olof Johansson , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, workflows@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document Message-ID: <20231127215532.GA3822595-robh@kernel.org> References: <20231125184422.12315-1-krzysztof.kozlowski@linaro.org> <20231125193737.GD7486@pendragon.ideasonboard.com> <26f095ab-c47d-4bcb-9830-4493b1c0cc75@linaro.org> <20231126145340.GA19999@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231126145340.GA19999@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_135535_888904_3C0989C4 X-CRM114-Status: GOOD ( 27.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 26, 2023 at 04:53:40PM +0200, Laurent Pinchart wrote: > Hi Krzysztof, > > On Sun, Nov 26, 2023 at 11:32:17AM +0100, Krzysztof Kozlowski wrote: > > On 25/11/2023 20:37, Laurent Pinchart wrote: > > > On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote: > > >> Document preferred coding style for Devicetree sources (DTS and DTSI), > > >> to bring consistency among all (sub)architectures and ease in reviews. > > >> + > > >> +Naming and Valid Characters > > >> +--------------------------- > > >> + > > >> +Devicetree specification allows broader range of characters in node and > > > > > > s/Devicetree specification/The Devicetree specification/ > > > s/broader range/a broad range/ > > > > Ack, but I really expect people finish with grammar and style fixes at > > v3. Please point the language things now or just let it go. > > v3 is the first version that ended up in my inbox. I haven't noticed any > other spelling or grammar error in this patch, but I can't guarantee I > won't see any in new text that gets introduced in a future version :-) > > > >> +property names, but for code readability the choice shall be narrowed. > > >> + > > >> +1. Node and property names are allowed to use only: > > >> + > > >> + * lowercase characters: [a-z] > > >> + * digits: [0-9] > > >> + * dash: - > > >> + > > >> +2. Labels are allowed to use only: > > >> + > > >> + * lowercase characters: [a-z] > > >> + * digits: [0-9] > > >> + * underscore: _ > > >> + > > >> +3. Unit addresses shall use lowercase hex, without leading zeros (padding). Unless a bus defines differently, unit addresses shall ... > > > > > > I'm curious, what's the reason for this ? I think it makes the sources > > > less readable. If the rule is "just" because that's how DT sources are > > > written today and it would be too complicated to change that, that's > > > fine with me. > > > > Warning (unit_address_format): /cpus/cpu@0100: unit name should not have > > leading 0s > > > > And we fixed all or most of DTS some time ago. > > It's the current practice in DT sources and I understand it won't get > changed, but I was more curious about the rationale behind that. I put the dtc check in, but the rational predates me. The OF PCI bus supplement from the 1990s defines that. My only rationale to check it was to be consistent. We don't check "the unit-address is lowercase hex" because technically the bus defines the format. Leading 0s was as much as I could get David G to agree to check without regard to bus type. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel