From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AFA1A5; Mon, 27 Nov 2023 14:37:02 -0800 (PST) Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3b8382b8f5aso3044049b6e.0; Mon, 27 Nov 2023 14:37:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701124621; x=1701729421; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PuP/BIBy04vLBcoBGVqhGTXN9mmV1eIZYFN8vss7cQg=; b=A+lFa78Pym1Yhid5NTeaNc3CvCf5pmIVgjVnBkKoUVGRvjxc9Z4+SeCwrwsih0ccOi xRh8JT0iQ5SE2vy1OL3eKmJGziVjZ0b8a1RtcsdsZCo8YxCEmhkZJ+ZEVgX1V7PLeYhr CRRKM0pxc7H2/IKMd/i/mIX1tw014yu1iHG2BRuEaKW4XYrj+3kn0DmFds8cKLqknZ2T Pwqjl74qrsyylprcMOxKlM9EEO1k9iA/sDwHL/eO++KaloKsilNxIwKdMSRpzu7RlakV Pq2bgY/qEs5GiCtpzWgTqXRz4R7K85oqA/W4I9dcKvsPDqsCXmmOyu4WQiMSQussurl/ 2ksw== X-Gm-Message-State: AOJu0YwXPVPEMA8He+aCQ/Oj6iru0sGZzkYFkB9ZcRLGlLUGjyHEPwz7 lXr9FqEJLFLlFUIAf1DCjw== X-Google-Smtp-Source: AGHT+IHnBoOuhgYs4OuZFTxhqfLVnkGsU3Xz25XMs+5zcX/cSJDESCt0UIwuoRDE3kSUCtKtw4b/eA== X-Received: by 2002:a05:6808:6493:b0:3b8:42e2:6004 with SMTP id fh19-20020a056808649300b003b842e26004mr19430047oib.42.1701124621210; Mon, 27 Nov 2023 14:37:01 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e13-20020a056808148d00b003b85cc30fe8sm980458oiw.36.2023.11.27.14.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 14:37:00 -0800 (PST) Received: (nullmailer pid 167239 invoked by uid 1000); Mon, 27 Nov 2023 22:36:59 -0000 Date: Mon, 27 Nov 2023 16:36:59 -0600 From: Rob Herring To: Christian Marangi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Heiner Kallweit , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Robert Marko , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [net-next PATCH RFC v3 5/8] dt-bindings: net: add QCA807x PHY defines Message-ID: <20231127223659.GA152280-robh@kernel.org> References: <20231126015346.25208-1-ansuelsmth@gmail.com> <20231126015346.25208-6-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231126015346.25208-6-ansuelsmth@gmail.com> On Sun, Nov 26, 2023 at 02:53:43AM +0100, Christian Marangi wrote: > From: Robert Marko > > Add DT bindings defined for Qualcomm QCA807x PHY series related to > calibration and DAC settings. > > Signed-off-by: Robert Marko > Signed-off-by: Christian Marangi > --- > include/dt-bindings/net/qcom-qca807x.h | 30 ++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 include/dt-bindings/net/qcom-qca807x.h How is this used? There's nothing in the binding about it. Binding headers go with the binding schema that define how they are used. > > diff --git a/include/dt-bindings/net/qcom-qca807x.h b/include/dt-bindings/net/qcom-qca807x.h > new file mode 100644 > index 000000000000..e7d4d09b7dd4 > --- /dev/null > +++ b/include/dt-bindings/net/qcom-qca807x.h > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ > +/* > + * Device Tree constants for the Qualcomm QCA807X PHYs > + */ > + > +#ifndef _DT_BINDINGS_QCOM_QCA807X_H > +#define _DT_BINDINGS_QCOM_QCA807X_H > + > +/* Full amplitude, full bias current */ > +#define QCA807X_CONTROL_DAC_FULL_VOLT_BIAS 0 > +/* Amplitude follow DSP (amplitude is adjusted based on cable length), half bias current */ > +#define QCA807X_CONTROL_DAC_DSP_VOLT_HALF_BIAS 1 > +/* Full amplitude, bias current follow DSP (bias current is adjusted based on cable length) */ > +#define QCA807X_CONTROL_DAC_FULL_VOLT_DSP_BIAS 2 > +/* Both amplitude and bias current follow DSP */ > +#define QCA807X_CONTROL_DAC_DSP_VOLT_BIAS 3 > +/* Full amplitude, half bias current */ > +#define QCA807X_CONTROL_DAC_FULL_VOLT_HALF_BIAS 4 > +/* Amplitude follow DSP setting; 1/4 bias current when cable<10m, > + * otherwise half bias current > + */ > +#define QCA807X_CONTROL_DAC_DSP_VOLT_QUARTER_BIAS 5 > +/* Full amplitude; same bias current setting with “010” and “011”, > + * but half more bias is reduced when cable <10m > + */ > +#define QCA807X_CONTROL_DAC_FULL_VOLT_HALF_BIAS_SHORT 6 > +/* Amplitude follow DSP; same bias current setting with “110”, default value */ > +#define QCA807X_CONTROL_DAC_DSP_VOLT_HALF_BIAS_SHORT 7 > + > +#endif > -- > 2.40.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A351DC4167B for ; Mon, 27 Nov 2023 22:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eLzNReMg/iQgZA/F4r4joa8F6tixo9ouUw2cwdlOjA0=; b=LSRuCVbizdxcpf rlHWmdFShcR/5XUe1vQ6oROfdw4cKxwwvAIqngFq6itXjVva5LmqS7o6LAvXEmWMdDb+dlaKihpLX uTjviXzx5mD6BT/hYTfW7luwuNepTjuwgJCpuY3PqQJcT2fs71a1AiNuIJwJBSaZWltu8ptNYXBGk TJb15b3CT1mVeLDlbPP8DAenjPwUsuPjJhoIypWfAzt2ZusiFkGySpvVOOTtKWgIFA0gUqk9VvoGW y4ntVf5lg83JIm1UsGgY5wgSlddvZ569YjsBsg/ByEew71rbadoygOzMHehoeBpTJAT4VfdAL3otA ylULeOrtdj82qeZ4qY1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7kDx-003bRU-1O; Mon, 27 Nov 2023 22:37:05 +0000 Received: from mail-oi1-f177.google.com ([209.85.167.177]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7kDu-003bR4-2t; Mon, 27 Nov 2023 22:37:04 +0000 Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3b2e330033fso3030851b6e.3; Mon, 27 Nov 2023 14:37:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701124621; x=1701729421; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PuP/BIBy04vLBcoBGVqhGTXN9mmV1eIZYFN8vss7cQg=; b=LqfT4mWff9QRDKV8krhgSn62btMcZEa2WFSzdGqa8EtpdO0nJJE3EEWJ5VL7ubUHtF +L7ts3awqRfFHjHlh2IqcLvN3CwTTXvAhbp2HdWrDQ4xIasC2rBOXQ/19WMS65z3ZXFf Mv00AOGsHSe8CqIyoQt26A1vQN9HvKbMq6YlC1+O5EAhz9iuq4F+HVfIzPDDOE6edc16 2IKIUIWye6KlehMR8wbR508dYbqadXEwG8NkDI7K8UwBBbmmBYD60f57NhluN17OzH13 eT78pVsbfD3xNmITC7xi4ylgj0a2u74uTPIUBwn2klV1cKKa0P9XL/pr5dsk7jXMgYS8 oZLw== X-Gm-Message-State: AOJu0Yxv/vWahGBWhqEAWyP/WV2D5SPKpzxS/mviSBhhwnMzGPkamveM R/OvcJWnwtLwTy67hhAEbA== X-Google-Smtp-Source: AGHT+IHnBoOuhgYs4OuZFTxhqfLVnkGsU3Xz25XMs+5zcX/cSJDESCt0UIwuoRDE3kSUCtKtw4b/eA== X-Received: by 2002:a05:6808:6493:b0:3b8:42e2:6004 with SMTP id fh19-20020a056808649300b003b842e26004mr19430047oib.42.1701124621210; Mon, 27 Nov 2023 14:37:01 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e13-20020a056808148d00b003b85cc30fe8sm980458oiw.36.2023.11.27.14.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 14:37:00 -0800 (PST) Received: (nullmailer pid 167239 invoked by uid 1000); Mon, 27 Nov 2023 22:36:59 -0000 Date: Mon, 27 Nov 2023 16:36:59 -0600 From: Rob Herring To: Christian Marangi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Heiner Kallweit , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Robert Marko , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [net-next PATCH RFC v3 5/8] dt-bindings: net: add QCA807x PHY defines Message-ID: <20231127223659.GA152280-robh@kernel.org> References: <20231126015346.25208-1-ansuelsmth@gmail.com> <20231126015346.25208-6-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231126015346.25208-6-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_143702_938317_DE7FC762 X-CRM114-Status: GOOD ( 18.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBOb3YgMjYsIDIwMjMgYXQgMDI6NTM6NDNBTSArMDEwMCwgQ2hyaXN0aWFuIE1hcmFu Z2kgd3JvdGU6Cj4gRnJvbTogUm9iZXJ0IE1hcmtvIDxyb2JlcnQubWFya29Ac2FydHVyYS5ocj4K PiAKPiBBZGQgRFQgYmluZGluZ3MgZGVmaW5lZCBmb3IgUXVhbGNvbW0gUUNBODA3eCBQSFkgc2Vy aWVzIHJlbGF0ZWQgdG8KPiBjYWxpYnJhdGlvbiBhbmQgREFDIHNldHRpbmdzLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IFJvYmVydCBNYXJrbyA8cm9iZXJ0Lm1hcmtvQHNhcnR1cmEuaHI+Cj4gU2lnbmVk LW9mZi1ieTogQ2hyaXN0aWFuIE1hcmFuZ2kgPGFuc3VlbHNtdGhAZ21haWwuY29tPgo+IC0tLQo+ ICBpbmNsdWRlL2R0LWJpbmRpbmdzL25ldC9xY29tLXFjYTgwN3guaCB8IDMwICsrKysrKysrKysr KysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspCj4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2R0LWJpbmRpbmdzL25ldC9xY29tLXFjYTgwN3guaAoK SG93IGlzIHRoaXMgdXNlZD8gVGhlcmUncyBub3RoaW5nIGluIHRoZSBiaW5kaW5nIGFib3V0IGl0 LiBCaW5kaW5nIApoZWFkZXJzIGdvIHdpdGggdGhlIGJpbmRpbmcgc2NoZW1hIHRoYXQgZGVmaW5l IGhvdyB0aGV5IGFyZSB1c2VkLgoKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kdC1iaW5kaW5n cy9uZXQvcWNvbS1xY2E4MDd4LmggYi9pbmNsdWRlL2R0LWJpbmRpbmdzL25ldC9xY29tLXFjYTgw N3guaAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi5lN2Q0ZDA5 YjdkZDQKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvaW5jbHVkZS9kdC1iaW5kaW5ncy9uZXQvcWNv bS1xY2E4MDd4LmgKPiBAQCAtMCwwICsxLDMwIEBACj4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlm aWVyOiBHUEwtMi4wLW9ubHkgT1IgTUlUICovCj4gKy8qCj4gKyAqIERldmljZSBUcmVlIGNvbnN0 YW50cyBmb3IgdGhlIFF1YWxjb21tIFFDQTgwN1ggUEhZcwo+ICsgKi8KPiArCj4gKyNpZm5kZWYg X0RUX0JJTkRJTkdTX1FDT01fUUNBODA3WF9ICj4gKyNkZWZpbmUgX0RUX0JJTkRJTkdTX1FDT01f UUNBODA3WF9ICj4gKwo+ICsvKiBGdWxsIGFtcGxpdHVkZSwgZnVsbCBiaWFzIGN1cnJlbnQgKi8K PiArI2RlZmluZSBRQ0E4MDdYX0NPTlRST0xfREFDX0ZVTExfVk9MVF9CSUFTCQkwCj4gKy8qIEFt cGxpdHVkZSBmb2xsb3cgRFNQIChhbXBsaXR1ZGUgaXMgYWRqdXN0ZWQgYmFzZWQgb24gY2FibGUg bGVuZ3RoKSwgaGFsZiBiaWFzIGN1cnJlbnQgKi8KPiArI2RlZmluZSBRQ0E4MDdYX0NPTlRST0xf REFDX0RTUF9WT0xUX0hBTEZfQklBUwkJMQo+ICsvKiBGdWxsIGFtcGxpdHVkZSwgYmlhcyBjdXJy ZW50IGZvbGxvdyBEU1AgKGJpYXMgY3VycmVudCBpcyBhZGp1c3RlZCBiYXNlZCBvbiBjYWJsZSBs ZW5ndGgpICovCj4gKyNkZWZpbmUgUUNBODA3WF9DT05UUk9MX0RBQ19GVUxMX1ZPTFRfRFNQX0JJ QVMJCTIKPiArLyogQm90aCBhbXBsaXR1ZGUgYW5kIGJpYXMgY3VycmVudCBmb2xsb3cgRFNQICov Cj4gKyNkZWZpbmUgUUNBODA3WF9DT05UUk9MX0RBQ19EU1BfVk9MVF9CSUFTCQkzCj4gKy8qIEZ1 bGwgYW1wbGl0dWRlLCBoYWxmIGJpYXMgY3VycmVudCAqLwo+ICsjZGVmaW5lIFFDQTgwN1hfQ09O VFJPTF9EQUNfRlVMTF9WT0xUX0hBTEZfQklBUwkJNAo+ICsvKiBBbXBsaXR1ZGUgZm9sbG93IERT UCBzZXR0aW5nOyAxLzQgYmlhcyBjdXJyZW50IHdoZW4gY2FibGU8MTBtLAo+ICsgKiBvdGhlcndp c2UgaGFsZiBiaWFzIGN1cnJlbnQKPiArICovCj4gKyNkZWZpbmUgUUNBODA3WF9DT05UUk9MX0RB Q19EU1BfVk9MVF9RVUFSVEVSX0JJQVMJNQo+ICsvKiBGdWxsIGFtcGxpdHVkZTsgc2FtZSBiaWFz IGN1cnJlbnQgc2V0dGluZyB3aXRoIOKAnDAxMOKAnSBhbmQg4oCcMDEx4oCdLAo+ICsgKiBidXQg aGFsZiBtb3JlIGJpYXMgaXMgcmVkdWNlZCB3aGVuIGNhYmxlIDwxMG0KPiArICovCj4gKyNkZWZp bmUgUUNBODA3WF9DT05UUk9MX0RBQ19GVUxMX1ZPTFRfSEFMRl9CSUFTX1NIT1JUCTYKPiArLyog QW1wbGl0dWRlIGZvbGxvdyBEU1A7IHNhbWUgYmlhcyBjdXJyZW50IHNldHRpbmcgd2l0aCDigJwx MTDigJ0sIGRlZmF1bHQgdmFsdWUgKi8KPiArI2RlZmluZSBRQ0E4MDdYX0NPTlRST0xfREFDX0RT UF9WT0xUX0hBTEZfQklBU19TSE9SVAk3Cj4gKwo+ICsjZW5kaWYKPiAtLSAKPiAyLjQwLjEKPiAK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK