From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BBA8C07E97 for ; Tue, 28 Nov 2023 13:53:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0179210E547; Tue, 28 Nov 2023 13:53:57 +0000 (UTC) Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42CB610E401 for ; Tue, 28 Nov 2023 05:15:05 +0000 (UTC) Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3b58d96a3bbso3065531b6e.1 for ; Mon, 27 Nov 2023 21:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701148504; x=1701753304; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2JoDhAoTR0SgWotjuFJFh8rPqxox7iwGsvE9hRWNQRY=; b=lva/RLKIGYj+egp/r5PR+8bz8hW7uEwP4XWHZMbfcFHF26RpWZek3M652dLybTgfFt XE1Jpg7MRe+VP/mF+Gvcu9emxDkLR4/UTScS7gxTuKQaI7Zy45oyRPRlMCegCsotumHq /YfgewLW1vDWZMBxYU7RzX9bYd2olC9AahNCfqTVATGr806N8ZEiXrR0QvUgh0tWtHGl FV4FcwTUSIRK0FdpxccC0Si6IxIlUEats4LJXNpuSI42FSdeCC7tK/CQDEf3kS6H8Fjw xMz4f8XkeqXNfz9fTkF94fqEiFmJCGceUbx9JOHSa3+DMfRbh9d89w2Vy79nANuoegIx Fg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701148504; x=1701753304; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2JoDhAoTR0SgWotjuFJFh8rPqxox7iwGsvE9hRWNQRY=; b=RFeZekaH7nDPD8l0r4EoT4aQ4C/Yf0PC6XGU55nARSF2hFhtjUP3F/B956OsOTwQmv 3a4Bgipd/X0Gx9zFIL0Ez/At37vqw7XMnUcSkyR3W6nbrxsUhoHJQh8KwUhAtjOQ6MN7 4uTPm+HriWtKTLHBFkx64zCpmYsbsLvRVfbf9M1B/OowY81HKtOO47baUpTWyXGw3shr NA1RXh1Z7LIzU8Tc20ea1XZM7gPfvGFSGE2jQCq9FNbt/FKWP7pxNpBUAXYqqLwc7sSq rP5DdklEZzsdCL/54KTZlrACo9piaRLh/WxhgmH5CfXxO624VKZE14Ny0wwTJSGMGLNr pDdg== X-Gm-Message-State: AOJu0YxnWiMt77ZxjbbG9E34NnV2d7J5Vaz6uANEqsLMWCKIoBK8BDok b6hEd6nnfSg9Gc5elyZ9/nya X-Google-Smtp-Source: AGHT+IGyf/7KAwi2AXPmYeCIDQnKIhHc2XSuIyEGnblje0EJXhZBPY9aMi6CVPuB2Vd6usaT1FIhGA== X-Received: by 2002:a05:6808:3209:b0:3b8:4ada:7d7b with SMTP id cb9-20020a056808320900b003b84ada7d7bmr19405065oib.28.1701148504384; Mon, 27 Nov 2023 21:15:04 -0800 (PST) Received: from thinkpad ([117.213.103.241]) by smtp.gmail.com with ESMTPSA id r24-20020a62e418000000b006cb9725f5fdsm8033842pfh.217.2023.11.27.21.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 21:15:03 -0800 (PST) Date: Tue, 28 Nov 2023 10:44:56 +0530 From: Manivannan Sadhasivam To: Vignesh Raman Message-ID: <20231128051456.GA3088@thinkpad> References: <20231128042026.130442-1-vignesh.raman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231128042026.130442-1-vignesh.raman@collabora.com> X-Mailman-Approved-At: Tue, 28 Nov 2023 13:53:26 +0000 Subject: Re: [Intel-gfx] [PATCH] PCI: qcom: Fix compile error X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniels@collabora.com, linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, helen.koike@collabora.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > to acquire bus lock") has added an argument to acquire bus lock > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it > without this argument, resulting in below build error. > Where do you see this error? That patch is not even merged. Looks like you are sending the patch against some downstream tree. - Mani > drivers/pci/controller/dwc/pcie-qcom.c:973:9: error: too few arguments to function 'pci_enable_link_state' > > This commit fixes the compilation error by passing the sem argument > to pci_enable_link_state in the qcom_pcie_enable_aspm function. > > Signed-off-by: Vignesh Raman > --- > drivers/pci/controller/dwc/pcie-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 6902e97719d1..e846e3531d8e 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -970,7 +970,7 @@ static int qcom_pcie_enable_aspm(struct pci_dev *pdev, void *userdata) > { > /* Downstream devices need to be in D0 state before enabling PCI PM substates */ > pci_set_power_state(pdev, PCI_D0); > - pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL); > + pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL, false); > > return 0; > } > -- > 2.40.1 > > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BEwJczP2" Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B4CC1B6 for ; Mon, 27 Nov 2023 21:15:05 -0800 (PST) Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3b2f507c03cso3061719b6e.2 for ; Mon, 27 Nov 2023 21:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701148504; x=1701753304; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2JoDhAoTR0SgWotjuFJFh8rPqxox7iwGsvE9hRWNQRY=; b=BEwJczP2xyMDqYZjkXdBYH1y4/RiWsFvRoKEfR4Jj5LO1TJYus3H2lPZJhQMXMbNY5 UBK6IT/nlPA6S9e6oJTqBvwwx/kd13rcEnHRX3KpyXSVIHDNhXTZ8/q2SHh+WooYKkvK b0sfrt6bPajc2f+kMzxcXvi+Nrwb9flXFi6JTYqmkzkssa5uYbH4NNE1KxR5v5ZycSW+ 7FQKSSS+otz6sSQ9sUuuTGBKmMSACh5Z77H00WVpEvxirxLztLAzQKlr/hRoefGHMvc8 adqpGrKW1szAp0nwtzuCX9uB1Sn2ODE78jM0BLd/xfqK7dnCesgneRu8WzNqHI2d0QE+ m7Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701148504; x=1701753304; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2JoDhAoTR0SgWotjuFJFh8rPqxox7iwGsvE9hRWNQRY=; b=An2/EXn/gSclZ/wzdyAieRUzAhVlRxADnVwQn4bBy5os2I/yxbysVFnLYUxjbqkJ8Z B2sUyeHOIfP4XGVf7V7nv0q1/MxDWZD4gGB25mG2lHFNXzdF1sroDd65QWasw4TloU+l HJSHcVMkVXyGBjyQ6NhA2Ors3dh+q6RRK7AjTVVzLZYJlhw4jLJ2lVFzKywW2kx9ITPU VPsr3nrMW28b/0XMasfKcit/Dq9EMn8pzyjv6sHTTO1rH63L2VnriUvCBNIJE7EdlU++ W3RepXhCKjhxT/avULaijJI0X13xZO0Ceu8T8B8IAgbbLk1Rv/LymRj5LAeO07qzMXBa lVHg== X-Gm-Message-State: AOJu0YzUc/zeGVijQsE34ddkyxFSF0lrguHI/C+zjQ1EjJI/BDDrXq4T HaCfMX2xgr3XHopZnQE51siyewLV69J/skj4FQ== X-Google-Smtp-Source: AGHT+IGyf/7KAwi2AXPmYeCIDQnKIhHc2XSuIyEGnblje0EJXhZBPY9aMi6CVPuB2Vd6usaT1FIhGA== X-Received: by 2002:a05:6808:3209:b0:3b8:4ada:7d7b with SMTP id cb9-20020a056808320900b003b84ada7d7bmr19405065oib.28.1701148504384; Mon, 27 Nov 2023 21:15:04 -0800 (PST) Received: from thinkpad ([117.213.103.241]) by smtp.gmail.com with ESMTPSA id r24-20020a62e418000000b006cb9725f5fdsm8033842pfh.217.2023.11.27.21.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 21:15:03 -0800 (PST) Date: Tue, 28 Nov 2023 10:44:56 +0530 From: Manivannan Sadhasivam To: Vignesh Raman Cc: intel-gfx@lists.freedesktop.org, helen.koike@collabora.com, daniels@collabora.com, linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: qcom: Fix compile error Message-ID: <20231128051456.GA3088@thinkpad> References: <20231128042026.130442-1-vignesh.raman@collabora.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231128042026.130442-1-vignesh.raman@collabora.com> On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > to acquire bus lock") has added an argument to acquire bus lock > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it > without this argument, resulting in below build error. > Where do you see this error? That patch is not even merged. Looks like you are sending the patch against some downstream tree. - Mani > drivers/pci/controller/dwc/pcie-qcom.c:973:9: error: too few arguments to function 'pci_enable_link_state' > > This commit fixes the compilation error by passing the sem argument > to pci_enable_link_state in the qcom_pcie_enable_aspm function. > > Signed-off-by: Vignesh Raman > --- > drivers/pci/controller/dwc/pcie-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 6902e97719d1..e846e3531d8e 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -970,7 +970,7 @@ static int qcom_pcie_enable_aspm(struct pci_dev *pdev, void *userdata) > { > /* Downstream devices need to be in D0 state before enabling PCI PM substates */ > pci_set_power_state(pdev, PCI_D0); > - pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL); > + pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL, false); > > return 0; > } > -- > 2.40.1 > > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1E21C4167B for ; Tue, 28 Nov 2023 05:15:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6AC7F10E401; Tue, 28 Nov 2023 05:15:07 +0000 (UTC) Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F5D710E423 for ; Tue, 28 Nov 2023 05:15:05 +0000 (UTC) Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3b58d96a3bbso3065532b6e.1 for ; Mon, 27 Nov 2023 21:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701148504; x=1701753304; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2JoDhAoTR0SgWotjuFJFh8rPqxox7iwGsvE9hRWNQRY=; b=lva/RLKIGYj+egp/r5PR+8bz8hW7uEwP4XWHZMbfcFHF26RpWZek3M652dLybTgfFt XE1Jpg7MRe+VP/mF+Gvcu9emxDkLR4/UTScS7gxTuKQaI7Zy45oyRPRlMCegCsotumHq /YfgewLW1vDWZMBxYU7RzX9bYd2olC9AahNCfqTVATGr806N8ZEiXrR0QvUgh0tWtHGl FV4FcwTUSIRK0FdpxccC0Si6IxIlUEats4LJXNpuSI42FSdeCC7tK/CQDEf3kS6H8Fjw xMz4f8XkeqXNfz9fTkF94fqEiFmJCGceUbx9JOHSa3+DMfRbh9d89w2Vy79nANuoegIx Fg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701148504; x=1701753304; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2JoDhAoTR0SgWotjuFJFh8rPqxox7iwGsvE9hRWNQRY=; b=Iwv2laU6hZPLnDmZqkHfBikVfm+z+Gt60GFNgzNw27/F5tUWS6U7KBXJ36VrMBBKMp VUCnXWE29dDYNKkl+tw8DzQJKLmXOyTgTpxzBNBEBhNAB5MqdS2GaD37FwXQTIInawiQ viYmxdlFHf84A/snLBZlNmBnWA59Chz1XfTExN4KvOrLV6pjno34zKthhCa1oDLBFe7+ zjyCMJZmhGQbR7dUYqmkONP8NutdFZXRVbS9s4iSMoMg9pMp2eDU/2r3MqnKfPaeTx6K nRZFOI/e48ckdAZRhMH3L03JFhxy2+Njj+vc7PwdwDkhMYt+DYjlMUOJpVYO4I3zdpjm jCzw== X-Gm-Message-State: AOJu0Yynjed1SjQJBu+KSWPGI5OEymZzsf4Q6phbPPatWuZG3NNyEwMA zHsmoqxzktIckqMRGYeiRFqg X-Google-Smtp-Source: AGHT+IGyf/7KAwi2AXPmYeCIDQnKIhHc2XSuIyEGnblje0EJXhZBPY9aMi6CVPuB2Vd6usaT1FIhGA== X-Received: by 2002:a05:6808:3209:b0:3b8:4ada:7d7b with SMTP id cb9-20020a056808320900b003b84ada7d7bmr19405065oib.28.1701148504384; Mon, 27 Nov 2023 21:15:04 -0800 (PST) Received: from thinkpad ([117.213.103.241]) by smtp.gmail.com with ESMTPSA id r24-20020a62e418000000b006cb9725f5fdsm8033842pfh.217.2023.11.27.21.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 21:15:03 -0800 (PST) Date: Tue, 28 Nov 2023 10:44:56 +0530 From: Manivannan Sadhasivam To: Vignesh Raman Subject: Re: [PATCH] PCI: qcom: Fix compile error Message-ID: <20231128051456.GA3088@thinkpad> References: <20231128042026.130442-1-vignesh.raman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231128042026.130442-1-vignesh.raman@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniels@collabora.com, linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, helen.koike@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > to acquire bus lock") has added an argument to acquire bus lock > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it > without this argument, resulting in below build error. > Where do you see this error? That patch is not even merged. Looks like you are sending the patch against some downstream tree. - Mani > drivers/pci/controller/dwc/pcie-qcom.c:973:9: error: too few arguments to function 'pci_enable_link_state' > > This commit fixes the compilation error by passing the sem argument > to pci_enable_link_state in the qcom_pcie_enable_aspm function. > > Signed-off-by: Vignesh Raman > --- > drivers/pci/controller/dwc/pcie-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 6902e97719d1..e846e3531d8e 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -970,7 +970,7 @@ static int qcom_pcie_enable_aspm(struct pci_dev *pdev, void *userdata) > { > /* Downstream devices need to be in D0 state before enabling PCI PM substates */ > pci_set_power_state(pdev, PCI_D0); > - pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL); > + pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL, false); > > return 0; > } > -- > 2.40.1 > > -- மணிவண்ணன் சதாசிவம்