From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23745C07CA9 for ; Tue, 28 Nov 2023 13:53:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A050010E534; Tue, 28 Nov 2023 13:53:27 +0000 (UTC) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by gabe.freedesktop.org (Postfix) with ESMTPS id A673E10E4BA for ; Tue, 28 Nov 2023 10:46:05 +0000 (UTC) Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-7788f513872so285715685a.1 for ; Tue, 28 Nov 2023 02:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701168364; x=1701773164; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ody4rvie3s+8GD4mOiQPrgYycVPJoTVFCyOTzD8p7Dc=; b=QRtWCtCm4JbowQTveI3HZcUgb3qOgwjTwNGQbVorto9RswYqQe2CKT56+hu2AqUdn0 kYYijztFnyukkEZyqzeMGwAAEUc3cAkUkiEGu0csGQa2yMSEVOZnGZ8gMEh5r6nCFUaV 8YiL324NrTbBfqoGs+4w7kL1w3EY/i1ITjk2SL4OrBVKZRhr7UPXhCD6FZxvViHss8iJ 8RGRPhiQLXZkPqM7uh8cQ/wzl/WSUYLFO8QdDAOI0SR2ZRYrcHC7BSvPPCNK4ct0Jyoq P22bi404EDX8JUZisN3qPM7+x0HJNbTsERmeK5nTkS2AkdP+dY8j6NmnEXAMTU6ws0sO 5n0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701168364; x=1701773164; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ody4rvie3s+8GD4mOiQPrgYycVPJoTVFCyOTzD8p7Dc=; b=VuyLKxQ3PzwQGU78kshKtJBTqe6MZQc1p1H5GZw/gxbj+4hKMx7QxLD+IzLn2uQKQi rmDnjJ1Iyt3Q8/RfDUwgK2+J9N6r0Lo1UAdyrUL83AfREjM+G9ndTeMG2dAcmh1+08Ti 9EiTh/ssqA3dyJnXF/RoAaN9kHZJlp4yWImrxIj9Bfgo0KEr6rFK8yV8yktV49b39hq1 Lts4lnmca3PDQlIzqB5hhAVjCePtJue724S5JPuCGYH4brq84telHtzaEQ0njCYbHAjv /kIYSvDSp2PJR2J0RyUKN/qzyWyp7lrzueIek8qV2NgdaaR3wY88x+c3WUBbyX+73f0a 4fxg== X-Gm-Message-State: AOJu0YzgwdnjQk8bctZhS3lvQTIyEHwvdELMzGKx3uxFv9nL0/5ixQyq 8gN2EwZoFBX3okhpxNXXzbEo X-Google-Smtp-Source: AGHT+IE8SWfZ7GqO4s0fMyj3jKQqECEGMDFDC8TEC7GRCVPyBE185OA3cmNu5rktS/g6Fo8eFgfD6g== X-Received: by 2002:a0c:fd6b:0:b0:67a:5457:77c9 with SMTP id k11-20020a0cfd6b000000b0067a545777c9mr3755673qvs.11.1701168364626; Tue, 28 Nov 2023 02:46:04 -0800 (PST) Received: from thinkpad ([59.92.99.177]) by smtp.gmail.com with ESMTPSA id b18-20020a0c9b12000000b0065b13180892sm5074170qve.16.2023.11.28.02.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 02:46:04 -0800 (PST) Date: Tue, 28 Nov 2023 16:15:49 +0530 From: Manivannan Sadhasivam To: Jani Nikula Message-ID: <20231128104549.GM3088@thinkpad> References: <20231128042026.130442-1-vignesh.raman@collabora.com> <20231128051456.GA3088@thinkpad> <50a9f061-e1d3-6aca-b528-56dbb6c729d9@collabora.com> <20231128065104.GK3088@thinkpad> <87a5qy88mx.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a5qy88mx.fsf@intel.com> X-Mailman-Approved-At: Tue, 28 Nov 2023 13:53:26 +0000 Subject: Re: [Intel-gfx] [PATCH] PCI: qcom: Fix compile error X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniels@collabora.com, linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org, Vignesh Raman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, helen.koike@collabora.com, Bjorn Helgaas , "David E. Box" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Nov 28, 2023 at 12:39:02PM +0200, Jani Nikula wrote: > On Tue, 28 Nov 2023, Manivannan Sadhasivam wrote: > > On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: > >> Hi Mani, > >> > >> On 28/11/23 10:44, Manivannan Sadhasivam wrote: > >> > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > >> > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > >> > > to acquire bus lock") has added an argument to acquire bus lock > >> > > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it > >> > > without this argument, resulting in below build error. > >> > > > >> > > >> > Where do you see this error? That patch is not even merged. Looks like you are > >> > sending the patch against some downstream tree. > >> > >> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip > >> > >> This commit is merged in drm-intel/topic/core-for-CI - > >> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI > >> > > > > Okay. Since this patch is just for CI, please do not CC linux-pci as it causes > > confusion. > > Agreed. More on-topic for linux-pci is what happened with [1]. > > We've been running CI with that for months now to avoid lockdep splats, > and it's obviously in everyone's best interest to get a fix upstream. > Yes, ofc. Right now we have 2 series/patches to fix the locking issue: https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@linux.intel.com/ https://lore.kernel.org/linux-pci/20231128081512.19387-1-johan+linaro@kernel.org/ Bjorn has to choose one among them. - Mani > David, Bjorn? > > > BR, > Jani. > > > [1] https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@linux.intel.com/ > > > > > > > > - Mani > > > >> Regards, > >> Vignesh > > -- > Jani Nikula, Intel -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VVcwBs/b" Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 881BF19AA for ; Tue, 28 Nov 2023 02:46:05 -0800 (PST) Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-77d5cf15280so286713285a.0 for ; Tue, 28 Nov 2023 02:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701168364; x=1701773164; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ody4rvie3s+8GD4mOiQPrgYycVPJoTVFCyOTzD8p7Dc=; b=VVcwBs/b2plLhMdowmgnpGeaR/p64jc/3wVcA5V9u1TArYgHpVYDo4b6sqX9UeSPn2 fMvWBNhS+aPCNenJRkw2pzCBwCx+3ZTv9N/7KDGoyI5dK13I9jVYJs1vM40vyz/vEPac jOTof+4QgMyY+hE3B8/La7TxTf42o/BDm39V7K3sxWZcoq/p7NxHJmjEx4aq+gxWA9yH Qq4C18MGFL4RFOw+6d3WnyJ56SP12ljjcwZIEAcXU9CcngJFCrSuz07J7vrcLDWOKMti I9plXoVv8KhfziDuXQA251s+5TeL4QfYJB4GMSL6raXlBNr9tIA/ap6Y1Kot2QPRAX40 ENlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701168364; x=1701773164; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ody4rvie3s+8GD4mOiQPrgYycVPJoTVFCyOTzD8p7Dc=; b=U2lxXB4cqllDUzMIsEZQvNAHb8ZeXYytuTHR0B93gy0IAzgE26l3mzBwPGLlb5Vp/U hGAJ4EdIYMt7oJMQE+3AFccwvSS7NVM+SvVZ53keJ7h+80HoU5MKjEZ/7/124w57quEg 7qYW5VPCZZaRyhPAKYqR1oee2cDqhUY4sP9wQ42W8K3Lp1ZOrJb+EAC+njWJbYAgUN0x vSzsD/ZICC0rHpqRZCKpWkKdxZ1JKBO3Z1XYKepYH32YbDytx6suIU8+9v1db+uEGYr6 LjN5f+SUNh1+b8npQNI/WxxRwt1aazi/1YsKVC3eakvByZ46nHm89Pkvvt7Z8jPPW+iY b7cg== X-Gm-Message-State: AOJu0YxCudPZwY8slkLDd5j7/JNdswZrwDYjbFXJksD8zt2zJhiCq/gO YfG7sizJx3Nn108iK+0rJCXJsmBtywMkKansNQ== X-Google-Smtp-Source: AGHT+IE8SWfZ7GqO4s0fMyj3jKQqECEGMDFDC8TEC7GRCVPyBE185OA3cmNu5rktS/g6Fo8eFgfD6g== X-Received: by 2002:a0c:fd6b:0:b0:67a:5457:77c9 with SMTP id k11-20020a0cfd6b000000b0067a545777c9mr3755673qvs.11.1701168364626; Tue, 28 Nov 2023 02:46:04 -0800 (PST) Received: from thinkpad ([59.92.99.177]) by smtp.gmail.com with ESMTPSA id b18-20020a0c9b12000000b0065b13180892sm5074170qve.16.2023.11.28.02.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 02:46:04 -0800 (PST) Date: Tue, 28 Nov 2023 16:15:49 +0530 From: Manivannan Sadhasivam To: Jani Nikula Cc: Vignesh Raman , "David E. Box" , Bjorn Helgaas , daniels@collabora.com, linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, helen.koike@collabora.com Subject: Re: [PATCH] PCI: qcom: Fix compile error Message-ID: <20231128104549.GM3088@thinkpad> References: <20231128042026.130442-1-vignesh.raman@collabora.com> <20231128051456.GA3088@thinkpad> <50a9f061-e1d3-6aca-b528-56dbb6c729d9@collabora.com> <20231128065104.GK3088@thinkpad> <87a5qy88mx.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a5qy88mx.fsf@intel.com> On Tue, Nov 28, 2023 at 12:39:02PM +0200, Jani Nikula wrote: > On Tue, 28 Nov 2023, Manivannan Sadhasivam wrote: > > On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: > >> Hi Mani, > >> > >> On 28/11/23 10:44, Manivannan Sadhasivam wrote: > >> > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > >> > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > >> > > to acquire bus lock") has added an argument to acquire bus lock > >> > > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it > >> > > without this argument, resulting in below build error. > >> > > > >> > > >> > Where do you see this error? That patch is not even merged. Looks like you are > >> > sending the patch against some downstream tree. > >> > >> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip > >> > >> This commit is merged in drm-intel/topic/core-for-CI - > >> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI > >> > > > > Okay. Since this patch is just for CI, please do not CC linux-pci as it causes > > confusion. > > Agreed. More on-topic for linux-pci is what happened with [1]. > > We've been running CI with that for months now to avoid lockdep splats, > and it's obviously in everyone's best interest to get a fix upstream. > Yes, ofc. Right now we have 2 series/patches to fix the locking issue: https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@linux.intel.com/ https://lore.kernel.org/linux-pci/20231128081512.19387-1-johan+linaro@kernel.org/ Bjorn has to choose one among them. - Mani > David, Bjorn? > > > BR, > Jani. > > > [1] https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@linux.intel.com/ > > > > > > > > - Mani > > > >> Regards, > >> Vignesh > > -- > Jani Nikula, Intel -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6269C4167B for ; Tue, 28 Nov 2023 10:46:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54DAA10E4BA; Tue, 28 Nov 2023 10:46:07 +0000 (UTC) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8EE4510E4B9 for ; Tue, 28 Nov 2023 10:46:05 +0000 (UTC) Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-41b7fd8f458so29775081cf.0 for ; Tue, 28 Nov 2023 02:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701168364; x=1701773164; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ody4rvie3s+8GD4mOiQPrgYycVPJoTVFCyOTzD8p7Dc=; b=QRtWCtCm4JbowQTveI3HZcUgb3qOgwjTwNGQbVorto9RswYqQe2CKT56+hu2AqUdn0 kYYijztFnyukkEZyqzeMGwAAEUc3cAkUkiEGu0csGQa2yMSEVOZnGZ8gMEh5r6nCFUaV 8YiL324NrTbBfqoGs+4w7kL1w3EY/i1ITjk2SL4OrBVKZRhr7UPXhCD6FZxvViHss8iJ 8RGRPhiQLXZkPqM7uh8cQ/wzl/WSUYLFO8QdDAOI0SR2ZRYrcHC7BSvPPCNK4ct0Jyoq P22bi404EDX8JUZisN3qPM7+x0HJNbTsERmeK5nTkS2AkdP+dY8j6NmnEXAMTU6ws0sO 5n0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701168364; x=1701773164; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ody4rvie3s+8GD4mOiQPrgYycVPJoTVFCyOTzD8p7Dc=; b=RlOtW2WVSb00m8E1fXb+vIozQp54lDYcA2iFjsPnj6hXwoCFpp9fq0cAJRDJzXqxMY xArUf8M3g9+zQJhkkRquwmJlasqyuvK8sBf4TlI33JPIvhbNtPcIAC2FXDrk+GcjPS34 OlEUziAjPNe1irfwnJfTDserPkgNiyAD5OuUEVWQiIortg/BWu4VsNvYISEdcMr2lHFH 2/g3al8/O8y5/L7qacEowLu8IxaH9+7PLu2sSuRtrdtkrSY1v6FmxG42u7ZoV9WnfHwk wnr18XKs5DGJVbfoIotD/I7zUrBBe/FFcuOSj/8UpwS58H5JnD3OxJgK+4YN5PxKKE1/ nUqQ== X-Gm-Message-State: AOJu0YwbTgyLqqYayjLZjuep5NYOK9UznWIuaOxZkKK9Lwl6puHnuSEw GGvXn3uuJA3IIFoAOoksUfDz X-Google-Smtp-Source: AGHT+IE8SWfZ7GqO4s0fMyj3jKQqECEGMDFDC8TEC7GRCVPyBE185OA3cmNu5rktS/g6Fo8eFgfD6g== X-Received: by 2002:a0c:fd6b:0:b0:67a:5457:77c9 with SMTP id k11-20020a0cfd6b000000b0067a545777c9mr3755673qvs.11.1701168364626; Tue, 28 Nov 2023 02:46:04 -0800 (PST) Received: from thinkpad ([59.92.99.177]) by smtp.gmail.com with ESMTPSA id b18-20020a0c9b12000000b0065b13180892sm5074170qve.16.2023.11.28.02.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 02:46:04 -0800 (PST) Date: Tue, 28 Nov 2023 16:15:49 +0530 From: Manivannan Sadhasivam To: Jani Nikula Subject: Re: [PATCH] PCI: qcom: Fix compile error Message-ID: <20231128104549.GM3088@thinkpad> References: <20231128042026.130442-1-vignesh.raman@collabora.com> <20231128051456.GA3088@thinkpad> <50a9f061-e1d3-6aca-b528-56dbb6c729d9@collabora.com> <20231128065104.GK3088@thinkpad> <87a5qy88mx.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a5qy88mx.fsf@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniels@collabora.com, linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org, Vignesh Raman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, helen.koike@collabora.com, Bjorn Helgaas , "David E. Box" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Nov 28, 2023 at 12:39:02PM +0200, Jani Nikula wrote: > On Tue, 28 Nov 2023, Manivannan Sadhasivam wrote: > > On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: > >> Hi Mani, > >> > >> On 28/11/23 10:44, Manivannan Sadhasivam wrote: > >> > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > >> > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > >> > > to acquire bus lock") has added an argument to acquire bus lock > >> > > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it > >> > > without this argument, resulting in below build error. > >> > > > >> > > >> > Where do you see this error? That patch is not even merged. Looks like you are > >> > sending the patch against some downstream tree. > >> > >> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip > >> > >> This commit is merged in drm-intel/topic/core-for-CI - > >> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI > >> > > > > Okay. Since this patch is just for CI, please do not CC linux-pci as it causes > > confusion. > > Agreed. More on-topic for linux-pci is what happened with [1]. > > We've been running CI with that for months now to avoid lockdep splats, > and it's obviously in everyone's best interest to get a fix upstream. > Yes, ofc. Right now we have 2 series/patches to fix the locking issue: https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@linux.intel.com/ https://lore.kernel.org/linux-pci/20231128081512.19387-1-johan+linaro@kernel.org/ Bjorn has to choose one among them. - Mani > David, Bjorn? > > > BR, > Jani. > > > [1] https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@linux.intel.com/ > > > > > > > > - Mani > > > >> Regards, > >> Vignesh > > -- > Jani Nikula, Intel -- மணிவண்ணன் சதாசிவம்