From: Jakub Kicinski <kuba@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haseeb Gani <hgani@marvell.com>,
Vimlesh Kumar <vimleshk@marvell.com>,
"egallen@redhat.com" <egallen@redhat.com>,
"mschmidt@redhat.com" <mschmidt@redhat.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"wizhao@redhat.com" <wizhao@redhat.com>,
"konguyen@redhat.com" <konguyen@redhat.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Sathesh B Edara <sedara@marvell.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [EXT] Re: [PATCH net-next v1 1/2] octeon_ep: implement device unload control net API
Date: Tue, 28 Nov 2023 13:54:50 -0800 [thread overview]
Message-ID: <20231128135450.4542dfe0@kernel.org> (raw)
In-Reply-To: <PH0PR18MB4734B57CC289557366F68A47C7BCA@PH0PR18MB4734.namprd18.prod.outlook.com>
On Tue, 28 Nov 2023 19:08:26 +0000 Shinas Rasheed wrote:
> > Yes, I think it went in before I had time to nack it.
> > I'm strongly against using the IP stack to talk to FW,
> > if you read the ML you would know it.
> >
> > No new patches to octep_ctrl_net will be accepted.
>
> Control net doesn't use the IP stack at all. It's a simple
> producer-consumer based ring mechanism using PCIe BAR4 memory.
> Sorry maybe the nomenclature suggests something of that nature.
Ah, got it. I read that as "separate netdev for control", my bad.
Just one nit then:
>+ dev_info(&oct->pdev->dev, "Sending dev_unload msg to fw\n");
Is it really necessary to print this at info level for each remove?
Remove is a normal part of operation and we shouldn't spam logs
unless we have a good reason..
next prev parent reply other threads:[~2023-11-28 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 16:21 [PATCH net-next v1 0/2] support OCTEON CN98 devices Shinas Rasheed
2023-11-27 16:21 ` [PATCH net-next v1 1/2] octeon_ep: implement device unload control net API Shinas Rasheed
2023-11-28 2:43 ` Jakub Kicinski
2023-11-28 4:22 ` [EXT] " Shinas Rasheed
2023-11-28 16:27 ` Jakub Kicinski
2023-11-28 19:08 ` Shinas Rasheed
2023-11-28 21:54 ` Jakub Kicinski [this message]
2023-11-29 4:42 ` Shinas Rasheed
2023-11-27 16:21 ` [PATCH net-next v1 2/2] octeon_ep: support OCTEON CN98 devices Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128135450.4542dfe0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=konguyen@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.