From: Jakub Kicinski <kuba@kernel.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Kent Overstreet' <kent.overstreet@linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] rhashtable: Better error message on allocation failure
Date: Tue, 28 Nov 2023 17:35:36 -0800 [thread overview]
Message-ID: <20231128173536.35ff7e9c@kernel.org> (raw)
In-Reply-To: <36bcdab2dae7429d9c2162879d0a3f9a@AcuMS.aculab.com>
On Sat, 25 Nov 2023 15:23:49 +0000 David Laight wrote:
> > + new_tbl = bucket_table_alloc(ht, size, GFP_KERNEL|__GFP_NOWARN);
> > + if (new_tbl == NULL) {
> > + WARN("rhashtable bucket table allocation failure for %ps",
>
> Won't WARN() be a panic on systems with PANICK_ON_WARN set?
Yes, that's problematic :(
Let's leave out the GFP_NOWARN and add a pr_warn() instead of
the WARN()?
next prev parent reply other threads:[~2023-11-29 1:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 23:59 [PATCH] rhashtable: Better error message on allocation failure Kent Overstreet
2023-11-25 15:23 ` David Laight
2023-11-29 1:35 ` Jakub Kicinski [this message]
2023-11-29 1:57 ` Kent Overstreet
2023-11-29 2:15 ` Jakub Kicinski
2023-11-29 9:20 ` David Laight
-- strict thread matches above, loose matches on Subject: below --
2023-11-22 23:32 Kent Overstreet
2023-11-23 8:32 ` Herbert Xu
2023-11-23 23:58 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128173536.35ff7e9c@kernel.org \
--to=kuba@kernel.org \
--cc=David.Laight@ACULAB.COM \
--cc=herbert@gondor.apana.org.au \
--cc=kent.overstreet@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.