From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, f.fainelli@gmail.com, mkubecek@suse.cz
Subject: Re: [PATCH net] ethtool: don't propagate EOPNOTSUPP from dumps
Date: Tue, 28 Nov 2023 17:48:18 +0000 [thread overview]
Message-ID: <20231128174818.GB43811@kernel.org> (raw)
In-Reply-To: <20231126225806.2143528-1-kuba@kernel.org>
On Sun, Nov 26, 2023 at 02:58:06PM -0800, Jakub Kicinski wrote:
> The default dump handler needs to clear ret before returning.
> Otherwise if the last interface returns an inconsequential
> error this error will propagate to user space.
>
> This may confuse user space (ethtool CLI seems to ignore it,
> but YNL doesn't). It will also terminate the dump early
> for mutli-skb dump, because netlink core treats EOPNOTSUPP
> as a real error.
>
> Fixes: 728480f12442 ("ethtool: default handlers for GET requests")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-11-28 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 22:58 [PATCH net] ethtool: don't propagate EOPNOTSUPP from dumps Jakub Kicinski
2023-11-28 17:48 ` Simon Horman [this message]
2023-11-29 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128174818.GB43811@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.