All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina via buildroot <buildroot@buildroot.org>
To: "Maier,
	Brandon L                            Collins"
	<Brandon.Maier@collins.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [External] Re: [PATCH 1/1] ppd-merge: speed up per-package-rsync
Date: Tue, 28 Nov 2023 18:54:38 +0100	[thread overview]
Message-ID: <20231128185438.79867282@bootlin.com> (raw)
In-Reply-To: <BN0P110MB1673DA4D93BA42393EF18D4BEBBCA@BN0P110MB1673.NAMP110.PROD.OUTLOOK.COM>

Hi Brandon, Yann

On Tue, 28 Nov 2023 17:21:25 +0000
"Maier, Brandon L                            Collins" <Brandon.Maier@collins.com> wrote:

[...]

> > >  define per-package-rsync
> > > -   mkdir -p $(3)  
> >
> > Shouldn't the mkdir be kept here ?  
> 
> I moved it into ppd-merge.sh so that the script would be handling all the details of per-package-rsync.

Oops, my bad I missed it!

[...]
> > > +   PER_PACKAGE_DIR=$(PER_PACKAGE_DIR) \
> > > +           $(TOPDIR)/support/scripts/ppd-merge.sh \
> > > +           $(2) $(3) $(4) $(1)  
> >
> > What do you think about passing the PER_PACKAGE_DIR by parameter
> > instead of
> > mixing environment values and parameters ?  
> 
> I was trying to copy the style of support/scripts/fix-rpath, which takes PER_PACKAGE_DIR from the environment. For example, see ./Makefile "prepare-sdk:" target.
> 

Makes sense.
On the other hand, support/scripts/check-host-rpath takes PER_PACKAGE_DIR from parameters.
  https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/pkg-generic.mk?ref_type=heads#L62

I have no opinion about what is the best to do.
Maybe Yann ?

Best regards,
Hervé
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-11-28 17:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 22:41 [Buildroot] [PATCH 1/1] ppd-merge: speed up per-package-rsync Brandon Maier via buildroot
2023-11-28 15:49 ` Herve Codina via buildroot
2023-11-28 17:21   ` [Buildroot] [External] " Maier, Brandon L Collins via buildroot
2023-11-28 17:54     ` Herve Codina via buildroot [this message]
2023-11-28 18:04       ` Maier, Brandon L Collins via buildroot
2023-11-28 21:07 ` [Buildroot] " Yann E. MORIN
2023-11-29  0:00   ` [Buildroot] [External] " Maier, Brandon L Collins via buildroot
2023-11-29  8:17   ` [Buildroot] " Herve Codina via buildroot
2023-12-01 17:05 ` [Buildroot] [PATCH v2 " Brandon Maier via buildroot
2023-12-04 12:46   ` Herve Codina via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128185438.79867282@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=Brandon.Maier@collins.com \
    --cc=herve.codina@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.