All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wilken Gottwalt <wilken.gottwalt@posteo.net>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib: kstrtox: fix typo in comment
Date: Wed, 29 Nov 2023 04:48:34 +0000	[thread overview]
Message-ID: <20231129054834.2ffbe481@posteo.net> (raw)
In-Reply-To: <d9ac4b6c-e473-4c00-b016-a9cebdb59325@infradead.org>

On Tue, 28 Nov 2023 08:26:03 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 11/28/23 00:27, Wilken Gottwalt wrote:
> > Delete one of the double f's in "iff".
> > 
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@posteo.net>
> 
> Nope, see:
>   https://en.wikipedia.org/wiki/If_and_only_if

Oh, interesting. Never thought of this. Though, now I wonder: How often do such
"fixes" happen?

> > ---
> >  lib/kstrtox.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/kstrtox.c b/lib/kstrtox.c
> > index d586e6af5e5a..b0a9fdce15b3 100644
> > --- a/lib/kstrtox.c
> > +++ b/lib/kstrtox.c
> > @@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
> >   * @s: input string
> >   * @res: result
> >   *
> > - * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
> > + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
> >   * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL.  Value
> >   * pointed to by res is updated upon finding a match.
> >   */
> 


  reply	other threads:[~2023-11-29  4:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28  8:27 [PATCH] lib: kstrtox: fix typo in comment Wilken Gottwalt
2023-11-28 16:26 ` Randy Dunlap
2023-11-29  4:48   ` Wilken Gottwalt [this message]
2023-11-29  5:40     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231129054834.2ffbe481@posteo.net \
    --to=wilken.gottwalt@posteo.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.