[djwong-xfs:reconstruct-defer-work-6.7 5/7] fs/xfs/xfs_attr_item.c:585:3: error: expected expression

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git reconstruct-defer-work-6.7
head:   6b40cbdb0348d7c82b1729fba6d5352da1b949d3
commit: 36ee9012d43da805843689ce1c3e8a493a820d22 [5/7] xfs: recreate work items when recovering intent items
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231129/202311291048.s1Pak8AT-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231129/202311291048.s1Pak8AT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311291048.s1Pak8AT-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/xfs/xfs_attr_item.c:585:3: error: expected expression
                   int                     local;
                   ^
>> fs/xfs/xfs_attr_item.c:589:43: error: use of undeclared identifier 'local'
                   args->total = xfs_attr_calc_size(args, &local);
                                                           ^
   2 errors generated.


vim +585 fs/xfs/xfs_attr_item.c

   541	
   542	static inline struct xfs_attr_intent *
   543	xfs_attri_recover_work(
   544		struct xfs_mount		*mp,
   545		struct xfs_defer_pending	*dfp,
   546		struct xfs_attri_log_format	*attrp,
   547		struct xfs_inode		*ip,
   548		struct xfs_attri_log_nameval	*nv)
   549	{
   550		struct xfs_attr_intent		*attr;
   551		struct xfs_da_args		*args;
   552	
   553		attr = kmem_zalloc(sizeof(struct xfs_attr_intent) +
   554				   sizeof(struct xfs_da_args), KM_NOFS);
   555		args = (struct xfs_da_args *)(attr + 1);
   556	
   557		INIT_LIST_HEAD(&attr->xattri_list);
   558		attr->xattri_da_args = args;
   559		attr->xattri_op_flags = attrp->alfi_op_flags &
   560							XFS_ATTRI_OP_FLAGS_TYPE_MASK;
   561	
   562		/*
   563		 * We're reconstructing the deferred work state structure from the
   564		 * recovered log item.  Grab a reference to the name/value buffer and
   565		 * attach it to the new work state.
   566		 */
   567		attr->xattri_nameval = xfs_attri_log_nameval_get(nv);
   568		ASSERT(attr->xattri_nameval);
   569	
   570		args->dp = ip;
   571		args->geo = mp->m_attr_geo;
   572		args->whichfork = XFS_ATTR_FORK;
   573		args->name = nv->name.i_addr;
   574		args->namelen = nv->name.i_len;
   575		args->hashval = xfs_da_hashname(args->name, args->namelen);
   576		args->attr_filter = attrp->alfi_attr_filter & XFS_ATTRI_FILTER_MASK;
   577		args->op_flags = XFS_DA_OP_RECOVERY | XFS_DA_OP_OKNOENT |
   578				 XFS_DA_OP_LOGGED;
   579	
   580		ASSERT(xfs_sb_version_haslogxattrs(&mp->m_sb));
   581	
   582		switch (attr->xattri_op_flags) {
   583		case XFS_ATTRI_OP_FLAGS_SET:
   584		case XFS_ATTRI_OP_FLAGS_REPLACE:
 > 585			int			local;
   586	
   587			args->value = nv->value.i_addr;
   588			args->valuelen = nv->value.i_len;
 > 589			args->total = xfs_attr_calc_size(args, &local);
   590			if (xfs_inode_hasattr(args->dp))
   591				attr->xattri_dela_state = xfs_attr_init_replace_state(args);
   592			else
   593				attr->xattri_dela_state = xfs_attr_init_add_state(args);
   594			break;
   595		case XFS_ATTRI_OP_FLAGS_REMOVE:
   596			attr->xattri_dela_state = xfs_attr_init_remove_state(args);
   597			break;
   598		}
   599	
   600		xfs_defer_recover_work_item(dfp, &attr->xattri_list);
   601		return attr;
   602	}
   603	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki