From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3 00/19] btrfs: convert to the new mount API
Date: Wed, 29 Nov 2023 16:50:11 +0100 [thread overview]
Message-ID: <20231129155011.GS18929@suse.cz> (raw)
In-Reply-To: <3e4cd111-e5a8-6ffd-eb82-0312b6ae739c@oracle.com>
On Wed, Nov 29, 2023 at 08:59:57PM +0800, Anand Jain wrote:
> On 29/11/2023 05:15, David Sterba wrote:
> > On Wed, Nov 22, 2023 at 12:17:36PM -0500, Josef Bacik wrote:
> >> v2->v3:
> >> - Fixed up the various review comments from Dave and Anand.
> >> - Added a patch to drop the deprecated mount options we currently have.
> >
> > I finished review of v3, there were some changes missing from my v2
> > comments, I also did some renames and comment updates. Patches moved
> > from topic branch to misc-next, thanks.
> Apologies for the delayed review.
>
> The renaming of check_options() should have been in patch 2/19
> instead of patch 14/19, avoids confusion in the function stack.
Yeah it could have been renamed in patch 2, though I hope it's not a big
deal. The final name is with the btrfs_ prefix so the stack name
confusion would happen only when debugging something between patches 2
and 14.
> For now, except for the patches listed here [1],
> the remaining ones have been reviewed.
Thanks. In case you'd continue with the remaining patches feel free to
send rev-by later.
prev parent reply other threads:[~2023-11-29 15:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 17:17 [PATCH v3 00/19] btrfs: convert to the new mount API Josef Bacik
2023-11-22 17:17 ` [PATCH v3 01/19] fs: indicate request originates from old mount api Josef Bacik
2023-11-22 17:17 ` [PATCH v3 02/19] btrfs: split out the mount option validation code into its own helper Josef Bacik
2023-11-22 17:17 ` [PATCH v3 03/19] btrfs: set default compress type at btrfs_init_fs_info time Josef Bacik
2023-11-22 17:17 ` [PATCH v3 04/19] btrfs: move space cache settings into open_ctree Josef Bacik
2023-11-22 17:17 ` [PATCH v3 05/19] btrfs: do not allow free space tree rebuild on extent tree v2 Josef Bacik
2023-11-22 17:17 ` [PATCH v3 06/19] btrfs: split out ro->rw and rw->ro helpers into their own functions Josef Bacik
2023-11-22 17:17 ` [PATCH v3 07/19] btrfs: add a NOSPACECACHE mount option flag Josef Bacik
2023-11-22 17:17 ` [PATCH v3 08/19] btrfs: add fs_parameter definitions Josef Bacik
2023-11-22 17:17 ` [PATCH v3 09/19] btrfs: add parse_param callback for the new mount api Josef Bacik
2023-11-22 17:17 ` [PATCH v3 10/19] btrfs: add fs context handling functions Josef Bacik
2023-11-22 17:17 ` [PATCH v3 11/19] btrfs: add reconfigure callback for fs_context Josef Bacik
2023-11-22 17:17 ` [PATCH v3 12/19] btrfs: add get_tree callback for new mount API Josef Bacik
2023-11-22 17:17 ` [PATCH v3 13/19] btrfs: handle the ro->rw transition for mounting different subovls Josef Bacik
2023-11-22 17:17 ` [PATCH v3 14/19] btrfs: switch to the new mount API Josef Bacik
2023-11-22 17:17 ` [PATCH v3 15/19] btrfs: move the device specific mount options to super.c Josef Bacik
2023-11-22 17:17 ` [PATCH v3 16/19] btrfs: remove old mount API code Josef Bacik
2023-11-22 17:17 ` [PATCH v3 17/19] btrfs: move one shot mount option clearing to super.c Josef Bacik
2023-11-22 17:17 ` [PATCH v3 18/19] btrfs: set clear_cache if we use usebackuproot Josef Bacik
2023-11-22 17:17 ` [PATCH v3 19/19] btrfs: remove code for inode_cache and recovery mount options Josef Bacik
2023-11-22 17:41 ` [PATCH v3 00/19] btrfs: convert to the new mount API Neal Gompa
2023-11-22 18:29 ` David Sterba
2023-11-22 22:12 ` Neal Gompa
2023-11-22 22:55 ` David Sterba
2023-11-27 15:52 ` Josef Bacik
2023-11-28 21:15 ` David Sterba
2023-11-29 12:59 ` Anand Jain
2023-11-29 15:50 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129155011.GS18929@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.