From: Johannes Weiner <hannes@cmpxchg.org>
To: Nhat Pham <nphamcs@gmail.com>
Cc: akpm@linux-foundation.org, cerasuolodomenico@gmail.com,
yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org,
vitaly.wool@konsulko.com, mhocko@kernel.org,
roman.gushchin@linux.dev, shakeelb@google.com,
muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH v7 2/6] memcontrol: add a new function to traverse online-only memcg hierarchy
Date: Wed, 29 Nov 2023 12:00:01 -0500 [thread overview]
Message-ID: <20231129170001.GF135852@cmpxchg.org> (raw)
In-Reply-To: <20231129150403.GB135852@cmpxchg.org>
On Wed, Nov 29, 2023 at 10:04:05AM -0500, Johannes Weiner wrote:
> On Mon, Nov 27, 2023 at 03:45:56PM -0800, Nhat Pham wrote:
> > The new zswap writeback scheme requires an online-only memcg hierarchy
> > traversal. Add this functionality via the new mem_cgroup_iter_online()
> > function - the old mem_cgroup_iter() is a special case of this new
> > function.
> >
> > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Nhat Pham <nphamcs@gmail.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
I saw Michal's reply on the other thread only after I sent this.
I agree with him it would be better to just check mem_cgroup_online()
in the shinker callsite and leave mem_cgroup_iter() as-is. If it's
offline, just continue to the next mem_cgroup_iter() invocation.
next prev parent reply other threads:[~2023-11-29 17:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 23:45 [PATCH v7 0/6] workload-specific and memory pressure-driven zswap writeback Nhat Pham
2023-11-27 23:45 ` [PATCH v7 1/6] list_lru: allows explicit memcg and NUMA node selection Nhat Pham
2023-11-29 15:02 ` Johannes Weiner
2023-11-27 23:45 ` [PATCH v7 2/6] memcontrol: add a new function to traverse online-only memcg hierarchy Nhat Pham
2023-11-29 15:04 ` Johannes Weiner
2023-11-29 17:00 ` Johannes Weiner [this message]
2023-11-27 23:45 ` [PATCH v7 3/6] zswap: make shrinking memcg-aware Nhat Pham
2023-11-29 15:17 ` Johannes Weiner
2023-11-30 0:21 ` Nhat Pham
2023-11-30 1:17 ` Nhat Pham
2023-11-27 23:45 ` [PATCH v7 4/6] mm: memcg: add per-memcg zswap writeback stat Nhat Pham
2023-11-29 15:25 ` Johannes Weiner
2023-11-30 1:26 ` Nhat Pham
2023-11-27 23:45 ` [PATCH v7 5/6] selftests: cgroup: update per-memcg zswap writeback selftest Nhat Pham
2023-11-27 23:46 ` [PATCH v7 6/6] zswap: shrinks zswap pool based on memory pressure Nhat Pham
2023-11-29 16:21 ` Johannes Weiner
2023-11-29 23:44 ` Nhat Pham
2023-12-02 4:44 ` [PATCH v7 0/6] workload-specific and memory pressure-driven zswap writeback Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129170001.GF135852@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=chrisl@kernel.org \
--cc=ddstreet@ieee.org \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.