From: kernel test robot <lkp@intel.com>
To: Jorge Ramirez-Ortiz <jorge@foundries.io>,
ulf.hansson@linaro.org, adrian.hunter@intel.com,
CLoehle@hyperstone.com
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
axboe@kernel.dk, jinpu.wang@ionos.com, beanhuo@micron.com,
yibin.ding@unisoc.com, f.fainelli@gmail.com, asuk4.q@gmail.com,
victor.shih@genesyslogic.com.tw, marex@denx.de,
rafael.beims@toradex.com, robimarko@gmail.com,
ricardo@foundries.io
Subject: Re: [PATCH] mmc: rpmb: add quirk MMC_QUIRK_BROKEN_RPMB_RETUNE
Date: Wed, 29 Nov 2023 23:42:16 +0800 [thread overview]
Message-ID: <202311292325.iWCDyrUn-lkp@intel.com> (raw)
In-Reply-To: <20231129094350.2605322-1-jorge@foundries.io>
Hi Jorge,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.7-rc3 next-20231129]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jorge-Ramirez-Ortiz/mmc-rpmb-add-quirk-MMC_QUIRK_BROKEN_RPMB_RETUNE/20231129-181517
base: linus/master
patch link: https://lore.kernel.org/r/20231129094350.2605322-1-jorge%40foundries.io
patch subject: [PATCH] mmc: rpmb: add quirk MMC_QUIRK_BROKEN_RPMB_RETUNE
config: x86_64-rhel-8.3-bpf (https://download.01.org/0day-ci/archive/20231129/202311292325.iWCDyrUn-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231129/202311292325.iWCDyrUn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311292325.iWCDyrUn-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/mmc/core/mmc.c:27:
>> drivers/mmc/core/quirks.h:137:22: error: use of undeclared identifier 'CIF_MANFID_SANDISK2'
MMC_FIXUP("DG4064", CIF_MANFID_SANDISK2, 0x100, add_quirk_mmc,
^
drivers/mmc/core/mmc.c:115:22: warning: shift count >= width of type [-Wshift-count-overflow]
card->cid.serial = UNSTUFF_BITS(resp, 16, 32);
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/mmc/core/mmc.c:57:39: note: expanded from macro 'UNSTUFF_BITS'
const u32 __mask = (__size < 32 ? 1 << __size : 0) - 1; \
^ ~~~~~~
1 warning and 1 error generated.
--
In file included from drivers/mmc/core/sdio.c:23:
>> drivers/mmc/core/quirks.h:137:22: error: use of undeclared identifier 'CIF_MANFID_SANDISK2'
MMC_FIXUP("DG4064", CIF_MANFID_SANDISK2, 0x100, add_quirk_mmc,
^
1 error generated.
vim +/CIF_MANFID_SANDISK2 +137 drivers/mmc/core/quirks.h
17
18 static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
19 #define INAND_CMD38_ARG_EXT_CSD 113
20 #define INAND_CMD38_ARG_ERASE 0x00
21 #define INAND_CMD38_ARG_TRIM 0x01
22 #define INAND_CMD38_ARG_SECERASE 0x80
23 #define INAND_CMD38_ARG_SECTRIM1 0x81
24 #define INAND_CMD38_ARG_SECTRIM2 0x88
25 /* CMD38 argument is passed through EXT_CSD[113] */
26 MMC_FIXUP("SEM02G", CID_MANFID_SANDISK, 0x100, add_quirk,
27 MMC_QUIRK_INAND_CMD38),
28 MMC_FIXUP("SEM04G", CID_MANFID_SANDISK, 0x100, add_quirk,
29 MMC_QUIRK_INAND_CMD38),
30 MMC_FIXUP("SEM08G", CID_MANFID_SANDISK, 0x100, add_quirk,
31 MMC_QUIRK_INAND_CMD38),
32 MMC_FIXUP("SEM16G", CID_MANFID_SANDISK, 0x100, add_quirk,
33 MMC_QUIRK_INAND_CMD38),
34 MMC_FIXUP("SEM32G", CID_MANFID_SANDISK, 0x100, add_quirk,
35 MMC_QUIRK_INAND_CMD38),
36
37 /*
38 * Some MMC cards experience performance degradation with CMD23
39 * instead of CMD12-bounded multiblock transfers. For now we'll
40 * black list what's bad...
41 * - Certain Toshiba cards.
42 *
43 * N.B. This doesn't affect SD cards.
44 */
45 MMC_FIXUP("SDMB-32", CID_MANFID_SANDISK, CID_OEMID_ANY, add_quirk_mmc,
46 MMC_QUIRK_BLK_NO_CMD23),
47 MMC_FIXUP("SDM032", CID_MANFID_SANDISK, CID_OEMID_ANY, add_quirk_mmc,
48 MMC_QUIRK_BLK_NO_CMD23),
49 MMC_FIXUP("MMC08G", CID_MANFID_TOSHIBA, CID_OEMID_ANY, add_quirk_mmc,
50 MMC_QUIRK_BLK_NO_CMD23),
51 MMC_FIXUP("MMC16G", CID_MANFID_TOSHIBA, CID_OEMID_ANY, add_quirk_mmc,
52 MMC_QUIRK_BLK_NO_CMD23),
53 MMC_FIXUP("MMC32G", CID_MANFID_TOSHIBA, CID_OEMID_ANY, add_quirk_mmc,
54 MMC_QUIRK_BLK_NO_CMD23),
55
56 /*
57 * Kingston Canvas Go! Plus microSD cards never finish SD cache flush.
58 * This has so far only been observed on cards from 11/2019, while new
59 * cards from 2023/05 do not exhibit this behavior.
60 */
61 _FIXUP_EXT("SD64G", CID_MANFID_KINGSTON_SD, 0x5449, 2019, 11,
62 0, -1ull, SDIO_ANY_ID, SDIO_ANY_ID, add_quirk_sd,
63 MMC_QUIRK_BROKEN_SD_CACHE, EXT_CSD_REV_ANY),
64
65 /*
66 * Some SD cards lockup while using CMD23 multiblock transfers.
67 */
68 MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
69 MMC_QUIRK_BLK_NO_CMD23),
70 MMC_FIXUP("APUSD", CID_MANFID_APACER, 0x5048, add_quirk_sd,
71 MMC_QUIRK_BLK_NO_CMD23),
72
73 /*
74 * Some MMC cards need longer data read timeout than indicated in CSD.
75 */
76 MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc,
77 MMC_QUIRK_LONG_READ_TIME),
78 MMC_FIXUP("008GE0", CID_MANFID_TOSHIBA, CID_OEMID_ANY, add_quirk_mmc,
79 MMC_QUIRK_LONG_READ_TIME),
80
81 /*
82 * On these Samsung MoviNAND parts, performing secure erase or
83 * secure trim can result in unrecoverable corruption due to a
84 * firmware bug.
85 */
86 MMC_FIXUP("M8G2FA", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
87 MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
88 MMC_FIXUP("MAG4FA", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
89 MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
90 MMC_FIXUP("MBG8FA", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
91 MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
92 MMC_FIXUP("MCGAFA", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
93 MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
94 MMC_FIXUP("VAL00M", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
95 MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
96 MMC_FIXUP("VYL00M", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
97 MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
98 MMC_FIXUP("KYL00M", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
99 MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
100 MMC_FIXUP("VZL00M", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
101 MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
102
103 /*
104 * On Some Kingston eMMCs, performing trim can result in
105 * unrecoverable data conrruption occasionally due to a firmware bug.
106 */
107 MMC_FIXUP("V10008", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc,
108 MMC_QUIRK_TRIM_BROKEN),
109 MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc,
110 MMC_QUIRK_TRIM_BROKEN),
111
112 /*
113 * Micron MTFC4GACAJCN-1M supports TRIM but does not appear to support
114 * WRITE_ZEROES offloading. It also supports caching, but the cache can
115 * only be flushed after a write has occurred.
116 */
117 MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
118 MMC_QUIRK_TRIM_BROKEN | MMC_QUIRK_BROKEN_CACHE_FLUSH),
119
120 /*
121 * Kingston EMMC04G-M627 advertises TRIM but it does not seems to
122 * support being used to offload WRITE_ZEROES.
123 */
124 MMC_FIXUP("M62704", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc,
125 MMC_QUIRK_TRIM_BROKEN),
126
127 /*
128 * Some SD cards reports discard support while they don't
129 */
130 MMC_FIXUP(CID_NAME_ANY, CID_MANFID_SANDISK_SD, 0x5344, add_quirk_sd,
131 MMC_QUIRK_BROKEN_SD_DISCARD),
132
133 /*
134 * SanDisk iNAND 7250 DDG4064, this quirk shall disable the retune
135 * operation enforced by default when switching to RPMB.
136 */
> 137 MMC_FIXUP("DG4064", CIF_MANFID_SANDISK2, 0x100, add_quirk_mmc,
138 MMC_QUIRK_BROKEN_RPMB_RETUNE),
139
140 END_FIXUP
141 };
142
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2023-11-29 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 9:43 [PATCH] mmc: rpmb: add quirk MMC_QUIRK_BROKEN_RPMB_RETUNE Jorge Ramirez-Ortiz
[not found] ` <e159b627-22d4-489d-89a0-4de3be9af99b@arm.com>
2023-11-29 14:42 ` Jorge Ramirez-Ortiz, Foundries
2023-11-29 15:04 ` Christian Loehle
2023-11-29 15:42 ` kernel test robot
2023-11-29 15:42 ` kernel test robot
2023-11-29 15:42 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311292325.iWCDyrUn-lkp@intel.com \
--to=lkp@intel.com \
--cc=CLoehle@hyperstone.com \
--cc=adrian.hunter@intel.com \
--cc=asuk4.q@gmail.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=f.fainelli@gmail.com \
--cc=jinpu.wang@ionos.com \
--cc=jorge@foundries.io \
--cc=llvm@lists.linux.dev \
--cc=marex@denx.de \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael.beims@toradex.com \
--cc=ricardo@foundries.io \
--cc=robimarko@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=victor.shih@genesyslogic.com.tw \
--cc=yibin.ding@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.