From: Mengchi Cheng via ltp <ltp@lists.linux.it>
To: <ltp@lists.linux.it>
Cc: metan@ucw.cz, Mengchi Cheng <mengcc@amazon.com>
Subject: [LTP] [PATCH v1] rwtest: Confirm df is a symlink to busybox
Date: Wed, 29 Nov 2023 16:40:10 -0800 [thread overview]
Message-ID: <20231130004010.488496-1-mengcc@amazon.com> (raw)
/bin/df can be a symlink to coreutils. It returns correct info with dir
arguments.
Just checking if df is a symlink will include such cases. Need to make
sure it is linking to busybox before ignoring options.
Signed-off-by: Mengchi Cheng <mengcc@amazon.com>
---
testcases/kernel/fs/doio/rwtest | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/fs/doio/rwtest b/testcases/kernel/fs/doio/rwtest
index 6725e1426..26659e9d3 100644
--- a/testcases/kernel/fs/doio/rwtest
+++ b/testcases/kernel/fs/doio/rwtest
@@ -329,10 +329,10 @@ do
else
# If df is a symlink (to busybox) then do not pass the $dir and $dfOpts
# parameters because they don't work as expected
- if test -h $(which df)
- then
- dir=""; dfOpts="";
- fi
+ if [[ "$(readlink -f "$(which df)")" == *"busybox"* ]]
+ then
+ dir=""; dfOpts="";
+ fi
blks=$(df $dfOpts $dir |
(while read fs blks used avail cap mountpoint
--
2.25.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-11-30 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 0:40 Mengchi Cheng via ltp [this message]
2023-11-30 10:41 ` [LTP] [PATCH v1] rwtest: Confirm df is a symlink to busybox Petr Vorel
2023-11-30 10:53 ` Petr Vorel
2023-11-30 22:15 ` Mengchi Cheng via ltp
2023-12-01 8:22 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130004010.488496-1-mengcc@amazon.com \
--to=ltp@lists.linux.it \
--cc=mengcc@amazon.com \
--cc=metan@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.