Re: [PATCH 7/7] dma-mapping: Simplify arch_setup_dma_ops()

[kernel test robot <lkp@intel.com>]

Hi Robin,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master v6.7-rc3 next-20231129]
[cannot apply to joro-iommu/next rafael-pm/acpi-bus rafael-pm/devprop]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Robin-Murphy/OF-Simplify-DMA-range-calculations/20231130-024624
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/590a4a1b7d10fb9bb1c42ca6cd438e98e6cc94a7.1701268753.git.robin.murphy%40arm.com
patch subject: [PATCH 7/7] dma-mapping: Simplify arch_setup_dma_ops()
config: arm-aspeed_g5_defconfig (https://download.01.org/0day-ci/archive/20231130/202311301328.28ULuBXT-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231130/202311301328.28ULuBXT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311301328.28ULuBXT-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/thread_info.h:12,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/arm/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:79,
                    from include/linux/spinlock.h:56,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/umh.h:4,
                    from include/linux/kmod.h:9,
                    from include/linux/module.h:17,
                    from arch/arm/mm/dma-mapping.c:9:
   include/linux/dma-direct.h: In function 'dma_range_map_min':
   include/linux/limits.h:25:25: warning: conversion from 'long long unsigned int' to 'dma_addr_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Woverflow]
      25 | #define U64_MAX         ((u64)~0ULL)
         |                         ^
   include/linux/dma-direct.h:54:26: note: in expansion of macro 'U64_MAX'
      54 |         dma_addr_t ret = U64_MAX;
         |                          ^~~~~~~
   arch/arm/mm/dma-mapping.c: In function 'arch_setup_dma_ops':
>> arch/arm/mm/dma-mapping.c:1784:17: error: too few arguments to function 'arm_setup_iommu_dma_ops'
    1784 |                 arm_setup_iommu_dma_ops(dev);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~
   arch/arm/mm/dma-mapping.c:1755:13: note: declared here
    1755 | static void arm_setup_iommu_dma_ops(struct device *dev, u64 dma_base, u64 size,
         |             ^~~~~~~~~~~~~~~~~~~~~~~


vim +/arm_setup_iommu_dma_ops +1784 arch/arm/mm/dma-mapping.c

  1763	
  1764	void arch_setup_dma_ops(struct device *dev, bool coherent)
  1765	{
  1766		/*
  1767		 * Due to legacy code that sets the ->dma_coherent flag from a bus
  1768		 * notifier we can't just assign coherent to the ->dma_coherent flag
  1769		 * here, but instead have to make sure we only set but never clear it
  1770		 * for now.
  1771		 */
  1772		if (coherent)
  1773			dev->dma_coherent = true;
  1774	
  1775		/*
  1776		 * Don't override the dma_ops if they have already been set. Ideally
  1777		 * this should be the only location where dma_ops are set, remove this
  1778		 * check when all other callers of set_dma_ops will have disappeared.
  1779		 */
  1780		if (dev->dma_ops)
  1781			return;
  1782	
  1783		if (device_iommu_mapped(dev))
> 1784			arm_setup_iommu_dma_ops(dev);
  1785	
  1786		xen_setup_dma_ops(dev);
  1787		dev->archdata.dma_ops_setup = true;
  1788	}
  1789	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki