From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q5YLjf4M" Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 888FC10D9; Thu, 30 Nov 2023 07:56:41 -0800 (PST) Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6d7f3a4bbc6so616176a34.2; Thu, 30 Nov 2023 07:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701359801; x=1701964601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yvbtfdc0ukYgjaMnQaR3gnU2LYirrG4L32lYa3jmGOs=; b=Q5YLjf4MD9ZZlxFd/+uxbExVYRTpVt5P3ZnZZKbLHbSuTnm/JgqZejEKAcFxtLzqPu sZumIH1rMBpK/06P1KW1/RlXDIzThkkfEV4s6QfTHsrBqNuhlffW/sK/2hTwdzh1cxsF qlwuGQ/9UtIhh9QbUBUkBgbn4zAYHYUdewAqP+bPtSGIFK8PMm7BNnQz7lUCnoZPvyC6 ARgJ1VsMjygYvirTHOVHSsfJ8+LaY/+btwy9C+/3KiNlwWffxrxFX0x0tckg+fv2CplT vbKqf5+RmPKbWN06vzFCLAU5zsITxiokUT3acxU6VhT9+6qme3w5/XfDWiLYsvujjekc 6U8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701359801; x=1701964601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yvbtfdc0ukYgjaMnQaR3gnU2LYirrG4L32lYa3jmGOs=; b=cOsYv/ZiuuGiaZPj0X4Liq33Yru5y8tl+KvK/v+Dd95XKMi++9ni4mFuVHAxEp+U1b K7BLfFlzxBBJvcKp0drtxB9KCAiTgslIyy9yZhDCRccRgEj1686UpVNac6eCvYMhtRjo rzFya2672tcREATTu7uGuzpiMyasSye4rU6B5ou7Ri0Gpp//9I1t6Lj93Q0WbRcbLEON xW8CX2LFAtbYT8AJoFUu+rUyfSZhpNCARuiXM1eikdjUTpTaAsKl6IJmX/ypw0bLps0M Z2glwI7GpQ4ZvCdsK8P1QpQcYsvSfonx8ewPErpyAzBhsYF8ev6rHHbMt+uvSfT/9xVm KwEA== X-Gm-Message-State: AOJu0YxC+O05WtcUEDoBbjVxCD13cVk0ZUrwu7AYL+DXHm7vpDuxpEQ9 J4M1pE9zmbfQzNTdaH0aApKAqojoCZA= X-Google-Smtp-Source: AGHT+IGsSEdgmXvkMLWehieUnhkz5DRkyYhpKW9XKjn9lAcA+W/k0ia8pgSLGSBCNZTbWh63UjUhNw== X-Received: by 2002:a9d:66c6:0:b0:6d8:480f:7abf with SMTP id t6-20020a9d66c6000000b006d8480f7abfmr8615169otm.8.1701359800828; Thu, 30 Nov 2023 07:56:40 -0800 (PST) Received: from localhost.localdomain ([75.28.21.198]) by smtp.gmail.com with ESMTPSA id n25-20020a9d6f19000000b006d7ff27a47esm187852otq.77.2023.11.30.07.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 07:56:40 -0800 (PST) From: Chris Morgan To: linux-rockchip@lists.infradead.org Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, sboyd@kernel.org, mturquette@baylibre.com, tzimmermann@suse.de, mripard@kernel.org, maarten.lankhorst@linux.intel.com, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, quic_jesszhan@quicinc.com, neil.armstrong@linaro.org, javierm@redhat.com, heiko@sntech.de, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Chris Morgan Subject: [PATCH 7/9] clk: rockchip: Mark pclk_usb as critical on rk3568 Date: Thu, 30 Nov 2023 09:56:22 -0600 Message-Id: <20231130155624.405575-8-macroalpha82@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231130155624.405575-1-macroalpha82@gmail.com> References: <20231130155624.405575-1-macroalpha82@gmail.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chris Morgan In the reference manual under "2.8.6 NIU Clock gating reliance" it is stated that pclk_usb_niu has a dependency on hclk_usb_niu. While the manual does not state that this is a bi-directional relationship it was noted that the sdmmc2 failed to operate for me in mmc mode if the pclk_usb was not marked as critical. The parent clock of the hclk_sdmmc2 is hclk_usb. Signed-off-by: Chris Morgan --- drivers/clk/rockchip/clk-rk3568.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c index a8457b17bc41..0e0b7b396682 100644 --- a/drivers/clk/rockchip/clk-rk3568.c +++ b/drivers/clk/rockchip/clk-rk3568.c @@ -1596,6 +1596,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = { "pclk_php", "hclk_usb", "hclk_vo", + "pclk_usb", }; static const char *const rk3568_pmucru_critical_clocks[] __initconst = { -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23091C10DC3 for ; Thu, 30 Nov 2023 15:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sq69Nrw6eKKHq4/Wszp5FgkNn66nAkI29Altqk4dWzg=; b=Y3RjZCqZavNXSx ZclqKyROXlhEurhlrq1lNreXhxCCTX5eaGHuBFCKtPDhgseOB8mF4CV7IOn5Vlwmt2Y3joqdMlkUu v5eUdZWXDVesLZTdJKKSml78ym4s4cwVZ+gjemVhb/ZiiKpVENSmHNVIf5yr6q6n4KBfO+YGOre5t 9zRUhb86sDDpXidYD6W2JDSXT2GvorpvQsTIvC3PbcCrr248YpUz1QQe3zWWfcoL7zTJsvsH4SYPs rssG4ZFbKiXMigeOSRigLuCkqyMOlt42GGXllkhJSV1MubWHa7rbclU07XCU1ZQIldmBwnGiWkpYJ 5mWWVmJMWFz9woSAxyTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8jPF-00BGrU-1c; Thu, 30 Nov 2023 15:56:49 +0000 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8jPA-00BGlD-2x for linux-rockchip@lists.infradead.org; Thu, 30 Nov 2023 15:56:46 +0000 Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6d7f3a4bbc6so616177a34.2 for ; Thu, 30 Nov 2023 07:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701359801; x=1701964601; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yvbtfdc0ukYgjaMnQaR3gnU2LYirrG4L32lYa3jmGOs=; b=D5ha55WSFM09S9jftE1bOiKTRMablVfSDGGYFw23JlHwHXoPIRHT8SmiOmDQktjgkF l0VxKptF7QW4hborzAc355M4Teh51c7HDYCah2HE2P/KusAza0hafeIcmKwgvGC79Q7F uv4r5vZlWAth5pjiSKGeLrDIg0sUqrN2HRsAOcTSYHIVPzvlhb/BkgZAam91QfeMD5Wg /OHFx1qJt105OqXV84fGPYe350cSLIK0eRVaLITb/fQl2VT8/40WgZzLpICCV7BpUz28 LDKmNW4NTXc3Qbrow0nj+XjJ+xLuM+71C6EXRrufyK/+5bsD1jMBNLpf8AhH7Rf/ePPh E2WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701359801; x=1701964601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yvbtfdc0ukYgjaMnQaR3gnU2LYirrG4L32lYa3jmGOs=; b=Q+lqxYJ20FHGHrI9HJUdWovzzlpL+egwauRkt7jxaNwmhw+lVp571ayedr7VAW7Qof rPXzkQj0ncidzoD5EeendDWymF8KVB96K/2Zv5DT/jOeoiP/JZ7BA0D2sJnhEc52xBMN y4EDXADe5zymUYQs2Ud/gJ25UIgvtxs3NRp9yc8bS+VQhZ1cbNNWeMnsSoWXw1C8oX7B 8/GyqzM+stCiaVtxxe4eOEeBbsFqhnaYSI9f5sWuQ835AFQMOvKcP5zaU+En6QZYYgch 9SUJHT3ykawX3X82sqLv/XWjPfVxxJ0YlgXZk0jz/6KgiVoxo/pZtS3QUOkemfOs7YuU AbSg== X-Gm-Message-State: AOJu0Yya4GYElu4551MOQ3JtsLOCZkVsVP4tO/DfRCWw5H7krlWgpPm3 kpV8W9vmgX3sYMIvEQc8cXv0Fvw1dKk= X-Google-Smtp-Source: AGHT+IGsSEdgmXvkMLWehieUnhkz5DRkyYhpKW9XKjn9lAcA+W/k0ia8pgSLGSBCNZTbWh63UjUhNw== X-Received: by 2002:a9d:66c6:0:b0:6d8:480f:7abf with SMTP id t6-20020a9d66c6000000b006d8480f7abfmr8615169otm.8.1701359800828; Thu, 30 Nov 2023 07:56:40 -0800 (PST) Received: from localhost.localdomain ([75.28.21.198]) by smtp.gmail.com with ESMTPSA id n25-20020a9d6f19000000b006d7ff27a47esm187852otq.77.2023.11.30.07.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 07:56:40 -0800 (PST) From: Chris Morgan To: linux-rockchip@lists.infradead.org Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, sboyd@kernel.org, mturquette@baylibre.com, tzimmermann@suse.de, mripard@kernel.org, maarten.lankhorst@linux.intel.com, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, quic_jesszhan@quicinc.com, neil.armstrong@linaro.org, javierm@redhat.com, heiko@sntech.de, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Chris Morgan Subject: [PATCH 7/9] clk: rockchip: Mark pclk_usb as critical on rk3568 Date: Thu, 30 Nov 2023 09:56:22 -0600 Message-Id: <20231130155624.405575-8-macroalpha82@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231130155624.405575-1-macroalpha82@gmail.com> References: <20231130155624.405575-1-macroalpha82@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_075644_964073_59A98558 X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Chris Morgan In the reference manual under "2.8.6 NIU Clock gating reliance" it is stated that pclk_usb_niu has a dependency on hclk_usb_niu. While the manual does not state that this is a bi-directional relationship it was noted that the sdmmc2 failed to operate for me in mmc mode if the pclk_usb was not marked as critical. The parent clock of the hclk_sdmmc2 is hclk_usb. Signed-off-by: Chris Morgan --- drivers/clk/rockchip/clk-rk3568.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c index a8457b17bc41..0e0b7b396682 100644 --- a/drivers/clk/rockchip/clk-rk3568.c +++ b/drivers/clk/rockchip/clk-rk3568.c @@ -1596,6 +1596,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = { "pclk_php", "hclk_usb", "hclk_vo", + "pclk_usb", }; static const char *const rk3568_pmucru_critical_clocks[] __initconst = { -- 2.34.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C458FC07CA9 for ; Thu, 30 Nov 2023 15:57:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED3E010E71E; Thu, 30 Nov 2023 15:56:53 +0000 (UTC) Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9082D10E710 for ; Thu, 30 Nov 2023 15:56:41 +0000 (UTC) Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6d7f3a4bbc6so616175a34.2 for ; Thu, 30 Nov 2023 07:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701359801; x=1701964601; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yvbtfdc0ukYgjaMnQaR3gnU2LYirrG4L32lYa3jmGOs=; b=nebmK3RbML2hYy+4PxMkHLx/2A41BlmZxkFjsQUxpynQwhQDYP8rPKMxxWDEBBgbQu yKoSPOcyuXkL3bLf1nJelS7AOx6NHmZDV2QJKiHF33n/cFA+wM3ChxPB1tEw1DninrVk SeExmndQwEme0xgKQpqqzYTD1ySj8LiMVzDqJTWYgmea/bwNzkyobG19jY7rTpQ7ikuU 3Mq9lNGpgTo7QLE61IeCPMnH4yyzdIVggT+wTSzrMi4b3HSQE0iNq7YjgLpcppz+/sKF akIqOuwmRB8iCVDFFcfQ6crdFcd9qMcDlYE8MuWN/jpM5s/rWuM3SQTfbgLAYE5r4orX fzTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701359801; x=1701964601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yvbtfdc0ukYgjaMnQaR3gnU2LYirrG4L32lYa3jmGOs=; b=d5LCo9mZbO7TB5sXp2Hlpl2si6yf599LkA6crQLA0nmiHuyQL4Kpr2T6+MoofgCBFl BwURbG14+lyIveCcS/w/Cau8nb0J7L/3O66VszUaxKUAUaF5PlBUvZGPRSrs4pz9H622 QeNXQdMOSt5TcAck5W6Yqm8BaNt7g8luIfBv6DltwP+TSmCi93yQ9iQcz5kUEKdP+KVa umbr3tLS6IM8eiB/kOtkcFlBf8jQgLmjpL3o39/HM8O4OjLSZF35wSE23+tIRkRckZbE APzdsSOKhQ72dDP8H5dpSYT+li5s5jALSUCSeNZ+WF+tpRRjEdRlSk94p+FI4KOJVN2p s1qw== X-Gm-Message-State: AOJu0YwuRfn0DVqqvH/ONZ+aLc9ItuczamGzs0nv8WQrlgf1+5bebY3g sJZOviwfZZVM6zEdQkmoRso= X-Google-Smtp-Source: AGHT+IGsSEdgmXvkMLWehieUnhkz5DRkyYhpKW9XKjn9lAcA+W/k0ia8pgSLGSBCNZTbWh63UjUhNw== X-Received: by 2002:a9d:66c6:0:b0:6d8:480f:7abf with SMTP id t6-20020a9d66c6000000b006d8480f7abfmr8615169otm.8.1701359800828; Thu, 30 Nov 2023 07:56:40 -0800 (PST) Received: from localhost.localdomain ([75.28.21.198]) by smtp.gmail.com with ESMTPSA id n25-20020a9d6f19000000b006d7ff27a47esm187852otq.77.2023.11.30.07.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 07:56:40 -0800 (PST) From: Chris Morgan To: linux-rockchip@lists.infradead.org Subject: [PATCH 7/9] clk: rockchip: Mark pclk_usb as critical on rk3568 Date: Thu, 30 Nov 2023 09:56:22 -0600 Message-Id: <20231130155624.405575-8-macroalpha82@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231130155624.405575-1-macroalpha82@gmail.com> References: <20231130155624.405575-1-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, Chris Morgan , krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org, sboyd@kernel.org, sam@ravnborg.org, mturquette@baylibre.com, javierm@redhat.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, mripard@kernel.org, tzimmermann@suse.de, quic_jesszhan@quicinc.com, linux-clk@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Chris Morgan In the reference manual under "2.8.6 NIU Clock gating reliance" it is stated that pclk_usb_niu has a dependency on hclk_usb_niu. While the manual does not state that this is a bi-directional relationship it was noted that the sdmmc2 failed to operate for me in mmc mode if the pclk_usb was not marked as critical. The parent clock of the hclk_sdmmc2 is hclk_usb. Signed-off-by: Chris Morgan --- drivers/clk/rockchip/clk-rk3568.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c index a8457b17bc41..0e0b7b396682 100644 --- a/drivers/clk/rockchip/clk-rk3568.c +++ b/drivers/clk/rockchip/clk-rk3568.c @@ -1596,6 +1596,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = { "pclk_php", "hclk_usb", "hclk_vo", + "pclk_usb", }; static const char *const rk3568_pmucru_critical_clocks[] __initconst = { -- 2.34.1