From: Jakub Kicinski <kuba@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hgani@marvell.com>, <vimleshk@marvell.com>, <egallen@redhat.com>,
<mschmidt@redhat.com>, <pabeni@redhat.com>, <horms@kernel.org>,
<davem@davemloft.net>, <wizhao@redhat.com>, <konguyen@redhat.com>,
"Veerasenareddy Burru" <vburru@marvell.com>,
Sathesh Edara <sedara@marvell.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next v1] octeon_ep: control net API framework to support offloads
Date: Fri, 1 Dec 2023 19:58:43 -0800 [thread overview]
Message-ID: <20231201195843.118fdcfe@kernel.org> (raw)
In-Reply-To: <20231201131815.2566189-1-srasheed@marvell.com>
On Fri, 1 Dec 2023 05:18:14 -0800 Shinas Rasheed wrote:
> +static netdev_features_t octep_fix_features(struct net_device *dev,
> + netdev_features_t features)
> +{
> + return (dev->hw_features & features);
> +}
Why is this needed? The core kernel should already make sure
unsupported features aren't requested.
next prev parent reply other threads:[~2023-12-02 3:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 13:18 [PATCH net-next v1] octeon_ep: control net API framework to support offloads Shinas Rasheed
2023-12-02 3:58 ` Jakub Kicinski [this message]
2023-12-04 6:39 ` [EXT] " Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201195843.118fdcfe@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=konguyen@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.