From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 2/4] mm: multi-gen LRU: MGLRU unbalance reclaim
Date: Mon, 4 Dec 2023 02:55:29 +0800 [thread overview]
Message-ID: <202312040256.guajrRNm-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20231108065818.19932-3-link@vivo.com>
References: <20231108065818.19932-3-link@vivo.com>
TO: Huan Yang <link@vivo.com>
TO: Tejun Heo <tj@kernel.org>
TO: Zefan Li <lizefan.x@bytedance.com>
TO: Johannes Weiner <hannes@cmpxchg.org>
TO: Jonathan Corbet <corbet@lwn.net>
TO: Michal Hocko <mhocko@kernel.org>
TO: Roman Gushchin <roman.gushchin@linux.dev>
TO: Shakeel Butt <shakeelb@google.com>
TO: Muchun Song <muchun.song@linux.dev>
TO: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: David Hildenbrand <david@redhat.com>
TO: Matthew Wilcox <willy@infradead.org>
TO: Huang Ying <ying.huang@intel.com>
TO: Yosry Ahmed <yosryahmed@google.com>
TO: Kefeng Wang <wangkefeng.wang@huawei.com>
TO: Peter Xu <peterx@redhat.com>
TO: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
TO: Liu Shixin <liushixin2@huawei.com>
TO: Yue Zhao <findns94@gmail.com>
TO: Hugh Dickins <hughd@google.com>
TO: cgroups@vger.kernel.org
TO: linux-doc@vger.kernel.org
TO: linux-kernel@vger.kernel.org
CC: opensource.kernel@vivo.com
CC: Huan Yang <link@vivo.com>
Hi Huan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on tj-cgroup/for-next linus/master v6.7-rc4 next-20231201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Huan-Yang/mm-vmscan-LRU-unbalance-cgroup-reclaim/20231108-151757
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20231108065818.19932-3-link%40vivo.com
patch subject: [PATCH 2/4] mm: multi-gen LRU: MGLRU unbalance reclaim
:::::: branch date: 4 weeks ago
:::::: commit date: 4 weeks ago
config: x86_64-randconfig-161-20231108 (https://download.01.org/0day-ci/archive/20231204/202312040256.guajrRNm-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231204/202312040256.guajrRNm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312040256.guajrRNm-lkp@intel.com/
smatch warnings:
mm/vmscan.c:4518 isolate_folios() error: uninitialized symbol 'unbalance'.
vim +/unbalance +4518 mm/vmscan.c
ac35a490237446 Yu Zhao 2022-09-18 4480
ac35a490237446 Yu Zhao 2022-09-18 4481 static int isolate_folios(struct lruvec *lruvec, struct scan_control *sc, int swappiness,
ac35a490237446 Yu Zhao 2022-09-18 4482 int *type_scanned, struct list_head *list)
ac35a490237446 Yu Zhao 2022-09-18 4483 {
ac35a490237446 Yu Zhao 2022-09-18 4484 int i;
ac35a490237446 Yu Zhao 2022-09-18 4485 int type;
ac35a490237446 Yu Zhao 2022-09-18 4486 int scanned;
ac35a490237446 Yu Zhao 2022-09-18 4487 int tier = -1;
9da842af0b17c7 Huan Yang 2023-11-08 4488 bool unbalance;
ac35a490237446 Yu Zhao 2022-09-18 4489 DEFINE_MIN_SEQ(lruvec);
ac35a490237446 Yu Zhao 2022-09-18 4490
ac35a490237446 Yu Zhao 2022-09-18 4491 /*
ac35a490237446 Yu Zhao 2022-09-18 4492 * Try to make the obvious choice first. When anon and file are both
ac35a490237446 Yu Zhao 2022-09-18 4493 * available from the same generation, interpret swappiness 1 as file
ac35a490237446 Yu Zhao 2022-09-18 4494 * first and 200 as anon first.
ac35a490237446 Yu Zhao 2022-09-18 4495 */
9da842af0b17c7 Huan Yang 2023-11-08 4496 if (unlikely(unbalance_file_reclaim(sc, swappiness))) {
9da842af0b17c7 Huan Yang 2023-11-08 4497 unbalance = true;
9da842af0b17c7 Huan Yang 2023-11-08 4498 type = LRU_GEN_FILE;
9da842af0b17c7 Huan Yang 2023-11-08 4499 } else if (unlikely(unbalance_anon_reclaim(sc, swappiness))) {
9da842af0b17c7 Huan Yang 2023-11-08 4500 unbalance = true;
9da842af0b17c7 Huan Yang 2023-11-08 4501 type = LRU_GEN_ANON;
9da842af0b17c7 Huan Yang 2023-11-08 4502 } else if (!swappiness)
ac35a490237446 Yu Zhao 2022-09-18 4503 type = LRU_GEN_FILE;
ac35a490237446 Yu Zhao 2022-09-18 4504 else if (min_seq[LRU_GEN_ANON] < min_seq[LRU_GEN_FILE])
ac35a490237446 Yu Zhao 2022-09-18 4505 type = LRU_GEN_ANON;
ac35a490237446 Yu Zhao 2022-09-18 4506 else if (swappiness == 1)
ac35a490237446 Yu Zhao 2022-09-18 4507 type = LRU_GEN_FILE;
ac35a490237446 Yu Zhao 2022-09-18 4508 else if (swappiness == 200)
ac35a490237446 Yu Zhao 2022-09-18 4509 type = LRU_GEN_ANON;
ac35a490237446 Yu Zhao 2022-09-18 4510 else
ac35a490237446 Yu Zhao 2022-09-18 4511 type = get_type_to_scan(lruvec, swappiness, &tier);
ac35a490237446 Yu Zhao 2022-09-18 4512
ac35a490237446 Yu Zhao 2022-09-18 4513 for (i = !swappiness; i < ANON_AND_FILE; i++) {
ac35a490237446 Yu Zhao 2022-09-18 4514 if (tier < 0)
ac35a490237446 Yu Zhao 2022-09-18 4515 tier = get_tier_idx(lruvec, type);
ac35a490237446 Yu Zhao 2022-09-18 4516
ac35a490237446 Yu Zhao 2022-09-18 4517 scanned = scan_folios(lruvec, sc, type, tier, list);
9da842af0b17c7 Huan Yang 2023-11-08 @4518 if (scanned || unbalance)
ac35a490237446 Yu Zhao 2022-09-18 4519 break;
ac35a490237446 Yu Zhao 2022-09-18 4520
ac35a490237446 Yu Zhao 2022-09-18 4521 type = !type;
ac35a490237446 Yu Zhao 2022-09-18 4522 tier = -1;
ac35a490237446 Yu Zhao 2022-09-18 4523 }
ac35a490237446 Yu Zhao 2022-09-18 4524
ac35a490237446 Yu Zhao 2022-09-18 4525 *type_scanned = type;
ac35a490237446 Yu Zhao 2022-09-18 4526
ac35a490237446 Yu Zhao 2022-09-18 4527 return scanned;
ac35a490237446 Yu Zhao 2022-09-18 4528 }
ac35a490237446 Yu Zhao 2022-09-18 4529
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-12-03 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 18:55 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-11 18:32 [PATCH 2/4] mm: multi-gen LRU: MGLRU unbalance reclaim kernel test robot
2023-11-08 6:58 [RFC 0/4] Introduce unbalance proactive reclaim Huan Yang
2023-11-08 6:58 ` [PATCH 2/4] mm: multi-gen LRU: MGLRU unbalance reclaim Huan Yang
2023-11-08 12:34 ` kernel test robot
2023-11-09 11:08 ` kernel test robot
2023-12-04 6:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312040256.guajrRNm-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.