Re: [PATCH for 8.2] hw/audio/virtio-sound: mark the device as unmigratable

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Dec 04, 2023 at 08:28:37AM +0100, Volker Rümelin wrote:
> The virtio-sound device is currently not migratable. QEMU crashes
> on the source machine at some point during the migration with a
> segmentation fault.
> 
> Even with this bug fixed, the virtio-sound device doesn't migrate
> the state of the audio streams. For example, running streams leave
> the device on the destination machine in a broken condition.
> 
> Mark the device as unmigratable until these issues have been fixed.
> 
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/audio/virtio-snd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
> index 2fe966e311..b10fad1228 100644
> --- a/hw/audio/virtio-snd.c
> +++ b/hw/audio/virtio-snd.c
> @@ -68,6 +68,7 @@ static const VMStateDescription vmstate_virtio_snd_device = {
>  
>  static const VMStateDescription vmstate_virtio_snd = {
>      .name = TYPE_VIRTIO_SND,
> +    .unmigratable = 1,
>      .minimum_version_id = VIRTIO_SOUND_VM_VERSION,
>      .version_id = VIRTIO_SOUND_VM_VERSION,
>      .fields = (VMStateField[]) {
> -- 
> 2.35.3