From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PnzWPAXH" Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5764A187; Mon, 4 Dec 2023 10:57:32 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6d857f6f1c0so2688823a34.0; Mon, 04 Dec 2023 10:57:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701716251; x=1702321051; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jS34Td6ydiJu49ocw1zXulx/VuEOGYfI7vU1+EDroQA=; b=PnzWPAXHYt3LeXkZb4OL/l5BerD+0jX/oVOCBsrrVka+XMtK5QjiN4ZxAJc5mAepzJ KwZvwPTDYY1sy0AJ4nWISmyuW9XahSaTdL3o+HJQLLU428shcl4TowHON3AQvrK7rz5A xjKdGKQSJFowU3xCpU0U0JGnptwrbrylBWLEVFi47/ONDs4za2DIVcz3g/V3+Fu0xXPX tdbvp4XXCyC142lmntOebxUlzp7JesGev+pOfWyIaGTqnnnyW8YPS6AZxEfaDz9/ae29 JcWGtA0XhKHuKmB8vc+o6oHTBDADs3ysrhsyXW9GorlGMRb7YYfj5dCoj8jAevPsLHgI QPmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701716251; x=1702321051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jS34Td6ydiJu49ocw1zXulx/VuEOGYfI7vU1+EDroQA=; b=Qub0WqQbs3eJ+xr9jVJVTrJOGNI7+hXrgMe0KY5ZTVIw8fHML6Fo+8l/7GYJbxa9KF IRJH4AiyIEjaL2Lg32d3h6MBOERZ+5kmHI+XcExsMLZUTSXQf7KZVhnh4r367B+rncm6 qOmdT7YwNZbjIv8CNm9RcquJBKirpJroInfOLZj5n0pG/bdUf+4oZlxzDkQuCl+0i5tp Z1tq6QsJX/vC6/aWnU90sfKY7k0YlV2+uYoqaWn2tmFbOA2++JzaBIB0phzvGAhVqSD3 Td873ceownRtPf34tQa58FzFUQiiE+ukzxdVFgWW0IGNoFdHWe6RMJzjf38RZTc7kn6q 9J4w== X-Gm-Message-State: AOJu0YwwrBwHfVnz15YEdK+xLceA48WZ9SX7/mEOMKuniUt2ifxK4bu0 DR6JbfnbPPSGTMsVw5EXmBv2ty6Hvxc= X-Google-Smtp-Source: AGHT+IEUm8NisHgqn3y2rfnvd8YPgGCJGZWYz3Vvoe+MmLVG/2AgljpOpgZvYnOCvaNysMml8E1gGQ== X-Received: by 2002:a05:6830:d7:b0:6d8:74e2:5d22 with SMTP id x23-20020a05683000d700b006d874e25d22mr4372548oto.75.1701716251596; Mon, 04 Dec 2023 10:57:31 -0800 (PST) Received: from localhost.localdomain ([75.28.21.198]) by smtp.gmail.com with ESMTPSA id y25-20020a4a2d19000000b00581fc1af0a7sm2073303ooy.28.2023.12.04.10.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 10:57:31 -0800 (PST) From: Chris Morgan To: linux-rockchip@lists.infradead.org Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, sboyd@kernel.org, mturquette@baylibre.com, tzimmermann@suse.de, mripard@kernel.org, maarten.lankhorst@linux.intel.com, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, quic_jesszhan@quicinc.com, neil.armstrong@linaro.org, javierm@redhat.com, heiko@sntech.de, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Chris Morgan Subject: [PATCH V2 07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 Date: Mon, 4 Dec 2023 12:57:16 -0600 Message-Id: <20231204185719.569021-8-macroalpha82@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231204185719.569021-1-macroalpha82@gmail.com> References: <20231204185719.569021-1-macroalpha82@gmail.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chris Morgan In the reference manual under "2.8.6 NIU Clock gating reliance" it is stated that pclk_usb_niu has a dependency on hclk_usb_niu. While the manual does not state that this is a bi-directional relationship it was noted that the sdmmc2 failed to operate for me in mmc mode if the pclk_usb was not marked as critical. The parent clock of the hclk_sdmmc2 is hclk_usb. Signed-off-by: Chris Morgan --- drivers/clk/rockchip/clk-rk3568.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c index bfbcbb744327..c4fa2375dbfb 100644 --- a/drivers/clk/rockchip/clk-rk3568.c +++ b/drivers/clk/rockchip/clk-rk3568.c @@ -1595,6 +1595,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = { "pclk_php", "hclk_usb", "hclk_vo", + "pclk_usb", }; static const char *const rk3568_pmucru_critical_clocks[] __initconst = { -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ADF6C4167B for ; Mon, 4 Dec 2023 18:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QJxKQ+CZkjiyTosV6YhacFGlOeEhrnXH7WEu62JXw3E=; b=Fl3EFEqq4RLBVS amIJ0XTpr9jSn5zkpNHDaPZ/7ZYf/zZx+/wxMakjM7BoH+ARrB9arbCu53BaX+ySy4TPfuapogegE qB80vBCuX0yVEj7jAXyCMKfB4kYmiOdKq53j/cPfoxOqVItBS5tXZH1AWy+rclLlOYxg1FAOjstZy SdFhkDiBGS8hMFGWr/LlxBdwjhwIPgMQ6X0XSPDQIMQFovP2fFagKsOoiTxWrtu6piYIXhplaOuaH 1lW1aPZAPy0kyRmXyDaGHJhyNn6A0La07bMaHpq9AQUr4gSXqFQuIqou0R2nhkR5aVktNaqlt7n9Z 4HQg9rXRlgCW1LeOAx7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAE8T-005NxT-2v; Mon, 04 Dec 2023 18:57:41 +0000 Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAE8L-005NoZ-0f for linux-rockchip@lists.infradead.org; Mon, 04 Dec 2023 18:57:35 +0000 Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-6d81faeefc4so2682840a34.2 for ; Mon, 04 Dec 2023 10:57:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701716251; x=1702321051; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jS34Td6ydiJu49ocw1zXulx/VuEOGYfI7vU1+EDroQA=; b=ffjwjYLByNf6Lhw3bIl86vHGpfuN/IeB/6AjAdnhCXlI0CshPrwKksxZXcKjGs5jat uZUp+DQU9Ca4fAOoAbZZh/5quWYOAvC3Pt+A01hsMLMlP9FhuwBzgOvGZEzieVnF7FqY DOOyt2BGkUFuqKESCyPmyPy3W73q1mJHfF/eUnqT7z8t51EAtkyalbzVGgRCex/SD0ku cu9JmKrKdcCHGC+38CWYIcxmBWG9cEHj0hHpvm+ebVTQiUWxtPLS0r28YWEH26+pG6Ap I0U31kBZfRhKeAMSi7K5lVpeaU7iWo5/jOEFKdyo6OyyyqogT9oHxV+NMaWMVzRPiilx quhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701716251; x=1702321051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jS34Td6ydiJu49ocw1zXulx/VuEOGYfI7vU1+EDroQA=; b=QqRzi+kY1QxaxmdIaQG1TV9YqLY/6ldRW6L5c4xugy2cmONpTdBcTnfxqDNPKT5cMA 1CrphioIg6Y4mOLjn8+GULLRgepgkkIBrgrsCuFm5/v2iBM0yAhKRi3K+aJOJjvc8AuX UK0J9k1+YjGXM4UJwp/21bq2eiXrLjwuxvP8KYekZXamjMRAkgEkKUBosAiFdvhyku81 +3iUgMiGLWjNWHT18u3W9zGoFj+AkTDmuWMJZlqP1vaL0tGwLBSi49Hqe4gtcp2Ak+R4 AYth+1bzpQ++VH1/H708oUNHWc3OhcI4NluPuBqFONzke8xWV4i09XIQPo+aFuOXnq3X 7UfA== X-Gm-Message-State: AOJu0YyDw5XbFkfXKCNYZjSOzQrGtodHCy6H0j1WpoxNAgbOdp0bH/iQ 4YhPli+EDNOUwkOeKpYZrOWWe8q9Hb0= X-Google-Smtp-Source: AGHT+IEUm8NisHgqn3y2rfnvd8YPgGCJGZWYz3Vvoe+MmLVG/2AgljpOpgZvYnOCvaNysMml8E1gGQ== X-Received: by 2002:a05:6830:d7:b0:6d8:74e2:5d22 with SMTP id x23-20020a05683000d700b006d874e25d22mr4372548oto.75.1701716251596; Mon, 04 Dec 2023 10:57:31 -0800 (PST) Received: from localhost.localdomain ([75.28.21.198]) by smtp.gmail.com with ESMTPSA id y25-20020a4a2d19000000b00581fc1af0a7sm2073303ooy.28.2023.12.04.10.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 10:57:31 -0800 (PST) From: Chris Morgan To: linux-rockchip@lists.infradead.org Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, sboyd@kernel.org, mturquette@baylibre.com, tzimmermann@suse.de, mripard@kernel.org, maarten.lankhorst@linux.intel.com, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, quic_jesszhan@quicinc.com, neil.armstrong@linaro.org, javierm@redhat.com, heiko@sntech.de, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Chris Morgan Subject: [PATCH V2 07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 Date: Mon, 4 Dec 2023 12:57:16 -0600 Message-Id: <20231204185719.569021-8-macroalpha82@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231204185719.569021-1-macroalpha82@gmail.com> References: <20231204185719.569021-1-macroalpha82@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_105733_615500_3B2C9350 X-CRM114-Status: GOOD ( 10.65 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Chris Morgan In the reference manual under "2.8.6 NIU Clock gating reliance" it is stated that pclk_usb_niu has a dependency on hclk_usb_niu. While the manual does not state that this is a bi-directional relationship it was noted that the sdmmc2 failed to operate for me in mmc mode if the pclk_usb was not marked as critical. The parent clock of the hclk_sdmmc2 is hclk_usb. Signed-off-by: Chris Morgan --- drivers/clk/rockchip/clk-rk3568.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c index bfbcbb744327..c4fa2375dbfb 100644 --- a/drivers/clk/rockchip/clk-rk3568.c +++ b/drivers/clk/rockchip/clk-rk3568.c @@ -1595,6 +1595,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = { "pclk_php", "hclk_usb", "hclk_vo", + "pclk_usb", }; static const char *const rk3568_pmucru_critical_clocks[] __initconst = { -- 2.34.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28178C4167B for ; Mon, 4 Dec 2023 18:59:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE9DE10E3C4; Mon, 4 Dec 2023 18:59:22 +0000 (UTC) Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CBF810E3D5 for ; Mon, 4 Dec 2023 18:57:32 +0000 (UTC) Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6d81faeefc4so2682835a34.2 for ; Mon, 04 Dec 2023 10:57:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701716251; x=1702321051; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jS34Td6ydiJu49ocw1zXulx/VuEOGYfI7vU1+EDroQA=; b=DW+lToWB+c1uzaXTAMyY2nt5oS438vWViSf+YYNUvqOKwcPA6Sb+Ek6zmArWutloFP 7dmxvD2ACmcIRAjIh2DRzetnwrFN0UCDP616ECOAlODItMusaozvnKGbRtvVtaFlgm5a W9BRYidPE5/BVkxX1PMGkV5+tcqt+ixJtTbZPG2/GdJrqL/6EalTG53ylxExOK37k4U3 maT0zQQ2gc9HHMnhSpC+hle+FGZF6UDbooyA03VSs9ialW67NbdYHiOXdMWiIUQfKkEv wB2swUcb/v7FI0NXCWmilr1Pq2jUNnmWogEctJlo9ApmUj3rEvalY0GpGrkjn1t17jgT 5Ccw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701716251; x=1702321051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jS34Td6ydiJu49ocw1zXulx/VuEOGYfI7vU1+EDroQA=; b=vZ1q4yu2ZOCxFVrwucyA5WVYtDuv4jr7wQLmco7uMUHZqWURO75/xlLguRKLFq23WS RnEm1YM9JdaOODzK/BSET2gdRxIkk872DYDC3vSZA+KqRteaQna37NeaDLRIcZ1H02Qa ZnXdH1+T+A4m2oZeQzcsVF37UK164NazuQP1JHkfCK1L1m0Id7n4PWvnEXzka0u2m62p ah9HXAKU0EXOnrXHuZ+vRKHyRZoA2HPyQC5qTNGtMjc38ONQY2TMpkLcjYNCjg4q68DM PGa6W+bt4HZIuxVpt5q0D8CjiDw3zdyHpDFShHlc7Z2J4MmUFqOXd36dLP2jL8pOcj8h gsjQ== X-Gm-Message-State: AOJu0YybNz7do6Gc0Om7g1nuBji8U/2GFcn4/RhZ5SqRMmbCIW6Rhzz2 ASTcyIVpvOk/vUt8ZQ9mFyM= X-Google-Smtp-Source: AGHT+IEUm8NisHgqn3y2rfnvd8YPgGCJGZWYz3Vvoe+MmLVG/2AgljpOpgZvYnOCvaNysMml8E1gGQ== X-Received: by 2002:a05:6830:d7:b0:6d8:74e2:5d22 with SMTP id x23-20020a05683000d700b006d874e25d22mr4372548oto.75.1701716251596; Mon, 04 Dec 2023 10:57:31 -0800 (PST) Received: from localhost.localdomain ([75.28.21.198]) by smtp.gmail.com with ESMTPSA id y25-20020a4a2d19000000b00581fc1af0a7sm2073303ooy.28.2023.12.04.10.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 10:57:31 -0800 (PST) From: Chris Morgan To: linux-rockchip@lists.infradead.org Subject: [PATCH V2 07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 Date: Mon, 4 Dec 2023 12:57:16 -0600 Message-Id: <20231204185719.569021-8-macroalpha82@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231204185719.569021-1-macroalpha82@gmail.com> References: <20231204185719.569021-1-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, Chris Morgan , krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org, sboyd@kernel.org, sam@ravnborg.org, mturquette@baylibre.com, javierm@redhat.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, mripard@kernel.org, tzimmermann@suse.de, quic_jesszhan@quicinc.com, linux-clk@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Chris Morgan In the reference manual under "2.8.6 NIU Clock gating reliance" it is stated that pclk_usb_niu has a dependency on hclk_usb_niu. While the manual does not state that this is a bi-directional relationship it was noted that the sdmmc2 failed to operate for me in mmc mode if the pclk_usb was not marked as critical. The parent clock of the hclk_sdmmc2 is hclk_usb. Signed-off-by: Chris Morgan --- drivers/clk/rockchip/clk-rk3568.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c index bfbcbb744327..c4fa2375dbfb 100644 --- a/drivers/clk/rockchip/clk-rk3568.c +++ b/drivers/clk/rockchip/clk-rk3568.c @@ -1595,6 +1595,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = { "pclk_php", "hclk_usb", "hclk_vo", + "pclk_usb", }; static const char *const rk3568_pmucru_critical_clocks[] __initconst = { -- 2.34.1