From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH, RFC] libxfs: check the size of on-disk data structures
Date: Mon, 4 Dec 2023 21:04:42 +0100 [thread overview]
Message-ID: <20231204200442.GA18274@lst.de> (raw)
In-Reply-To: <20231204195306.GC361584@frogsfrogsfrogs>
On Mon, Dec 04, 2023 at 11:53:06AM -0800, Darrick J. Wong wrote:
> > #define XFS_CHECK_VALUE(value, expected) \
> > - BUILD_BUG_ON_MSG((value) != (expected), \
> > + static_assert((value) == (expected), \
>
> HAH LOL that's much better. I think I even see that kernel code is
> using it now, and wonder why BUG_BUILD_ON still exists.
Yup:
hch@brick:~/work/linux$ git-grep static_assert | wc -l
840
hch@brick:~/work/linux$ git-grep BUILD_BUG_ON_MSG | wc -l
92
> Going back for another cup of koolaid now,
Haha.
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Thanks. I was just getting ready to send out a series with this and
the xfs_ondisk.h move.
prev parent reply other threads:[~2023-12-04 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 16:33 [PATCH, RFC] libxfs: check the size of on-disk data structures Christoph Hellwig
2023-11-09 19:52 ` Darrick J. Wong
2023-11-10 5:08 ` Christoph Hellwig
2023-12-01 2:06 ` Darrick J. Wong
2023-12-04 4:37 ` Christoph Hellwig
2023-12-04 19:53 ` Darrick J. Wong
2023-12-04 20:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204200442.GA18274@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.