From: Mike Kravetz <mike.kravetz@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: muchun.song@linux.dev, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: hugetlb_vmemmap: use walk_page_range_novma() to simplify the code
Date: Mon, 4 Dec 2023 14:53:57 -0800 [thread overview]
Message-ID: <20231204225357.GC4129@monkey> (raw)
In-Reply-To: <20231127084645.27017-3-songmuchun@bytedance.com>
On 11/27/23 16:46, Muchun Song wrote:
> It is unnecessary to implement a series of dedicated page table walking
> helpers since there is already a general one walk_page_range_novma().
> So use it to simplify the code.
That is a very nice cleanup!
Much code is removed, but I could not find any issues.
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> mm/hugetlb_vmemmap.c | 148 ++++++++++++-------------------------------
> 1 file changed, 39 insertions(+), 109 deletions(-)
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2023-12-04 22:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 8:46 [PATCH 0/4] Code simplification and clean-up for hugetlb vmemmap Muchun Song
2023-11-27 8:46 ` [PATCH 1/4] mm: pagewalk: assert write mmap lock only for walking the user page tables Muchun Song
2023-12-01 11:09 ` Kefeng Wang
2023-12-02 8:08 ` Muchun Song
2023-12-02 9:25 ` Kefeng Wang
2023-12-02 9:47 ` Muchun Song
2023-12-04 21:39 ` Mike Kravetz
2023-11-27 8:46 ` [PATCH 2/4] mm: hugetlb_vmemmap: use walk_page_range_novma() to simplify the code Muchun Song
2023-12-04 22:53 ` Mike Kravetz [this message]
2023-11-27 8:46 ` [PATCH 3/4] mm: hugetlb_vmemmap: move PageVmemmapSelfHosted() check to split_vmemmap_huge_pmd() Muchun Song
2023-12-04 23:27 ` Mike Kravetz
2023-12-05 2:46 ` Muchun Song
2023-11-27 8:46 ` [PATCH 4/4] mm: hugetlb_vmemmap: convert page to folio Muchun Song
2023-12-05 0:15 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204225357.GC4129@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.