From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: chandanbabu@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: document what LARP means
Date: Mon, 4 Dec 2023 22:09:09 -0800 [thread overview]
Message-ID: <20231205060909.GN361584@frogsfrogsfrogs> (raw)
In-Reply-To: <20231205055642.GA30465@lst.de>
On Tue, Dec 05, 2023 at 06:56:42AM +0100, Christoph Hellwig wrote:
> On Mon, Dec 04, 2023 at 09:50:28PM -0800, Darrick J. Wong wrote:
> > How about these last couple of sentences?
> >
> > /*
> > * The "LARP" (Logged extended Attribute Recovery Persistence) debugging knob
> > * sets the XFS_DA_OP_LOGGED flag on all xfs_attr_set operations performed on
> > * V5 filesystems. As a result, the intermediate progress of all setxattr and
> > * removexattr operations are tracked via the log and can be restarted during
> > * recovery. This is useful for testing xattr recovery prior to merging of the
> > * parent pointer feature which requires it to maintain consistency, and may be
> > * enabled for userspace xattrs in the future.
> > */
>
> Oooh. So all the logged attrs work is preparation for parent pointers?
> That makes a whole lot of sense, but I've missed it so far. Yes, the
> above comment is great.
Yep! And that's coming in the year end megapatchbomb. :)
--D
> With that:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
next prev parent reply other threads:[~2023-12-05 6:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 5:36 [PATCHSET 0/2] xfs: elide defer work ->create_done if no intent Darrick J. Wong
2023-12-05 5:36 ` [PATCH 1/2] xfs: document what LARP means Darrick J. Wong
2023-12-05 5:38 ` Christoph Hellwig
2023-12-05 5:50 ` Darrick J. Wong
2023-12-05 5:56 ` Christoph Hellwig
2023-12-05 6:09 ` Darrick J. Wong [this message]
2023-12-05 5:36 ` [PATCH 2/2] xfs: elide ->create_done calls for unlogged deferred work Darrick J. Wong
2023-12-05 5:39 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 2:23 [PATCHSET v2 0/2] xfs: elide defer work ->create_done if no intent Darrick J. Wong
2023-12-07 2:28 ` [PATCH 1/2] xfs: document what LARP means Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205060909.GN361584@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandanbabu@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.