From: Boris Brezillon <boris.brezillon@collabora.com>
To: kernel test robot <lkp@intel.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v3 12/14] drm/panthor: Allow driver compilation
Date: Tue, 5 Dec 2023 09:06:21 +0100 [thread overview]
Message-ID: <20231205090621.56060945@collabora.com> (raw)
In-Reply-To: <202312051231.xeR6rO2B-lkp@intel.com>
On Tue, 5 Dec 2023 12:39:47 +0800
kernel test robot <lkp@intel.com> wrote:
> Hi Boris,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on drm-misc/drm-misc-next]
> [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.7-rc4 next-20231204]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Boris-Brezillon/drm-panthor-Add-GPU-register-definitions/20231205-023301
> base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
> patch link: https://lore.kernel.org/r/20231204173313.2098733-13-boris.brezillon%40collabora.com
> patch subject: [PATCH v3 12/14] drm/panthor: Allow driver compilation
> config: alpha-randconfig-r122-20231205 (https://download.01.org/0day-ci/archive/20231205/202312051231.xeR6rO2B-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 13.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20231205/202312051231.xeR6rO2B-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312051231.xeR6rO2B-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> >> drivers/gpu/drm/panthor/panthor_gem.c:98:24: sparse: sparse: Using plain integer as NULL pointer
>
> vim +98 drivers/gpu/drm/panthor/panthor_gem.c
>
> b982314ad8e9c0 Boris Brezillon 2023-12-04 57
> b982314ad8e9c0 Boris Brezillon 2023-12-04 58 /**
> b982314ad8e9c0 Boris Brezillon 2023-12-04 59 * panthor_kernel_bo_create() - Create and map a GEM object to a VM
> b982314ad8e9c0 Boris Brezillon 2023-12-04 60 * @ptdev: Device.
> b982314ad8e9c0 Boris Brezillon 2023-12-04 61 * @vm: VM to map the GEM to. If NULL, the kernel object is not GPU mapped.
> b982314ad8e9c0 Boris Brezillon 2023-12-04 62 * @size: Size of the buffer object.
> b982314ad8e9c0 Boris Brezillon 2023-12-04 63 * @bo_flags: Combination of drm_panthor_bo_flags flags.
> b982314ad8e9c0 Boris Brezillon 2023-12-04 64 * @vm_map_flags: Combination of drm_panthor_vm_bind_op_flags (only those
> b982314ad8e9c0 Boris Brezillon 2023-12-04 65 * that are related to map operations).
> b982314ad8e9c0 Boris Brezillon 2023-12-04 66 * @gpu_va: GPU address assigned when mapping to the VM.
> b982314ad8e9c0 Boris Brezillon 2023-12-04 67 * If gpu_va == PANTHOR_VM_KERNEL_AUTO_VA, the virtual address will be
> b982314ad8e9c0 Boris Brezillon 2023-12-04 68 * automatically allocated.
> b982314ad8e9c0 Boris Brezillon 2023-12-04 69 *
> b982314ad8e9c0 Boris Brezillon 2023-12-04 70 * Return: A valid pointer in case of success, an ERR_PTR() otherwise.
> b982314ad8e9c0 Boris Brezillon 2023-12-04 71 */
> b982314ad8e9c0 Boris Brezillon 2023-12-04 72 struct panthor_kernel_bo *
> b982314ad8e9c0 Boris Brezillon 2023-12-04 73 panthor_kernel_bo_create(struct panthor_device *ptdev, struct panthor_vm *vm,
> b982314ad8e9c0 Boris Brezillon 2023-12-04 74 size_t size, u32 bo_flags, u32 vm_map_flags,
> b982314ad8e9c0 Boris Brezillon 2023-12-04 75 u64 gpu_va)
> b982314ad8e9c0 Boris Brezillon 2023-12-04 76 {
> b982314ad8e9c0 Boris Brezillon 2023-12-04 77 struct drm_gem_shmem_object *obj;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 78 struct panthor_kernel_bo *kbo;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 79 struct panthor_gem_object *bo;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 80 int ret;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 81
> b982314ad8e9c0 Boris Brezillon 2023-12-04 82 kbo = kzalloc(sizeof(*kbo), GFP_KERNEL);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 83 if (!kbo)
> b982314ad8e9c0 Boris Brezillon 2023-12-04 84 return ERR_PTR(-ENOMEM);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 85
> b982314ad8e9c0 Boris Brezillon 2023-12-04 86 obj = drm_gem_shmem_create(&ptdev->base, size);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 87 if (IS_ERR(obj)) {
> b982314ad8e9c0 Boris Brezillon 2023-12-04 88 ret = PTR_ERR(obj);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 89 goto err_free_bo;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 90 }
> b982314ad8e9c0 Boris Brezillon 2023-12-04 91
> b982314ad8e9c0 Boris Brezillon 2023-12-04 92 bo = to_panthor_bo(&obj->base);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 93 size = obj->base.size;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 94 kbo->obj = &obj->base;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 95 bo->flags = bo_flags;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 96
> b982314ad8e9c0 Boris Brezillon 2023-12-04 97 if (!vm)
> b982314ad8e9c0 Boris Brezillon 2023-12-04 @98 return 0;
Oops, should be
return kbo;
here. I'll fix that in v4.
> b982314ad8e9c0 Boris Brezillon 2023-12-04 99
> b982314ad8e9c0 Boris Brezillon 2023-12-04 100 ret = panthor_vm_alloc_va(vm, gpu_va, size, &kbo->va_node);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 101 if (ret)
> b982314ad8e9c0 Boris Brezillon 2023-12-04 102 goto err_put_obj;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 103
> b982314ad8e9c0 Boris Brezillon 2023-12-04 104 ret = panthor_vm_map_bo_range(vm, bo, 0, size, kbo->va_node.start, vm_map_flags);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 105 if (ret)
> b982314ad8e9c0 Boris Brezillon 2023-12-04 106 goto err_free_va;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 107
> b982314ad8e9c0 Boris Brezillon 2023-12-04 108 bo->exclusive_vm_root_gem = panthor_vm_root_gem(vm);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 109 drm_gem_object_get(bo->exclusive_vm_root_gem);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 110 bo->base.base.resv = bo->exclusive_vm_root_gem->resv;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 111 return kbo;
> b982314ad8e9c0 Boris Brezillon 2023-12-04 112
> b982314ad8e9c0 Boris Brezillon 2023-12-04 113 err_free_va:
> b982314ad8e9c0 Boris Brezillon 2023-12-04 114 panthor_vm_free_va(vm, &kbo->va_node);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 115
> b982314ad8e9c0 Boris Brezillon 2023-12-04 116 err_put_obj:
> b982314ad8e9c0 Boris Brezillon 2023-12-04 117 drm_gem_object_put(&obj->base);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 118
> b982314ad8e9c0 Boris Brezillon 2023-12-04 119 err_free_bo:
> b982314ad8e9c0 Boris Brezillon 2023-12-04 120 kfree(kbo);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 121 return ERR_PTR(ret);
> b982314ad8e9c0 Boris Brezillon 2023-12-04 122 }
> b982314ad8e9c0 Boris Brezillon 2023-12-04 123
>
next prev parent reply other threads:[~2023-12-05 8:06 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 17:32 [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs Boris Brezillon
2023-12-04 17:32 ` [PATCH v3 01/14] drm/panthor: Add uAPI Boris Brezillon
2023-12-06 16:17 ` Steven Price
2023-12-18 13:20 ` Chris Diamand
2024-01-15 11:18 ` Boris Brezillon
2023-12-04 17:32 ` [PATCH v3 02/14] drm/panthor: Add GPU register definitions Boris Brezillon
2023-12-06 16:23 ` Steven Price
2023-12-04 17:32 ` [PATCH v3 03/14] drm/panthor: Add the device logical block Boris Brezillon
2023-12-06 16:55 ` Steven Price
2023-12-07 8:12 ` Boris Brezillon
2023-12-07 8:56 ` Boris Brezillon
2023-12-07 10:23 ` Steven Price
2023-12-07 10:49 ` Boris Brezillon
2023-12-07 11:11 ` [EXTERNAL] " Donald Robson
2023-12-22 13:26 ` Liviu Dudau
2023-12-22 14:04 ` Boris Brezillon
2023-12-04 17:32 ` [PATCH v3 04/14] drm/panthor: Add the GPU " Boris Brezillon
2023-12-07 16:05 ` Steven Price
2023-12-04 17:32 ` [PATCH v3 05/14] drm/panthor: Add GEM " Boris Brezillon
2023-12-07 16:38 ` Steven Price
2024-01-15 10:29 ` Boris Brezillon
2023-12-04 17:32 ` [PATCH v3 06/14] drm/panthor: Add the devfreq " Boris Brezillon
2023-12-05 9:42 ` Clément Péron
2023-12-04 17:33 ` [PATCH v3 07/14] drm/panthor: Add the MMU/VM " Boris Brezillon
2023-12-08 14:28 ` Steven Price
2024-01-15 11:04 ` Boris Brezillon
2024-01-15 17:31 ` Boris Brezillon
2024-01-15 17:38 ` Boris Brezillon
2024-01-15 17:41 ` Boris Brezillon
2024-01-15 18:09 ` Boris Brezillon
2023-12-04 17:33 ` [PATCH v3 08/14] drm/panthor: Add the FW " Boris Brezillon
2023-12-08 15:39 ` Steven Price
2023-12-18 21:25 ` Chris Diamand
2024-01-15 11:37 ` Boris Brezillon
2024-01-22 16:34 ` Boris Brezillon
2024-01-22 21:14 ` Chris Diamand
2023-12-20 15:12 ` Liviu Dudau
2024-01-15 12:56 ` Boris Brezillon
2023-12-04 17:33 ` [PATCH v3 09/14] drm/panthor: Add the heap " Boris Brezillon
2023-12-08 16:27 ` Steven Price
2024-01-15 11:15 ` Boris Brezillon
2023-12-04 17:33 ` [PATCH v3 10/14] drm/panthor: Add the scheduler " Boris Brezillon
2023-12-11 16:27 ` Steven Price
2024-01-15 13:03 ` Boris Brezillon
2023-12-19 11:50 ` Ketil Johnsen
2024-01-15 13:05 ` Boris Brezillon
2023-12-20 19:59 ` Ketil Johnsen
2024-01-15 13:11 ` Boris Brezillon
2023-12-04 17:33 ` [PATCH v3 11/14] drm/panthor: Add the driver frontend block Boris Brezillon
2023-12-13 11:47 ` Steven Price
2023-12-20 16:24 ` Liviu Dudau
2024-01-15 12:59 ` Boris Brezillon
2023-12-04 17:33 ` [PATCH v3 12/14] drm/panthor: Allow driver compilation Boris Brezillon
2023-12-05 4:39 ` kernel test robot
2023-12-05 8:06 ` Boris Brezillon [this message]
2023-12-05 14:38 ` kernel test robot
2023-12-05 23:34 ` kernel test robot
2023-12-13 13:18 ` Steven Price
2023-12-04 17:33 ` [PATCH v3 13/14] dt-bindings: gpu: mali-valhall-csf: Add support for Arm Mali CSF GPUs Boris Brezillon
2023-12-04 17:33 ` Boris Brezillon
2023-12-04 19:29 ` Rob Herring
2023-12-04 19:29 ` Rob Herring
2023-12-05 8:46 ` Boris Brezillon
2023-12-05 8:46 ` Boris Brezillon
2023-12-05 6:24 ` kernel test robot
2023-12-05 20:48 ` Rob Herring
2023-12-05 20:48 ` Rob Herring
2023-12-06 10:59 ` Liviu Dudau
2023-12-06 10:59 ` Liviu Dudau
2024-01-22 16:37 ` Boris Brezillon
2024-01-22 16:37 ` Boris Brezillon
2023-12-04 17:33 ` [PATCH v3 14/14] drm/panthor: Add an entry to MAINTAINERS Boris Brezillon
2023-12-13 13:51 ` Steven Price
2023-12-04 18:09 ` [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs Clément Péron
2023-12-05 8:04 ` Boris Brezillon
2023-12-05 8:48 ` Boris Brezillon
2023-12-06 15:47 ` Steven Price
2023-12-06 16:28 ` Boris Brezillon
2023-12-10 4:58 ` Tatsuyuki Ishi
2023-12-11 8:52 ` Boris Brezillon
2023-12-11 18:18 ` Faith Ekstrand
2024-01-15 14:18 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205090621.56060945@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.