From: kernel test robot <lkp@intel.com>
To: NeilBrown <neilb@suse.de>, Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Oleg Nesterov <oleg@redhat.com>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] nfsd: Don't leave work of closing files to a work queue.
Date: Tue, 5 Dec 2023 14:36:14 +0800 [thread overview]
Message-ID: <202312051443.02Ddb5pd-lkp@intel.com> (raw)
In-Reply-To: <20231204014042.6754-3-neilb@suse.de>
Hi NeilBrown,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on linus/master v6.7-rc4]
[cannot apply to brauner-vfs/vfs.all next-20231205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/NeilBrown/Allow-a-kthread-to-declare-that-it-calls-task_work_run/20231204-094248
base: tip/sched/core
patch link: https://lore.kernel.org/r/20231204014042.6754-3-neilb%40suse.de
patch subject: [PATCH 2/2] nfsd: Don't leave work of closing files to a work queue.
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20231205/202312051443.02Ddb5pd-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051443.02Ddb5pd-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051443.02Ddb5pd-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/nfsd/filecache.c:431: warning: Function parameter or member 'nn' not described in 'nfsd_file_dispose_some'
vim +431 fs/nfsd/filecache.c
425
426 /**
427 * nfsd_file_dispose_some
428 *
429 */
430 void nfsd_file_dispose_some(struct nfsd_net *nn)
> 431 {
432 struct nfsd_fcache_disposal *l = nn->fcache_disposal;
433 LIST_HEAD(dispose);
434 int i;
435
436 if (list_empty(&l->freeme))
437 return;
438 spin_lock(&l->lock);
439 for (i = 0; i < 8 && !list_empty(&l->freeme); i++)
440 list_move(l->freeme.next, &dispose);
441 spin_unlock(&l->lock);
442 if (!list_empty(&l->freeme))
443 svc_wake_up(nn->nfsd_serv);
444 nfsd_file_dispose_list(&dispose);
445 }
446
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2023-12-05 6:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 1:36 [PATCH 0/2 v2] Move all file-close work for nfsd into nfsd threads NeilBrown
2023-12-04 1:36 ` [PATCH 1/2] Allow a kthread to declare that it calls task_work_run() NeilBrown
2023-12-04 2:13 ` Jens Axboe
2023-12-04 21:02 ` NeilBrown
2023-12-04 22:09 ` Jens Axboe
2023-12-04 22:27 ` NeilBrown
2023-12-05 11:14 ` Christian Brauner
2023-12-05 14:06 ` Jeff Layton
2023-12-05 21:28 ` NeilBrown
2023-12-05 21:58 ` Jens Axboe
2023-12-05 22:03 ` Jens Axboe
2023-12-05 22:16 ` NeilBrown
2023-12-05 23:23 ` NeilBrown
2023-12-05 23:31 ` Jens Axboe
2023-12-06 14:24 ` Christian Brauner
2023-12-08 1:40 ` NeilBrown
2023-12-06 14:29 ` Christian Brauner
2023-12-06 5:44 ` Christoph Hellwig
2023-12-04 2:25 ` Matthew Wilcox
2023-12-04 21:04 ` NeilBrown
2023-12-04 2:40 ` Al Viro
2023-12-04 16:12 ` Oleg Nesterov
2023-12-04 21:20 ` NeilBrown
2023-12-05 6:27 ` Dave Chinner
2023-12-05 6:41 ` Dave Chinner
2023-12-05 8:48 ` NeilBrown
2023-12-05 11:29 ` Christian Brauner
2023-12-05 11:25 ` Christian Brauner
2023-12-05 14:23 ` Chuck Lever
2023-12-04 1:36 ` [PATCH 2/2] nfsd: Don't leave work of closing files to a work queue NeilBrown
2023-12-04 16:58 ` Chuck Lever
2023-12-04 22:21 ` NeilBrown
2023-12-04 23:48 ` Chuck Lever
2023-12-05 6:36 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312051443.02Ddb5pd-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.