All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Dhruva Gole <d-gole@ti.com>, Tom Rini <trini@konsulko.com>,
	<u-boot@lists.denx.de>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 1/2] doc: board: beagle: am62x_beagleplay: Delete SW_PRNG flag for OPTEE
Date: Tue, 5 Dec 2023 09:22:26 -0600	[thread overview]
Message-ID: <20231205152226.krqb3i7s3yo2zsab@extrovert> (raw)
In-Reply-To: <9bed6378-56f9-4a76-98a4-3516687a6033@ti.com>

On 08:46-20231205, Andrew Davis wrote:
> On 12/4/23 1:29 PM, Nishanth Menon wrote:
> > On 15:59-20231201, Dhruva Gole wrote:
> > > Delete the flag CFG_WITH_SOFTWARE_PRNG as it's not necessary/ boot
> > > requirement for this SoC
> > > 
> > > Signed-off-by: Dhruva Gole <d-gole@ti.com>
> > > ---
> > >   doc/board/beagle/am62x_beagleplay.rst | 1 -
> > >   1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/doc/board/beagle/am62x_beagleplay.rst b/doc/board/beagle/am62x_beagleplay.rst
> > > index 7784e62b0b71..50d7d3c620d7 100644
> > > --- a/doc/board/beagle/am62x_beagleplay.rst
> > > +++ b/doc/board/beagle/am62x_beagleplay.rst
> > > @@ -63,7 +63,6 @@ Set the variables corresponding to this platform:
> > >     # we dont use any extra TFA parameters
> > >     unset TFA_EXTRA_ARGS
> > >     export OPTEE_PLATFORM=k3-am62x
> > > -  export OPTEE_EXTRA_ARGS="CFG_WITH_SOFTWARE_PRNG=y"
> > >   .. include::  ../ti/am62x_sk.rst
> > >       :start-after: .. am62x_evm_rst_include_start_build_steps
> > > -- 
> > > 2.34.1
> > > 
> > NAK. RNG is needed to seed standard distros.
> 
> You have this backwards, setting WITH_SOFTWARE_PRNG=y forces the SW
> RNG, disabling the HW RNG. Without this line the HW RNG is the default.


That is not the rationale with which the series was posted. I would
prefer we use HW RNG by default. but as I understand there are a bunch
of f/w bugs preventing us from doing so. if they are resolved, then the
commit message argument should be that the bugs are fixed, so we can
easily use then with f/w version x.y.z onwards.
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2023-12-05 15:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 10:29 [PATCH 0/2] docs: AM62x: Remove SW_PRNG Flag for OPTEE Dhruva Gole
2023-12-01 10:29 ` [PATCH 1/2] doc: board: beagle: am62x_beagleplay: Delete SW_PRNG flag " Dhruva Gole
2023-12-04 19:29   ` Nishanth Menon
2023-12-05 14:46     ` Andrew Davis
2023-12-05 15:22       ` Nishanth Menon [this message]
2023-12-05 16:38         ` Andrew Davis
2023-12-01 10:29 ` [PATCH 2/2] doc: board: ti: am62x_sk: Remove SW_PRNG Flag " Dhruva Gole
2023-12-04 19:30 ` [PATCH 0/2] docs: AM62x: " Nishanth Menon
2023-12-05  5:27   ` Dhruva Gole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231205152226.krqb3i7s3yo2zsab@extrovert \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=d-gole@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.