From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net-next v9 13/15] p4tc: add runtime table entry create, update, get, delete, flush and dump
Date: Tue, 5 Dec 2023 22:04:22 +0800 [thread overview]
Message-ID: <202312052121.NV57fCuG-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20231201182904.532825-14-jhs@mojatatu.com>
References: <20231201182904.532825-14-jhs@mojatatu.com>
TO: Jamal Hadi Salim <jhs@mojatatu.com>
TO: netdev@vger.kernel.org
CC: deb.chatterjee@intel.com
CC: anjali.singhai@intel.com
CC: namrata.limaye@intel.com
CC: mleitner@redhat.com
CC: Mahesh.Shirshyad@amd.com
CC: tomasz.osinski@intel.com
CC: jiri@resnulli.us
CC: xiyou.wangcong@gmail.com
CC: davem@davemloft.net
CC: edumazet@google.com
CC: kuba@kernel.org
CC: pabeni@redhat.com
CC: vladbu@nvidia.com
CC: horms@kernel.org
CC: khalidm@nvidia.com
CC: toke@redhat.com
CC: daniel@iogearbox.net
CC: bpf@vger.kernel.org
Hi Jamal,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Jamal-Hadi-Salim/net-sched-act_api-increase-action-kind-string-length/20231202-032940
base: net-next/main
patch link: https://lore.kernel.org/r/20231201182904.532825-14-jhs%40mojatatu.com
patch subject: [PATCH net-next v9 13/15] p4tc: add runtime table entry create, update, get, delete, flush and dump
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: powerpc64-randconfig-r081-20231204 (https://download.01.org/0day-ci/archive/20231205/202312052121.NV57fCuG-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231205/202312052121.NV57fCuG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312052121.NV57fCuG-lkp@intel.com/
smatch warnings:
net/sched/p4tc/p4tc_tbl_entry.c:2555 p4tc_tbl_entry_dumpit() warn: can 'nl_path_attrs.pname' even be NULL?
vim +2555 net/sched/p4tc/p4tc_tbl_entry.c
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2491
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2492 int p4tc_tbl_entry_dumpit(struct net *net, struct sk_buff *skb,
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2493 struct netlink_callback *cb,
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2494 struct nlattr *arg, char *p_name)
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2495 {
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2496 struct p4tc_path_nlattrs nl_path_attrs = {0};
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2497 struct netlink_ext_ack *extack = cb->extack;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2498 u32 portid = NETLINK_CB(cb->skb).portid;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2499 const struct nlmsghdr *n = cb->nlh;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2500 struct nlattr *tb[P4TC_MAX + 1];
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2501 u32 ids[P4TC_PATH_MAX] = { 0 };
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2502 struct p4tcmsg *t_new;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2503 struct nlmsghdr *nlh;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2504 struct nlattr *pnatt;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2505 struct nlattr *root;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2506 struct p4tcmsg *t;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2507 u32 *arg_ids;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2508 int ret;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2509
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2510 ret = nla_parse_nested(tb, P4TC_MAX, arg, p4tc_policy, extack);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2511 if (ret < 0)
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2512 return ret;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2513
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2514 nlh = nlmsg_put(skb, portid, n->nlmsg_seq, RTM_P4TC_GET, sizeof(*t),
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2515 n->nlmsg_flags);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2516 if (!nlh)
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2517 return -ENOSPC;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2518
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2519 t = (struct p4tcmsg *)nlmsg_data(n);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2520 t_new = nlmsg_data(nlh);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2521 t_new->pipeid = t->pipeid;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2522 t_new->obj = t->obj;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2523
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2524 if (NL_REQ_ATTR_CHECK(extack, arg, tb, P4TC_PATH)) {
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2525 NL_SET_ERR_MSG(extack, "Must specify object path");
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2526 return -EINVAL;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2527 }
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2528
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2529 pnatt = nla_reserve(skb, P4TC_ROOT_PNAME, P4TC_PIPELINE_NAMSIZ);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2530 if (!pnatt)
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2531 return -ENOMEM;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2532
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2533 ids[P4TC_PID_IDX] = t_new->pipeid;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2534 arg_ids = nla_data(tb[P4TC_PATH]);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2535 memcpy(&ids[P4TC_TBLID_IDX], arg_ids, nla_len(tb[P4TC_PATH]));
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2536 nl_path_attrs.ids = ids;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2537
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2538 nl_path_attrs.pname = nla_data(pnatt);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2539 if (!p_name) {
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2540 /* Filled up by the operation or forced failure */
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2541 memset(nl_path_attrs.pname, 0, P4TC_PIPELINE_NAMSIZ);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2542 nl_path_attrs.pname_passed = false;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2543 } else {
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2544 strscpy(nl_path_attrs.pname, p_name, P4TC_PIPELINE_NAMSIZ);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2545 nl_path_attrs.pname_passed = true;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2546 }
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2547
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2548 root = nla_nest_start(skb, P4TC_ROOT);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2549 ret = p4tc_table_entry_dump(net, skb, tb[P4TC_PARAMS], &nl_path_attrs,
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2550 cb, extack);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2551 if (ret <= 0)
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2552 goto out;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2553 nla_nest_end(skb, root);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2554
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 @2555 if (nl_path_attrs.pname) {
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-12-05 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 14:04 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-01 18:28 [PATCH net-next v9 00/15] Introducing P4TC Jamal Hadi Salim
2023-12-01 18:29 ` [PATCH net-next v9 13/15] p4tc: add runtime table entry create, update, get, delete, flush and dump Jamal Hadi Salim
2023-12-06 5:34 ` Dan Carpenter
2023-12-06 15:08 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312052121.NV57fCuG-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.